Apache MyFaces
MyFaces Orchestra
MyFaces Orchestra - Modules
Release Notes
Foundation

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Total number of occurrences
@todo 0
TODO 22

Each tag is detailed below:

@todo

Number of occurrences found in the code: 0

TODO

Number of occurrences found in the code: 22

org.apache.myfaces.orchestra.conversation.AccessScopeManager Line
Make this error message less spring-specific. Spring is not the only IOC container that Orchestra can be used with. 96
org.apache.myfaces.orchestra.conversation.ConversationManager Line
fix serialization issues. 46
do not call new directly here, as it makes it impossible to configure an alternative ConversationManager instance. This is IOC and test unfriendly. 116
add the "user" name here, otherwise this debugging is not very useful except when testing a webapp with only one user. 263
add the deleted context ids to a list stored in the session, and redirect to an error page if any future request specifies this id. This catches things like going "back" into a flow that has ended, or navigating with the parent page of a popup flow (which kills the popup flow context) then trying to use the popup page. 361
org.apache.myfaces.orchestra.conversation.ConversationRequestParameterProvider Line
consider using a request-scope variable rather than a ThreadLocal; less damage if the flag is not reset.. 59
org.apache.myfaces.orchestra.conversation.jsf.components.UISeparateConversationContext Line
actually save the original value? 74
org.apache.myfaces.orchestra.conversation.servlet.ConversationManagerSessionListener Line
maybe touch the "last accessed" stamp for the conversation manager and all its children? Without this, a conversation that has been passivated might almost immediately get cleaned up after being reactivated. 174
org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope Line
what does Spring use this for???? 143
org.apache.myfaces.orchestra.conversation.spring.JpaPersistenceContextFactory Line
what happens when a bean invokes a method on itself? Does bind get called again? If so, then this implementation is inefficient as it will push itself onto the stack over and over again. This could be optimised by checking whether this is the current context, and if so just incrementing a counter rather than pushing onto a stack... 69
org.apache.myfaces.orchestra.conversation.spring.ScopedBeanTargetSource Line
deal with serialization issues here. When an http session containing conversation-scoped beans is serialized, instances of this type will of course be serialized too. But the "scope" and "objectFactory" members here are not serializable. Somehow instances of this class need enough information to relocate the appropriate objects on deserialization. 38
org.apache.myfaces.orchestra.conversation.spring.SimpleAdvisor Line
maybe it would be nice to allow an orchestra scope object to hold Advisors as well as just Advices, so that users can configure specific code to run only for specific methods of orchestra beans. <p> NB: In Spring2.5, this class can simply implement Advisor, and it will be applied to all methods. However in Spring2.0, class DefaultAdvisorChainFactory only accepts PointcutAdvisor or IntroductionAdvisor, and silently ignores Advisor classes that are not of those types. So here for Spring2.x compatibility we need to make this class a PointcutAdvisor with a dummy pointcut that matches all methods... 36
org.apache.myfaces.orchestra.frameworkAdapter.basic.BasicFrameworkAdapter Line
also look in the application scope. <p> 261
investigate invoking the jsp.ExpressionFactory class to look up the variable. Possibly that could be done in a different JspFrameworkAdapter class. 263
look up application-scoped objects. 283
org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager Line
investigate why this is transient. At least some callers of register call it only once per session, so if the session data is passed to another machine or is saved then restored then it seems the registered providers will be lost when they should not be... 63
remove this factory code. Not IOC-friendly. 94
org.apache.myfaces.orchestra.viewController.DefaultViewControllerNameMapper Line
move this list to some shared class. Other ViewControllerNameMapper implementations could find this list useful. Note, however, that it is servlet-specific. This class is supposed to not assume any particular request/response technology. 111
org.apache.myfaces.orchestra.viewController.ViewControllerManager Line
Consider renaming this method. It is very Orchestra-specific, although this ViewController framework is supposed to be generic. In fact this method is really just a "validate view" hook, and one of the validations that can be hooked in here is a conversation-check. 70
implement an endView callback too (and corresponding annotation). 108
implement isPostback() for JSF1.1 users? This is of course built-in for JSF1.2 users... 110
org.apache.myfaces.orchestra.viewController.ViewControllerNameMapper Line
should this class have the same warning as ViewControllerExecutor, and an equivalent abstract base class? 26