Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
17 | 0 | 0 | 1325 |
Files
org/apache/avalon/excalibur/pool/AbstractPool.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
41
|
| Missing a Javadoc comment. |
42
|
| Missing a Javadoc comment. |
43
|
| Name 'm_factory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Variable 'm_factory' must be private and have accessor methods. |
43
|
| Missing a Javadoc comment. |
44
|
| Name 'm_active' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Variable 'm_active' must be private and have accessor methods. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_ready' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Variable 'm_ready' must be private and have accessor methods. |
45
|
| Missing a Javadoc comment. |
46
|
| Name 'm_mutex' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
46
|
| Variable 'm_mutex' must be private and have accessor methods. |
46
|
| Missing a Javadoc comment. |
47
|
| Name 'm_initialized' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
47
|
| Variable 'm_initialized' must be private and have accessor methods. |
47
|
| Missing a Javadoc comment. |
48
|
| Name 'm_min' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| Variable 'm_min' must be private and have accessor methods. |
48
|
| '(' is followed by whitespace. |
54
|
| Expected @param tag for 'factory'. |
54
|
| ')' is preceded with whitespace. |
54
|
| Expected @throws tag for 'Exception'. |
54
|
| '{' should be on the previous line. |
55
|
| 'if' is not followed by whitespace. |
58
|
| '(' is followed by whitespace. |
58
|
| '(' is followed by whitespace. |
58
|
| ')' is preceded with whitespace. |
58
|
| ')' is preceded with whitespace. |
58
|
| '{' should be on the previous line. |
59
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Missing a Javadoc comment. |
64
|
| '{' should be on the previous line. |
66
|
| 'for' is not followed by whitespace. |
69
|
| '(' is followed by whitespace. |
69
|
| ')' is preceded with whitespace. |
69
|
| '{' should be on the previous line. |
70
|
| '(' is followed by whitespace. |
71
|
| ')' is preceded with whitespace. |
71
|
| Missing a Javadoc comment. |
79
|
| '{' should be on the previous line. |
81
|
| Missing a Javadoc comment. |
85
|
| '{' should be on the previous line. |
87
|
| Expected an @return tag. |
95
|
| Method 'newPoolable' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Expected @throws tag for 'Exception'. |
95
|
| '{' should be on the previous line. |
96
|
| 'cast' is not followed by whitespace. |
98
|
| Method 'removePoolable' is not designed for extension - needs to be abstract, final or empty. |
105
|
| '(' is followed by whitespace. |
105
|
| Parameter poolable should be final. |
105
|
| Expected @param tag for 'poolable'. |
105
|
| ')' is preceded with whitespace. |
105
|
| '{' should be on the previous line. |
106
|
| '{' should be on the previous line. |
108
|
| '(' is followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| '}' should be on the same line. |
110
|
| 'catch' is not followed by whitespace. |
111
|
| '(' is followed by whitespace. |
111
|
| ')' is preceded with whitespace. |
111
|
| '{' should be on the previous line. |
112
|
| 'if' is not followed by whitespace. |
113
|
| '(' is followed by whitespace. |
113
|
| ')' is preceded with whitespace. |
113
|
| '{' should be on the previous line. |
114
|
| '(' is followed by whitespace. |
115
|
| ')' is preceded with whitespace. |
115
|
| Missing a Javadoc comment. |
120
|
| '{' should be on the previous line. |
121
|
| 'synchronized' is not followed by whitespace. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '{' should be on the previous line. |
123
|
| Missing a Javadoc comment. |
131
|
| Missing a Javadoc comment. |
133
|
| '(' is followed by whitespace. |
133
|
| Parameter object should be final. |
133
|
| ')' is preceded with whitespace. |
133
|
| Method 'internalGrow' is not designed for extension - needs to be abstract, final or empty. |
135
|
| Missing a Javadoc comment. |
135
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| '{' should be on the previous line. |
137
|
| 'for' is not followed by whitespace. |
138
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| '{' should be on the previous line. |
139
|
| '{' should be on the previous line. |
141
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| '}' should be on the same line. |
143
|
| 'catch' is not followed by whitespace. |
144
|
| '(' is followed by whitespace. |
144
|
| ')' is preceded with whitespace. |
144
|
| '{' should be on the previous line. |
145
|
| 'if' is not followed by whitespace. |
146
|
| '(' is followed by whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| '{' should be on the previous line. |
147
|
| 'if' is not followed by whitespace. |
149
|
| '(' is followed by whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| '{' should be on the previous line. |
150
|
| Line is longer than 80 characters. |
151
|
| '(' is followed by whitespace. |
151
|
| Line is longer than 80 characters. |
152
|
| ')' is preceded with whitespace. |
152
|
| '}' should be on the same line. |
153
|
| '{' should be on the previous line. |
155
|
| '(' is followed by whitespace. |
156
|
| '+' should be on a new line. |
156
|
| ')' is preceded with whitespace. |
157
|
| Line has trailing spaces. |
160
|
| Method 'internalShrink' is not designed for extension - needs to be abstract, final or empty. |
166
|
| Missing a Javadoc comment. |
166
|
| '(' is followed by whitespace. |
166
|
| ')' is preceded with whitespace. |
166
|
| '{' should be on the previous line. |
168
|
| 'for' is not followed by whitespace. |
169
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| '{' should be on the previous line. |
170
|
| 'if' is not followed by whitespace. |
171
|
| '(' is followed by whitespace. |
171
|
| ')' is preceded with whitespace. |
171
|
| '{' should be on the previous line. |
172
|
| '{' should be on the previous line. |
174
|
| '(' is followed by whitespace. |
175
|
| 'cast' is not followed by whitespace. |
175
|
| ')' is preceded with whitespace. |
175
|
| '}' should be on the same line. |
176
|
| 'catch' is not followed by whitespace. |
177
|
| '(' is followed by whitespace. |
177
|
| ')' is preceded with whitespace. |
177
|
| '{' should be on the previous line. |
178
|
| 'if' is not followed by whitespace. |
179
|
| '(' is followed by whitespace. |
179
|
| ')' is preceded with whitespace. |
179
|
| '{' should be on the previous line. |
180
|
| Line is longer than 80 characters. |
181
|
| '(' is followed by whitespace. |
181
|
| '+' should be on a new line. |
181
|
| ')' is preceded with whitespace. |
182
|
org/apache/avalon/excalibur/pool/DefaultObjectFactory.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
32
|
| Missing a Javadoc comment. |
33
|
| Name 'm_constructor' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
| Variable 'm_constructor' must be private and have accessor methods. |
33
|
| Missing a Javadoc comment. |
34
|
| Name 'm_arguements' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
| Variable 'm_arguements' must be private and have accessor methods. |
34
|
| Line is longer than 80 characters. |
36
|
| Missing a Javadoc comment. |
36
|
| '(' is followed by whitespace. |
36
|
| ')' is preceded with whitespace. |
36
|
| Missing a Javadoc comment. |
42
|
| '(' is followed by whitespace. |
42
|
| ')' is preceded with whitespace. |
44
|
| '{' should be on the previous line. |
46
|
| '(' is followed by whitespace. |
47
|
| '(' is followed by whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
| Missing a Javadoc comment. |
50
|
| '(' is followed by whitespace. |
50
|
| ')' is preceded with whitespace. |
50
|
| '{' should be on the previous line. |
52
|
| '(' is followed by whitespace. |
53
|
| ')' is preceded with whitespace. |
53
|
| Method 'getCreatedClass' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Missing a Javadoc comment. |
56
|
| '{' should be on the previous line. |
57
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Missing a Javadoc comment. |
61
|
| '{' should be on the previous line. |
62
|
| '{' should be on the previous line. |
64
|
| 'cast' is not followed by whitespace. |
65
|
| '(' is followed by whitespace. |
65
|
| ')' is preceded with whitespace. |
65
|
| '}' should be on the same line. |
66
|
| 'catch' is not followed by whitespace. |
67
|
| '(' is followed by whitespace. |
67
|
| ')' is preceded with whitespace. |
67
|
| '{' should be on the previous line. |
68
|
| '(' is followed by whitespace. |
69
|
| '+' should be on a new line. |
69
|
| Line is longer than 80 characters. |
70
|
| ')' is preceded with whitespace. |
70
|
| Missing a Javadoc comment. |
74
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| '{' should be on the previous line. |
75
|
org/apache/avalon/excalibur/pool/DefaultPool.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
32
|
| Missing a Javadoc comment. |
33
|
| Name 'm_min' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
| Variable 'm_min' must be private and have accessor methods. |
33
|
| Missing a Javadoc comment. |
34
|
| Name 'm_max' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
| Variable 'm_max' must be private and have accessor methods. |
34
|
| Missing a Javadoc comment. |
35
|
| Name 'm_controller' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
35
|
| Variable 'm_controller' must be private and have accessor methods. |
35
|
| Missing a Javadoc comment. |
36
|
| Name 'm_disposed' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
36
|
| Variable 'm_disposed' must be private and have accessor methods. |
36
|
| Missing a Javadoc comment. |
37
|
| Name 'm_quickFail' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
37
|
| Variable 'm_quickFail' must be private and have accessor methods. |
37
|
| Missing a Javadoc comment. |
39
|
| '(' is followed by whitespace. |
39
|
| ')' is preceded with whitespace. |
40
|
| '{' should be on the previous line. |
42
|
| Line is longer than 80 characters. |
43
|
| '(' is followed by whitespace. |
43
|
| ')' is preceded with whitespace. |
43
|
| Missing a Javadoc comment. |
46
|
| '(' is followed by whitespace. |
46
|
| ')' is preceded with whitespace. |
49
|
| '{' should be on the previous line. |
51
|
| '(' is followed by whitespace. |
52
|
| ')' is preceded with whitespace. |
52
|
| Name 't_max' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
54
|
| Name 't_min' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
55
|
| 'if' is not followed by whitespace. |
57
|
| '(' is followed by whitespace. |
57
|
| ')' is preceded with whitespace. |
57
|
| '{' should be on the previous line. |
58
|
| 'if' is not followed by whitespace. |
59
|
| '(' is followed by whitespace. |
59
|
| ')' is preceded with whitespace. |
59
|
| '{' should be on the previous line. |
60
|
| '(' is followed by whitespace. |
61
|
| '+' should be on a new line. |
61
|
| ')' is preceded with whitespace. |
62
|
| 'if' is not followed by whitespace. |
68
|
| '(' is followed by whitespace. |
68
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| '{' should be on the previous line. |
69
|
| 'if' is not followed by whitespace. |
70
|
| '(' is followed by whitespace. |
70
|
| ')' is preceded with whitespace. |
70
|
| '{' should be on the previous line. |
71
|
| Line is longer than 80 characters. |
72
|
| '(' is followed by whitespace. |
72
|
| '+' should be on a new line. |
72
|
| Line is longer than 80 characters. |
73
|
| '+' should be on a new line. |
73
|
| ')' is preceded with whitespace. |
74
|
| '(' is followed by whitespace. |
76
|
| ')' is preceded with whitespace. |
76
|
| Avoid inline conditionals. |
76
|
| 'if' is not followed by whitespace. |
82
|
| '(' is followed by whitespace. |
82
|
| ')' is preceded with whitespace. |
82
|
| '{' should be on the previous line. |
83
|
| '}' should be on the same line. |
85
|
| '{' should be on the previous line. |
87
|
| '(' is followed by whitespace. |
88
|
| ')' is preceded with whitespace. |
88
|
| Missing a Javadoc comment. |
92
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
92
|
| '{' should be on the previous line. |
94
|
| Line is longer than 80 characters. |
95
|
| '(' is followed by whitespace. |
95
|
| ')' is preceded with whitespace. |
95
|
| Line is longer than 80 characters. |
98
|
| Missing a Javadoc comment. |
98
|
| '(' is followed by whitespace. |
98
|
| ')' is preceded with whitespace. |
98
|
| Redundant throws: 'NoSuchMethodException' is subclass of 'Exception'. |
99
|
| '{' should be on the previous line. |
100
|
| '(' is followed by whitespace. |
101
|
| '(' is followed by whitespace. |
101
|
| ')' is preceded with whitespace. |
101
|
| ')' is preceded with whitespace. |
101
|
| Missing a Javadoc comment. |
104
|
| '(' is followed by whitespace. |
104
|
| ')' is preceded with whitespace. |
104
|
| Redundant throws: 'NoSuchMethodException' is subclass of 'Exception'. |
105
|
| '{' should be on the previous line. |
106
|
| '(' is followed by whitespace. |
107
|
| ')' is preceded with whitespace. |
107
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Missing a Javadoc comment. |
110
|
| '{' should be on the previous line. |
111
|
| 'if' is not followed by whitespace. |
114
|
| '(' is followed by whitespace. |
114
|
| ')' is preceded with whitespace. |
114
|
| '{' should be on the previous line. |
115
|
| Line is longer than 80 characters. |
116
|
| '(' is followed by whitespace. |
116
|
| ')' is preceded with whitespace. |
116
|
| 'if' is not followed by whitespace. |
119
|
| '(' is followed by whitespace. |
119
|
| ')' is preceded with whitespace. |
119
|
| '{' should be on the previous line. |
120
|
| Line is longer than 80 characters. |
121
|
| '(' is followed by whitespace. |
121
|
| ')' is preceded with whitespace. |
121
|
| '{' should be on the previous line. |
127
|
| 'if' is not followed by whitespace. |
128
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| '{' should be on the previous line. |
129
|
| 'if' is not followed by whitespace. |
130
|
| '(' is followed by whitespace. |
130
|
| ')' is preceded with whitespace. |
130
|
| '{' should be on the previous line. |
131
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| 'if' is not followed by whitespace. |
134
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '{' should be on the previous line. |
135
|
| 'cast' is not followed by whitespace. |
136
|
| '}' should be on the same line. |
137
|
| '{' should be on the previous line. |
139
|
| '+' should be on a new line. |
141
|
| '(' is followed by whitespace. |
143
|
| ')' is preceded with whitespace. |
143
|
| '}' should be on the same line. |
145
|
| '{' should be on the previous line. |
147
|
| '}' should be on the same line. |
150
|
| '{' should be on the previous line. |
152
|
| 'cast' is not followed by whitespace. |
153
|
| '(' is followed by whitespace. |
156
|
| ')' is preceded with whitespace. |
156
|
| 'if' is not followed by whitespace. |
158
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
158
|
| '{' should be on the previous line. |
159
|
| '+' should be on a new line. |
160
|
| '(' is followed by whitespace. |
162
|
| ')' is preceded with whitespace. |
162
|
| '}' should be on the same line. |
165
|
| '{' should be on the previous line. |
167
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
172
|
| Missing a Javadoc comment. |
172
|
| '(' is followed by whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| '{' should be on the previous line. |
173
|
| 'if' is not followed by whitespace. |
174
|
| '(' is followed by whitespace. |
174
|
| ')' is preceded with whitespace. |
174
|
| '{' should be on the previous line. |
175
|
| '+' should be on a new line. |
176
|
| '(' is followed by whitespace. |
178
|
| ')' is preceded with whitespace. |
178
|
| '{' should be on the previous line. |
182
|
| 'if' is not followed by whitespace. |
183
|
| '(' is followed by whitespace. |
183
|
| ')' is preceded with whitespace. |
183
|
| '{' should be on the previous line. |
184
|
| '(' is followed by whitespace. |
185
|
| 'cast' is not followed by whitespace. |
185
|
| ')' is preceded with whitespace. |
185
|
| '{' should be on the previous line. |
190
|
| 'if' is not followed by whitespace. |
191
|
| '(' is followed by whitespace. |
191
|
| ')' is preceded with whitespace. |
191
|
| '{' should be on the previous line. |
192
|
| Line is longer than 80 characters. |
193
|
| ';' is preceded with whitespace. |
194
|
| '(' is followed by whitespace. |
195
|
| ')' is preceded with whitespace. |
195
|
| 'if' is not followed by whitespace. |
198
|
| '(' is followed by whitespace. |
198
|
| ')' is preceded with whitespace. |
198
|
| '{' should be on the previous line. |
199
|
| '+' should be on a new line. |
201
|
| '(' is followed by whitespace. |
203
|
| ')' is preceded with whitespace. |
203
|
| 'if' is not followed by whitespace. |
206
|
| '(' is followed by whitespace. |
206
|
| Expression can be simplified. |
206
|
| ')' is preceded with whitespace. |
206
|
| '{' should be on the previous line. |
207
|
| '(' is followed by whitespace. |
208
|
| ')' is preceded with whitespace. |
208
|
| Line is longer than 80 characters. |
210
|
| 'if' is not followed by whitespace. |
210
|
| '(' is followed by whitespace. |
210
|
| '(' is followed by whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| '(' is followed by whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| '(' is followed by whitespace. |
212
|
| ')' is preceded with whitespace. |
212
|
| '}' should be on the same line. |
214
|
| '{' should be on the previous line. |
216
|
| '(' is followed by whitespace. |
217
|
| ')' is preceded with whitespace. |
217
|
| '}' should be on the same line. |
219
|
| '{' should be on the previous line. |
221
|
| '}' should be on the same line. |
224
|
| 'catch' is not followed by whitespace. |
225
|
| '(' is followed by whitespace. |
225
|
| ')' is preceded with whitespace. |
225
|
| '{' should be on the previous line. |
226
|
| 'if' is not followed by whitespace. |
227
|
| '(' is followed by whitespace. |
227
|
| ')' is preceded with whitespace. |
227
|
| '{' should be on the previous line. |
228
|
| Line is longer than 80 characters. |
229
|
| '(' is followed by whitespace. |
229
|
| ')' is preceded with whitespace. |
229
|
| Missing a Javadoc comment. |
234
|
| '{' should be on the previous line. |
235
|
| '{' should be on the previous line. |
237
|
| '{' should be on the previous line. |
240
|
| 'while' is not followed by whitespace. |
241
|
| '(' is followed by whitespace. |
241
|
| ')' is preceded with whitespace. |
241
|
| '{' should be on the previous line. |
242
|
| '(' is followed by whitespace. |
243
|
| 'cast' is not followed by whitespace. |
243
|
| ')' is preceded with whitespace. |
243
|
| '}' should be on the same line. |
245
|
| '{' should be on the previous line. |
247
|
| '}' should be on the same line. |
250
|
| 'catch' is not followed by whitespace. |
251
|
| '(' is followed by whitespace. |
251
|
| ')' is preceded with whitespace. |
251
|
| '{' should be on the previous line. |
252
|
| 'if' is not followed by whitespace. |
253
|
| '(' is followed by whitespace. |
253
|
| ')' is preceded with whitespace. |
253
|
| '{' should be on the previous line. |
254
|
| '(' is followed by whitespace. |
255
|
| ')' is preceded with whitespace. |
255
|
org/apache/avalon/excalibur/pool/DefaultPoolController.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
29
|
| Missing a Javadoc comment. |
30
|
| Name 'm_amount' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
30
|
| Missing a Javadoc comment. |
32
|
| '{' should be on the previous line. |
33
|
| '(' is followed by whitespace. |
34
|
| ')' is preceded with whitespace. |
34
|
| Missing a Javadoc comment. |
37
|
| '(' is followed by whitespace. |
37
|
| ')' is preceded with whitespace. |
37
|
| '{' should be on the previous line. |
38
|
| '(' is followed by whitespace. |
39
|
| ')' is preceded with whitespace. |
39
|
| Avoid inline conditionals. |
39
|
| Method 'grow' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| '{' should be on the previous line. |
43
|
| Method 'shrink' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Missing a Javadoc comment. |
47
|
| '{' should be on the previous line. |
48
|
org/apache/avalon/excalibur/pool/HardResourceLimitingPool.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
32
|
| Line is longer than 80 characters. |
33
|
| Missing a Javadoc comment. |
33
|
| '(' is followed by whitespace. |
33
|
| ')' is preceded with whitespace. |
33
|
| '{' should be on the previous line. |
35
|
| '(' is followed by whitespace. |
36
|
| ')' is preceded with whitespace. |
36
|
| Line is longer than 80 characters. |
39
|
| Missing a Javadoc comment. |
39
|
| '(' is followed by whitespace. |
39
|
| Parameter max should be final. |
39
|
| ')' is preceded with whitespace. |
39
|
| '{' should be on the previous line. |
41
|
| '(' is followed by whitespace. |
42
|
| ')' is preceded with whitespace. |
42
|
| Line is longer than 80 characters. |
45
|
| Missing a Javadoc comment. |
45
|
| '(' is followed by whitespace. |
45
|
| Parameter initial should be final. |
45
|
| Parameter max should be final. |
45
|
| ')' is preceded with whitespace. |
45
|
| '{' should be on the previous line. |
47
|
| '(' is followed by whitespace. |
48
|
| ')' is preceded with whitespace. |
48
|
| Missing a Javadoc comment. |
51
|
| '(' is followed by whitespace. |
51
|
| ')' is preceded with whitespace. |
51
|
| '{' should be on the previous line. |
53
|
| '(' is followed by whitespace. |
54
|
| ')' is preceded with whitespace. |
54
|
| Missing a Javadoc comment. |
57
|
| '(' is followed by whitespace. |
57
|
| ')' is preceded with whitespace. |
59
|
| '{' should be on the previous line. |
61
|
| '(' is followed by whitespace. |
62
|
| ')' is preceded with whitespace. |
62
|
| Line is longer than 80 characters. |
65
|
| Missing a Javadoc comment. |
65
|
| '(' is followed by whitespace. |
65
|
| ')' is preceded with whitespace. |
65
|
| '{' should be on the previous line. |
67
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| Line is longer than 80 characters. |
71
|
| Missing a Javadoc comment. |
71
|
| '(' is followed by whitespace. |
71
|
| ')' is preceded with whitespace. |
71
|
| Redundant throws: 'NoSuchMethodException' is subclass of 'Exception'. |
72
|
| '{' should be on the previous line. |
73
|
| '(' is followed by whitespace. |
74
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| Missing a Javadoc comment. |
77
|
| '(' is followed by whitespace. |
77
|
| ')' is preceded with whitespace. |
77
|
| Redundant throws: 'NoSuchMethodException' is subclass of 'Exception'. |
78
|
| '{' should be on the previous line. |
79
|
| '(' is followed by whitespace. |
80
|
| ')' is preceded with whitespace. |
80
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Missing a Javadoc comment. |
83
|
| '{' should be on the previous line. |
84
|
| '{' should be on the previous line. |
86
|
| '}' should be on the same line. |
88
|
| 'catch' is not followed by whitespace. |
89
|
| '(' is followed by whitespace. |
89
|
| ')' is preceded with whitespace. |
89
|
| '{' should be on the previous line. |
90
|
| 'if' is not followed by whitespace. |
91
|
| '(' is followed by whitespace. |
91
|
| ')' is preceded with whitespace. |
91
|
| '{' should be on the previous line. |
92
|
| '(' is followed by whitespace. |
93
|
| ')' is preceded with whitespace. |
93
|
| Method 'newPoolable' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Missing a Javadoc comment. |
98
|
| '{' should be on the previous line. |
99
|
| 'if' is not followed by whitespace. |
100
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
100
|
| '{' should be on the previous line. |
101
|
| Line is longer than 80 characters. |
105
|
| '(' is followed by whitespace. |
105
|
| ')' is preceded with whitespace. |
105
|
| Method 'internalGrow' is not designed for extension - needs to be abstract, final or empty. |
108
|
| Missing a Javadoc comment. |
108
|
| '(' is followed by whitespace. |
108
|
| Parameter amount should be final. |
108
|
| ')' is preceded with whitespace. |
108
|
| '{' should be on the previous line. |
110
|
| Line is longer than 80 characters. |
111
|
| '(' is followed by whitespace. |
111
|
| '(' is followed by whitespace. |
111
|
| '(' is followed by whitespace. |
111
|
| ')' is preceded with whitespace. |
111
|
| ')' is preceded with whitespace. |
111
|
| Avoid inline conditionals. |
111
|
| ')' is preceded with whitespace. |
111
|
org/apache/avalon/excalibur/pool/ResourceLimitingPool.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
34
|
| '{' should be on the previous line. |
45
|
| First sentence should end with a period. |
49
|
| Name 'm_semaphore' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
52
|
| Variable 'm_semaphore' must be private and have accessor methods. |
52
|
| Name 'm_disposed' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
60
|
| Name 'm_factory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
65
|
| Name 'm_max' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
70
|
| Line is longer than 80 characters. |
73
|
| Name 'm_maxStrict' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
75
|
| Line is longer than 80 characters. |
78
|
| Line is longer than 80 characters. |
79
|
| Name 'm_blocking' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
81
|
| Line is longer than 80 characters. |
84
|
| Name 'm_blockTimeout' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
87
|
| Line is longer than 80 characters. |
90
|
| Name 'm_trimInterval' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
92
|
| Name 'm_lastTrim' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
97
|
| Name 'm_ready' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
102
|
| Line is longer than 80 characters. |
105
|
| Name 'm_readySize' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
107
|
| Line is longer than 80 characters. |
110
|
| Name 'm_oldReady' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
112
|
| Line is longer than 80 characters. |
115
|
| Name 'm_oldReadySize' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
117
|
| First sentence should end with a period. |
119
|
| Name 'm_size' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
122
|
| First sentence should end with a period. |
127
|
| Line is longer than 80 characters. |
130
|
| Line is longer than 80 characters. |
132
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
134
|
| Line is longer than 80 characters. |
136
|
| Line is longer than 80 characters. |
138
|
| Line is longer than 80 characters. |
139
|
| Line is longer than 80 characters. |
140
|
| Line is longer than 80 characters. |
141
|
| '(' is followed by whitespace. |
143
|
| Parameter max should be final. |
144
|
| Parameter maxStrict should be final. |
145
|
| Parameter blocking should be final. |
146
|
| Parameter blockTimeout should be final. |
147
|
| Parameter trimInterval should be final. |
148
|
| ')' is preceded with whitespace. |
148
|
| '{' should be on the previous line. |
149
|
| '(' is followed by whitespace. |
151
|
| Avoid inline conditionals. |
151
|
| ')' is preceded with whitespace. |
151
|
| 'if' is not followed by whitespace. |
159
|
| '(' is followed by whitespace. |
159
|
| ')' is preceded with whitespace. |
159
|
| '{' should be on the previous line. |
160
|
| Line is longer than 80 characters. |
169
|
| Line is longer than 80 characters. |
170
|
| Line is longer than 80 characters. |
173
|
| Line is longer than 80 characters. |
175
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
178
|
| Method length is 160 lines (max allowed is 150). |
178
|
| '{' should be on the previous line. |
179
|
| 'if' construct must use '{}'s. |
180
|
| 'if' is not followed by whitespace. |
180
|
| '(' is followed by whitespace. |
180
|
| ')' is preceded with whitespace. |
180
|
| '(' is followed by whitespace. |
180
|
| ')' is preceded with whitespace. |
180
|
| 'synchronized' is not followed by whitespace. |
183
|
| '(' is followed by whitespace. |
183
|
| ')' is preceded with whitespace. |
183
|
| '{' should be on the previous line. |
184
|
| 'if' is not followed by whitespace. |
186
|
| '(' is followed by whitespace. |
186
|
| '(' is followed by whitespace. |
186
|
| ')' is preceded with whitespace. |
186
|
| '&&' should be on a new line. |
186
|
| '(' is followed by whitespace. |
187
|
| ')' is preceded with whitespace. |
187
|
| ')' is preceded with whitespace. |
187
|
| 'if' is not followed by whitespace. |
193
|
| '(' is followed by whitespace. |
193
|
| ')' is preceded with whitespace. |
193
|
| '{' should be on the previous line. |
194
|
| 'cast' is not followed by whitespace. |
196
|
| '}' should be on the same line. |
198
|
| 'if' is not followed by whitespace. |
199
|
| '(' is followed by whitespace. |
199
|
| ')' is preceded with whitespace. |
199
|
| '{' should be on the previous line. |
200
|
| 'cast' is not followed by whitespace. |
202
|
| '}' should be on the same line. |
204
|
| '{' should be on the previous line. |
206
|
| 'if' is not followed by whitespace. |
208
|
| '(' is followed by whitespace. |
208
|
| '(' is followed by whitespace. |
208
|
| ')' is preceded with whitespace. |
208
|
| ')' is preceded with whitespace. |
208
|
| '{' should be on the previous line. |
209
|
| Line is longer than 80 characters. |
210
|
| Line is longer than 80 characters. |
213
|
| 'if' is not followed by whitespace. |
214
|
| '(' is followed by whitespace. |
214
|
| ')' is preceded with whitespace. |
214
|
| '{' should be on the previous line. |
215
|
| 'if' is not followed by whitespace. |
218
|
| '(' is followed by whitespace. |
218
|
| ')' is preceded with whitespace. |
218
|
| '{' should be on the previous line. |
219
|
| Line is longer than 80 characters. |
220
|
| '(' is followed by whitespace. |
220
|
| Line is longer than 80 characters. |
221
|
| ')' is preceded with whitespace. |
221
|
| 'if' is not followed by whitespace. |
224
|
| '(' is followed by whitespace. |
224
|
| ')' is preceded with whitespace. |
224
|
| '{' should be on the previous line. |
225
|
| Line is longer than 80 characters. |
226
|
| Line is longer than 80 characters. |
228
|
| '{' should be on the previous line. |
232
|
| 'if' is not followed by whitespace. |
233
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
| '{' should be on the previous line. |
234
|
| '{' should be on the previous line. |
236
|
| '(' is followed by whitespace. |
237
|
| ')' is preceded with whitespace. |
237
|
| '}' should be on the same line. |
238
|
| 'catch' is not followed by whitespace. |
239
|
| '(' is followed by whitespace. |
239
|
| ')' is preceded with whitespace. |
239
|
| '{' should be on the previous line. |
240
|
| Must have at least one statement. |
240
|
| Line is longer than 80 characters. |
243
|
| 'if' is not followed by whitespace. |
244
|
| '(' is followed by whitespace. |
244
|
| ')' is preceded with whitespace. |
244
|
| '{' should be on the previous line. |
245
|
| Line is longer than 80 characters. |
246
|
| '(' is followed by whitespace. |
246
|
| ')' is preceded with whitespace. |
246
|
| 'if' is not followed by whitespace. |
249
|
| '(' is followed by whitespace. |
249
|
| ')' is preceded with whitespace. |
249
|
| '{' should be on the previous line. |
250
|
| Line is longer than 80 characters. |
251
|
| Line is longer than 80 characters. |
253
|
| '(' is followed by whitespace. |
253
|
| ')' is preceded with whitespace. |
253
|
| '}' should be on the same line. |
255
|
| '{' should be on the previous line. |
257
|
| 'if' is not followed by whitespace. |
261
|
| '(' is followed by whitespace. |
261
|
| ')' is preceded with whitespace. |
261
|
| '{' should be on the previous line. |
262
|
| Line is longer than 80 characters. |
264
|
| Line is longer than 80 characters. |
265
|
| '(' is followed by whitespace. |
265
|
| ')' is preceded with whitespace. |
265
|
| Line is longer than 80 characters. |
266
|
| ')' is preceded with whitespace. |
266
|
| Line is longer than 80 characters. |
269
|
| '(' is followed by whitespace. |
269
|
| ')' is preceded with whitespace. |
270
|
| '(' is followed by whitespace. |
272
|
| ')' is preceded with whitespace. |
272
|
| '}' should be on the same line. |
273
|
| '{' should be on the previous line. |
275
|
| Line is longer than 80 characters. |
276
|
| Line is longer than 80 characters. |
277
|
| '{' should be on the previous line. |
280
|
| '{' should be on the previous line. |
282
|
| '}' should be on the same line. |
284
|
| 'catch' is not followed by whitespace. |
285
|
| '(' is followed by whitespace. |
285
|
| ')' is preceded with whitespace. |
285
|
| '{' should be on the previous line. |
286
|
| Must have at least one statement. |
286
|
| 'if' is not followed by whitespace. |
290
|
| '(' is followed by whitespace. |
290
|
| ')' is preceded with whitespace. |
290
|
| '{' should be on the previous line. |
291
|
| Line is longer than 80 characters. |
292
|
| '(' is followed by whitespace. |
292
|
| ')' is preceded with whitespace. |
292
|
| '(' is followed by whitespace. |
294
|
| ')' is preceded with whitespace. |
294
|
| 'cast' is not followed by whitespace. |
298
|
| 'if' is not followed by whitespace. |
301
|
| '(' is followed by whitespace. |
301
|
| ')' is preceded with whitespace. |
301
|
| '{' should be on the previous line. |
302
|
| Line is longer than 80 characters. |
304
|
| '(' is followed by whitespace. |
304
|
| '(' is followed by whitespace. |
304
|
| ')' is preceded with whitespace. |
304
|
| Line is longer than 80 characters. |
305
|
| Line is longer than 80 characters. |
306
|
| ')' is preceded with whitespace. |
306
|
| '}' should be on the same line. |
308
|
| '{' should be on the previous line. |
310
|
| Line is longer than 80 characters. |
313
|
| '(' is followed by whitespace. |
313
|
| ')' is preceded with whitespace. |
313
|
| '}' should be on the same line. |
315
|
| '{' should be on the previous line. |
317
|
| Line is longer than 80 characters. |
318
|
| 'if' is not followed by whitespace. |
323
|
| '(' is followed by whitespace. |
323
|
| ')' is preceded with whitespace. |
323
|
| '{' should be on the previous line. |
324
|
| Line is longer than 80 characters. |
325
|
| '(' is followed by whitespace. |
325
|
| ')' is preceded with whitespace. |
326
|
| 'if' is not followed by whitespace. |
332
|
| '(' is followed by whitespace. |
332
|
| ')' is preceded with whitespace. |
332
|
| '{' should be on the previous line. |
333
|
| Line is longer than 80 characters. |
334
|
| '(' is followed by whitespace. |
334
|
| ')' is preceded with whitespace. |
334
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
345
|
| '(' is followed by whitespace. |
345
|
| Parameter poolable should be final. |
345
|
| ')' is preceded with whitespace. |
345
|
| '{' should be on the previous line. |
346
|
| 'if' is not followed by whitespace. |
348
|
| '(' is followed by whitespace. |
348
|
| ')' is preceded with whitespace. |
348
|
| '{' should be on the previous line. |
349
|
| '(' is followed by whitespace. |
350
|
| 'cast' is not followed by whitespace. |
350
|
| ')' is preceded with whitespace. |
350
|
| 'synchronized' is not followed by whitespace. |
353
|
| '(' is followed by whitespace. |
353
|
| ')' is preceded with whitespace. |
353
|
| '{' should be on the previous line. |
354
|
| 'if' is not followed by whitespace. |
355
|
| '(' is followed by whitespace. |
355
|
| ')' is preceded with whitespace. |
355
|
| '{' should be on the previous line. |
356
|
| 'if' is not followed by whitespace. |
357
|
| '(' is followed by whitespace. |
357
|
| ')' is preceded with whitespace. |
357
|
| '{' should be on the previous line. |
358
|
| 'if' is not followed by whitespace. |
360
|
| '(' is followed by whitespace. |
360
|
| ')' is preceded with whitespace. |
360
|
| '{' should be on the previous line. |
361
|
| Line is longer than 80 characters. |
362
|
| '(' is followed by whitespace. |
362
|
| ')' is preceded with whitespace. |
363
|
| '(' is followed by whitespace. |
366
|
| ')' is preceded with whitespace. |
366
|
| '}' should be on the same line. |
367
|
| '{' should be on the previous line. |
369
|
| 'if' is not followed by whitespace. |
371
|
| '(' is followed by whitespace. |
371
|
| ')' is preceded with whitespace. |
371
|
| '{' should be on the previous line. |
372
|
| Line is longer than 80 characters. |
373
|
| '(' is followed by whitespace. |
373
|
| ')' is preceded with whitespace. |
374
|
| '(' is followed by whitespace. |
377
|
| ')' is preceded with whitespace. |
377
|
| Line is longer than 80 characters. |
380
|
| 'if' is not followed by whitespace. |
381
|
| '(' is followed by whitespace. |
381
|
| ')' is preceded with whitespace. |
381
|
| '{' should be on the previous line. |
382
|
| '}' should be on the same line. |
386
|
| '{' should be on the previous line. |
388
|
| Line is longer than 80 characters. |
389
|
| 'if' is not followed by whitespace. |
390
|
| '(' is followed by whitespace. |
390
|
| ')' is preceded with whitespace. |
390
|
| '{' should be on the previous line. |
391
|
| Line is longer than 80 characters. |
392
|
| '(' is followed by whitespace. |
392
|
| ')' is preceded with whitespace. |
393
|
| '(' is followed by whitespace. |
396
|
| ')' is preceded with whitespace. |
396
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
410
|
| '{' should be on the previous line. |
411
|
| 'synchronized' is not followed by whitespace. |
415
|
| '(' is followed by whitespace. |
415
|
| ')' is preceded with whitespace. |
415
|
| '{' should be on the previous line. |
416
|
| 'for' is not followed by whitespace. |
418
|
| '(' is followed by whitespace. |
418
|
| ';' is followed by whitespace. |
418
|
| '{' should be on the previous line. |
419
|
| 'cast' is not followed by whitespace. |
420
|
| '(' is followed by whitespace. |
423
|
| ')' is preceded with whitespace. |
423
|
| 'if' is not followed by whitespace. |
427
|
| '(' is followed by whitespace. |
427
|
| ')' is preceded with whitespace. |
427
|
| '{' should be on the previous line. |
428
|
| 'for' is not followed by whitespace. |
429
|
| '(' is followed by whitespace. |
429
|
| ';' is followed by whitespace. |
429
|
| '{' should be on the previous line. |
430
|
| 'cast' is not followed by whitespace. |
431
|
| '(' is followed by whitespace. |
434
|
| ')' is preceded with whitespace. |
434
|
| Line is longer than 80 characters. |
438
|
| 'if' is not followed by whitespace. |
439
|
| '(' is followed by whitespace. |
439
|
| ')' is preceded with whitespace. |
439
|
| '{' should be on the previous line. |
440
|
| 'if' is not followed by whitespace. |
444
|
| '(' is followed by whitespace. |
444
|
| '(' is followed by whitespace. |
444
|
| ')' is preceded with whitespace. |
444
|
| ')' is preceded with whitespace. |
444
|
| '{' should be on the previous line. |
445
|
| '(' is followed by whitespace. |
446
|
| Line is longer than 80 characters. |
447
|
| ')' is preceded with whitespace. |
447
|
| Method 'permanentlyRemovePoolable' is not designed for extension - needs to be abstract, final or empty. |
461
|
| '(' is followed by whitespace. |
461
|
| Parameter poolable should be final. |
461
|
| Expected @param tag for 'poolable'. |
461
|
| ')' is preceded with whitespace. |
461
|
| '{' should be on the previous line. |
462
|
| '(' is followed by whitespace. |
464
|
| ')' is preceded with whitespace. |
464
|
| Line is longer than 80 characters. |
468
|
| Expected an @return tag. |
470
|
| Method 'getSize' is not designed for extension - needs to be abstract, final or empty. |
470
|
| '{' should be on the previous line. |
471
|
| Expected an @return tag. |
478
|
| Method 'getReadySize' is not designed for extension - needs to be abstract, final or empty. |
478
|
| '{' should be on the previous line. |
479
|
| 'synchronized' is not followed by whitespace. |
480
|
| '(' is followed by whitespace. |
480
|
| ')' is preceded with whitespace. |
480
|
| '{' should be on the previous line. |
481
|
| Expected an @return tag. |
495
|
| Method 'newPoolable' is not designed for extension - needs to be abstract, final or empty. |
495
|
| Expected @throws tag for 'Exception'. |
495
|
| '{' should be on the previous line. |
496
|
| 'cast' is not followed by whitespace. |
501
|
| Method 'removePoolable' is not designed for extension - needs to be abstract, final or empty. |
513
|
| '(' is followed by whitespace. |
513
|
| Parameter poolable should be final. |
513
|
| ')' is preceded with whitespace. |
513
|
| '{' should be on the previous line. |
514
|
| '{' should be on the previous line. |
516
|
| '(' is followed by whitespace. |
517
|
| ')' is preceded with whitespace. |
517
|
| '}' should be on the same line. |
518
|
| 'catch' is not followed by whitespace. |
519
|
| '(' is followed by whitespace. |
519
|
| ')' is preceded with whitespace. |
519
|
| '{' should be on the previous line. |
520
|
| 'if' is not followed by whitespace. |
521
|
| '(' is followed by whitespace. |
521
|
| ')' is preceded with whitespace. |
521
|
| '{' should be on the previous line. |
522
|
| '(' is followed by whitespace. |
523
|
| ')' is preceded with whitespace. |
523
|
| Line is longer than 80 characters. |
529
|
| Line is longer than 80 characters. |
530
|
| Line is longer than 80 characters. |
535
|
| Line is longer than 80 characters. |
536
|
| Line is longer than 80 characters. |
537
|
| Line is longer than 80 characters. |
540
|
| Line is longer than 80 characters. |
541
|
| Line is longer than 80 characters. |
542
|
| Line is longer than 80 characters. |
543
|
| Line is longer than 80 characters. |
544
|
| Line is longer than 80 characters. |
547
|
| Line is longer than 80 characters. |
550
|
| Line is longer than 80 characters. |
551
|
| Method 'trim' is not designed for extension - needs to be abstract, final or empty. |
556
|
| '{' should be on the previous line. |
557
|
| 'if' is not followed by whitespace. |
558
|
| '(' is followed by whitespace. |
558
|
| ')' is preceded with whitespace. |
558
|
| '{' should be on the previous line. |
559
|
| 'synchronized' is not followed by whitespace. |
560
|
| '(' is followed by whitespace. |
560
|
| ')' is preceded with whitespace. |
560
|
| '{' should be on the previous line. |
561
|
| '}' should be on the same line. |
564
|
| '{' should be on the previous line. |
566
|
| Line is longer than 80 characters. |
567
|
| '(' is followed by whitespace. |
567
|
| ')' is preceded with whitespace. |
567
|
| Expected an @return tag. |
576
|
| '{' should be on the previous line. |
577
|
| 'if' is not followed by whitespace. |
581
|
| '(' is followed by whitespace. |
581
|
| ')' is preceded with whitespace. |
581
|
| '{' should be on the previous line. |
582
|
| 'if' is not followed by whitespace. |
583
|
| '(' is followed by whitespace. |
583
|
| ')' is preceded with whitespace. |
583
|
| '{' should be on the previous line. |
584
|
| Line is longer than 80 characters. |
585
|
| '(' is followed by whitespace. |
585
|
| ')' is preceded with whitespace. |
585
|
| 'for' is not followed by whitespace. |
590
|
| '(' is followed by whitespace. |
590
|
| ';' is followed by whitespace. |
590
|
| '{' should be on the previous line. |
591
|
| 'cast' is not followed by whitespace. |
592
|
| '(' is followed by whitespace. |
595
|
| ')' is preceded with whitespace. |
595
|
| 'if' is not followed by whitespace. |
600
|
| '(' is followed by whitespace. |
600
|
| ')' is preceded with whitespace. |
600
|
| '{' should be on the previous line. |
601
|
| Line is longer than 80 characters. |
602
|
| '(' is followed by whitespace. |
602
|
| ')' is preceded with whitespace. |
602
|
org/apache/avalon/excalibur/pool/SingleThreadedPool.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
34
|
| Missing a Javadoc comment. |
35
|
| Name 'm_initialized' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
35
|
| Variable 'm_initialized' must be private and have accessor methods. |
35
|
| Missing a Javadoc comment. |
36
|
| Name 'm_count' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
36
|
| Variable 'm_count' must be private and have accessor methods. |
36
|
| Missing a Javadoc comment. |
37
|
| Name 'm_pool' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
37
|
| Variable 'm_pool' must be private and have accessor methods. |
37
|
| Missing a Javadoc comment. |
38
|
| Name 'm_factory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
38
|
| Variable 'm_factory' must be private and have accessor methods. |
38
|
| Missing a Javadoc comment. |
39
|
| Name 'm_controller' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
39
|
| Variable 'm_controller' must be private and have accessor methods. |
39
|
| Missing a Javadoc comment. |
40
|
| Name 'm_maximum' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
40
|
| Variable 'm_maximum' must be private and have accessor methods. |
40
|
| Missing a Javadoc comment. |
41
|
| Name 'm_initial' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
41
|
| Variable 'm_initial' must be private and have accessor methods. |
41
|
| Missing a Javadoc comment. |
43
|
| '(' is followed by whitespace. |
43
|
| ')' is preceded with whitespace. |
45
|
| '{' should be on the previous line. |
46
|
| '(' is followed by whitespace. |
47
|
| '(' is followed by whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
| Missing a Javadoc comment. |
50
|
| '(' is followed by whitespace. |
50
|
| ')' is preceded with whitespace. |
52
|
| '{' should be on the previous line. |
53
|
| '(' is followed by whitespace. |
54
|
| ')' is preceded with whitespace. |
54
|
| Missing a Javadoc comment. |
57
|
| '(' is followed by whitespace. |
57
|
| ')' is preceded with whitespace. |
60
|
| '{' should be on the previous line. |
61
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Missing a Javadoc comment. |
69
|
| '{' should be on the previous line. |
71
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| '(' is followed by whitespace. |
75
|
| ')' is preceded with whitespace. |
75
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Expected @throws tag for 'Exception'. |
83
|
| '{' should be on the previous line. |
84
|
| Line is longer than 80 characters. |
85
|
| 'if' is not followed by whitespace. |
86
|
| '(' is followed by whitespace. |
86
|
| ')' is preceded with whitespace. |
86
|
| '{' should be on the previous line. |
87
|
| 'if' is not followed by whitespace. |
91
|
| '(' is followed by whitespace. |
91
|
| ')' is preceded with whitespace. |
91
|
| '{' should be on the previous line. |
92
|
| 'if' is not followed by whitespace. |
94
|
| '(' is followed by whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| '{' should be on the previous line. |
95
|
| '(' is followed by whitespace. |
96
|
| ')' is preceded with whitespace. |
96
|
| 'if' is not followed by whitespace. |
100
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
100
|
| '{' should be on the previous line. |
101
|
| 'cast' is not followed by whitespace. |
103
|
| '}' should be on the same line. |
104
|
| 'if' is not followed by whitespace. |
105
|
| '(' is followed by whitespace. |
105
|
| ')' is preceded with whitespace. |
105
|
| '{' should be on the previous line. |
106
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '{' should be on the previous line. |
123
|
| 'if' is not followed by whitespace. |
124
|
| '(' is followed by whitespace. |
124
|
| ')' is preceded with whitespace. |
124
|
| '{' should be on the previous line. |
125
|
| '(' is followed by whitespace. |
126
|
| 'cast' is not followed by whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| 'if' is not followed by whitespace. |
129
|
| '(' is followed by whitespace. |
129
|
| '(' is followed by whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| '{' should be on the previous line. |
130
|
| 'if' is not followed by whitespace. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| '{' should be on the previous line. |
133
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| 'if' is not followed by whitespace. |
138
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| '{' should be on the previous line. |
139
|
| '}' should be on the same line. |
142
|
| '{' should be on the previous line. |
144
|
| '{' should be on the previous line. |
146
|
| '(' is followed by whitespace. |
147
|
| ')' is preceded with whitespace. |
147
|
| '}' should be on the same line. |
148
|
| 'catch' is not followed by whitespace. |
149
|
| '(' is followed by whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| '{' should be on the previous line. |
150
|
| Line is longer than 80 characters. |
151
|
| Line is longer than 80 characters. |
152
|
| 'if' is not followed by whitespace. |
152
|
| '(' is followed by whitespace. |
152
|
| '(' is followed by whitespace. |
152
|
| ')' is preceded with whitespace. |
152
|
| '(' is followed by whitespace. |
152
|
| ')' is preceded with whitespace. |
152
|
| ')' is preceded with whitespace. |
152
|
| '(' is followed by whitespace. |
154
|
| ')' is preceded with whitespace. |
154
|
| First sentence should end with a period. |
160
|
| '{' should be on the previous line. |
166
|
| First sentence should end with a period. |
170
|
| '{' should be on the previous line. |
176
|
| '(' is followed by whitespace. |
183
|
| Expected @param tag for 'fillSize'. |
183
|
| ')' is preceded with whitespace. |
183
|
| Expected @throws tag for 'Exception'. |
183
|
| '{' should be on the previous line. |
184
|
| '(' is followed by whitespace. |
185
|
| ')' is preceded with whitespace. |
185
|
| 'for' is not followed by whitespace. |
187
|
| '(' is followed by whitespace. |
187
|
| ')' is preceded with whitespace. |
187
|
| '{' should be on the previous line. |
188
|
| 'cast' is not followed by whitespace. |
189
|
| '(' is followed by whitespace. |
198
|
| Expected @param tag for 'increase'. |
198
|
| ')' is preceded with whitespace. |
198
|
| '{' should be on the previous line. |
199
|
| 'if' is not followed by whitespace. |
200
|
| '(' is followed by whitespace. |
200
|
| ')' is preceded with whitespace. |
200
|
| '{' should be on the previous line. |
201
|
| '(' is followed by whitespace. |
207
|
| ')' is preceded with whitespace. |
207
|
| '(' is followed by whitespace. |
214
|
| Expected @param tag for 'decrease'. |
214
|
| ')' is preceded with whitespace. |
214
|
| '{' should be on the previous line. |
215
|
| '(' is followed by whitespace. |
217
|
| ')' is preceded with whitespace. |
217
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
224
|
| '{' should be on the previous line. |
225
|
| 'while' is not followed by whitespace. |
226
|
| '(' is followed by whitespace. |
226
|
| ')' is preceded with whitespace. |
226
|
| '{' should be on the previous line. |
227
|
| '{' should be on the previous line. |
230
|
| '(' is followed by whitespace. |
231
|
| ')' is preceded with whitespace. |
231
|
| '}' should be on the same line. |
232
|
| 'catch' is not followed by whitespace. |
233
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
| '{' should be on the previous line. |
234
|
| Line is longer than 80 characters. |
235
|
| Line is longer than 80 characters. |
236
|
| 'if' is not followed by whitespace. |
236
|
| '(' is followed by whitespace. |
236
|
| '(' is followed by whitespace. |
236
|
| ')' is preceded with whitespace. |
236
|
| '(' is followed by whitespace. |
236
|
| ')' is preceded with whitespace. |
236
|
| ')' is preceded with whitespace. |
236
|
| '(' is followed by whitespace. |
238
|
| ')' is preceded with whitespace. |
238
|
org/apache/avalon/excalibur/pool/SoftResourceLimitingPool.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
29
|
| '(' is followed by whitespace. |
33
|
| Expected @param tag for 'factory'. |
33
|
| ')' is preceded with whitespace. |
33
|
| Expected @throws tag for 'Exception'. |
34
|
| '{' should be on the previous line. |
35
|
| '(' is followed by whitespace. |
36
|
| ')' is preceded with whitespace. |
36
|
| '(' is followed by whitespace. |
43
|
| Expected @param tag for 'factory'. |
43
|
| Expected @param tag for 'min'. |
44
|
| ')' is preceded with whitespace. |
44
|
| Expected @throws tag for 'Exception'. |
45
|
| '{' should be on the previous line. |
46
|
| '(' is followed by whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
| '(' is followed by whitespace. |
54
|
| Expected @param tag for 'factory'. |
54
|
| Expected @param tag for 'min'. |
55
|
| Expected @param tag for 'max'. |
56
|
| ')' is preceded with whitespace. |
56
|
| Expected @throws tag for 'Exception'. |
56
|
| '{' should be on the previous line. |
57
|
| '(' is followed by whitespace. |
58
|
| ')' is preceded with whitespace. |
58
|
| '(' is followed by whitespace. |
65
|
| Expected @param tag for 'factory'. |
65
|
| Expected @param tag for 'controller'. |
66
|
| Expected @param tag for 'min'. |
67
|
| Expected @param tag for 'max'. |
68
|
| ')' is preceded with whitespace. |
68
|
| Expected @throws tag for 'Exception'. |
69
|
| '{' should be on the previous line. |
70
|
| '(' is followed by whitespace. |
71
|
| ')' is preceded with whitespace. |
71
|
| Line is longer than 80 characters. |
74
|
| Missing a Javadoc comment. |
74
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| Redundant throws: 'NoSuchMethodException' is subclass of 'Exception'. |
75
|
| '{' should be on the previous line. |
76
|
| '(' is followed by whitespace. |
77
|
| '(' is followed by whitespace. |
77
|
| ')' is preceded with whitespace. |
77
|
| ')' is preceded with whitespace. |
77
|
| Missing a Javadoc comment. |
80
|
| '(' is followed by whitespace. |
80
|
| ')' is preceded with whitespace. |
80
|
| Redundant throws: 'NoSuchMethodException' is subclass of 'Exception'. |
81
|
| '{' should be on the previous line. |
82
|
| '(' is followed by whitespace. |
83
|
| ')' is preceded with whitespace. |
83
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Missing a Javadoc comment. |
86
|
| '{' should be on the previous line. |
88
|
| '(' is followed by whitespace. |
89
|
| ')' is preceded with whitespace. |
89
|
| Method 'grow' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Missing a Javadoc comment. |
94
|
| '(' is followed by whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| '{' should be on the previous line. |
95
|
| '{' should be on the previous line. |
97
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
100
|
| '}' should be on the same line. |
101
|
| 'catch' is not followed by whitespace. |
102
|
| '(' is followed by whitespace. |
102
|
| ')' is preceded with whitespace. |
102
|
| '{' should be on the previous line. |
103
|
| 'if' is not followed by whitespace. |
104
|
| '(' is followed by whitespace. |
104
|
| ')' is preceded with whitespace. |
104
|
| '{' should be on the previous line. |
105
|
| '(' is followed by whitespace. |
106
|
| ')' is preceded with whitespace. |
106
|
| '}' should be on the same line. |
108
|
| 'catch' is not followed by whitespace. |
109
|
| '(' is followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| '{' should be on the previous line. |
110
|
| 'if' is not followed by whitespace. |
111
|
| '(' is followed by whitespace. |
111
|
| ')' is preceded with whitespace. |
111
|
| '{' should be on the previous line. |
112
|
| Line is longer than 80 characters. |
113
|
| '(' is followed by whitespace. |
113
|
| ')' is preceded with whitespace. |
113
|
| '}' should be on the same line. |
115
|
| '{' should be on the previous line. |
117
|
| Method 'shrink' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Missing a Javadoc comment. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '{' should be on the previous line. |
123
|
| '{' should be on the previous line. |
125
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| '}' should be on the same line. |
129
|
| 'catch' is not followed by whitespace. |
130
|
| '(' is followed by whitespace. |
130
|
| ')' is preceded with whitespace. |
130
|
| '{' should be on the previous line. |
131
|
| 'if' is not followed by whitespace. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| '{' should be on the previous line. |
133
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '}' should be on the same line. |
136
|
| 'catch' is not followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| '{' should be on the previous line. |
138
|
| 'if' is not followed by whitespace. |
139
|
| '(' is followed by whitespace. |
139
|
| ')' is preceded with whitespace. |
139
|
| '{' should be on the previous line. |
140
|
| Line is longer than 80 characters. |
141
|
| '(' is followed by whitespace. |
141
|
| ')' is preceded with whitespace. |
141
|
| '}' should be on the same line. |
143
|
| '{' should be on the previous line. |
145
|