Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
61 | 0 | 0 | 2908 |
Files
org/apache/avalon/excalibur/datasource/AbstractJdbcConnection.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| '{' should be on the previous line. |
57
|
| Missing a Javadoc comment. |
58
|
| Name 'm_connection' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
58
|
| Variable 'm_connection' must be private and have accessor methods. |
58
|
| Missing a Javadoc comment. |
60
|
| Name 'm_proxy' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
60
|
| Missing a Javadoc comment. |
61
|
| Name 'm_pool' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
61
|
| Variable 'm_pool' must be private and have accessor methods. |
61
|
| Line has trailing spaces. |
62
|
| Line is longer than 80 characters. |
63
|
| Name 'm_encounteredError' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
65
|
| Variable 'm_encounteredError' must be private and have accessor methods. |
65
|
| Line is longer than 80 characters. |
67
|
| Name 'm_testAge' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
68
|
| Variable 'm_testAge' must be private and have accessor methods. |
68
|
| Missing a Javadoc comment. |
69
|
| Name 'm_testStatement' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
69
|
| Variable 'm_testStatement' must be private and have accessor methods. |
69
|
| Missing a Javadoc comment. |
70
|
| Name 'm_testException' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
70
|
| Variable 'm_testException' must be private and have accessor methods. |
70
|
| Missing a Javadoc comment. |
71
|
| Name 'm_lastUsed' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
71
|
| Variable 'm_lastUsed' must be private and have accessor methods. |
71
|
| Missing a Javadoc comment. |
72
|
| Name 'm_methods' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
72
|
| 'for' is not followed by whitespace. |
79
|
| '(' is followed by whitespace. |
79
|
| ')' is preceded with whitespace. |
79
|
| '{' should be on the previous line. |
80
|
| '(' is followed by whitespace. |
81
|
| ')' is preceded with whitespace. |
81
|
| 'private' modifier out of order with the JLS suggestions. |
95
|
| Name 'm_allocatedStatements' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
95
|
| Line is longer than 80 characters. |
100
|
| '(' is followed by whitespace. |
100
|
| Expected @param tag for 'connection'. |
100
|
| Expected @param tag for 'oradb'. |
100
|
| ')' is preceded with whitespace. |
100
|
| '(' is followed by whitespace. |
102
|
| '(' is followed by whitespace. |
102
|
| ')' is preceded with whitespace. |
102
|
| Avoid inline conditionals. |
102
|
| ')' is preceded with whitespace. |
102
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
108
|
| Line is longer than 80 characters. |
111
|
| '(' is followed by whitespace. |
111
|
| ')' is preceded with whitespace. |
111
|
| '(' is followed by whitespace. |
113
|
| '5000' is a magic number. |
113
|
| ')' is preceded with whitespace. |
113
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
119
|
| Line is longer than 80 characters. |
121
|
| Line is longer than 80 characters. |
122
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
127
|
| '{' should be on the previous line. |
128
|
| 'if' is not followed by whitespace. |
135
|
| '(' is followed by whitespace. |
135
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| '{' should be on the previous line. |
136
|
| '}' should be on the same line. |
139
|
| '{' should be on the previous line. |
141
|
| '{' should be on the previous line. |
143
|
| '(' is followed by whitespace. |
147
|
| ')' is preceded with whitespace. |
147
|
| '}' should be on the same line. |
148
|
| 'catch' is not followed by whitespace. |
149
|
| '(' is followed by whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| '{' should be on the previous line. |
150
|
| Missing a Javadoc comment. |
157
|
| '{' should be on the previous line. |
158
|
| Method 'enableLogging' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Missing a Javadoc comment. |
161
|
| '(' is followed by whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| '{' should be on the previous line. |
162
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| 'if' is not followed by whitespace. |
165
|
| '(' is followed by whitespace. |
165
|
| ')' is preceded with whitespace. |
165
|
| '{' should be on the previous line. |
166
|
| 'if' is not followed by whitespace. |
167
|
| '(' is followed by whitespace. |
167
|
| ')' is preceded with whitespace. |
167
|
| '{' should be on the previous line. |
168
|
| Line is longer than 80 characters. |
169
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| Method 'setPool' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Missing a Javadoc comment. |
175
|
| '(' is followed by whitespace. |
175
|
| Parameter pool should be final. |
175
|
| ')' is preceded with whitespace. |
175
|
| '{' should be on the previous line. |
176
|
| Method 'recycle' is not designed for extension - needs to be abstract, final or empty. |
180
|
| Missing a Javadoc comment. |
180
|
| '{' should be on the previous line. |
181
|
| '{' should be on the previous line. |
184
|
| '}' should be on the same line. |
187
|
| 'catch' is not followed by whitespace. |
188
|
| '(' is followed by whitespace. |
188
|
| ')' is preceded with whitespace. |
188
|
| '{' should be on the previous line. |
189
|
| Must have at least one statement. |
189
|
| Method 'setProxiedConnection' is not designed for extension - needs to be abstract, final or empty. |
194
|
| Missing a Javadoc comment. |
194
|
| '(' is followed by whitespace. |
194
|
| Parameter proxy should be final. |
194
|
| ')' is preceded with whitespace. |
194
|
| '{' should be on the previous line. |
195
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
199
|
| Missing a Javadoc comment. |
199
|
| '{' should be on the previous line. |
200
|
| Method 'isClosed' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Missing a Javadoc comment. |
204
|
| '{' should be on the previous line. |
206
|
| 'if' is not followed by whitespace. |
207
|
| '(' is followed by whitespace. |
207
|
| ')' is preceded with whitespace. |
207
|
| '{' should be on the previous line. |
208
|
| '(' is followed by whitespace. |
212
|
| ')' is preceded with whitespace. |
212
|
| '{' should be on the previous line. |
213
|
| Line is longer than 80 characters. |
214
|
| '(' is followed by whitespace. |
216
|
| ')' is preceded with whitespace. |
216
|
| '{' should be on the previous line. |
217
|
| Line is longer than 80 characters. |
218
|
| '}' should be on the same line. |
222
|
| '{' should be on the previous line. |
224
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
| '{' should be on the previous line. |
229
|
| 'if' is not followed by whitespace. |
230
|
| '(' is followed by whitespace. |
230
|
| ')' is preceded with whitespace. |
230
|
| '{' should be on the previous line. |
231
|
| Line is longer than 80 characters. |
232
|
| '(' is followed by whitespace. |
232
|
| ')' is preceded with whitespace. |
232
|
| '}' should be on the same line. |
235
|
| '(' is followed by whitespace. |
236
|
| ')' is preceded with whitespace. |
236
|
| '{' should be on the previous line. |
237
|
| Line is longer than 80 characters. |
238
|
| Line is longer than 80 characters. |
240
|
| Line is longer than 80 characters. |
241
|
| Line is longer than 80 characters. |
242
|
| Line is longer than 80 characters. |
243
|
| Line is longer than 80 characters. |
244
|
| Line is longer than 80 characters. |
247
|
| Line is longer than 80 characters. |
248
|
| Line is longer than 80 characters. |
249
|
| Line is longer than 80 characters. |
250
|
| Line is longer than 80 characters. |
251
|
| Line is longer than 80 characters. |
252
|
| '(' is followed by whitespace. |
252
|
| ')' is preceded with whitespace. |
252
|
| Line has trailing spaces. |
255
|
| Line is longer than 80 characters. |
256
|
| Line has trailing spaces. |
258
|
| 'if' is not followed by whitespace. |
259
|
| '(' is followed by whitespace. |
259
|
| ')' is preceded with whitespace. |
259
|
| '{' should be on the previous line. |
260
|
| '{' should be on the previous line. |
262
|
| '}' should be on the same line. |
265
|
| 'catch' is not followed by whitespace. |
266
|
| '(' is followed by whitespace. |
266
|
| ')' is preceded with whitespace. |
266
|
| '{' should be on the previous line. |
267
|
| '(' is followed by whitespace. |
268
|
| ')' is preceded with whitespace. |
268
|
| Method 'close' is not designed for extension - needs to be abstract, final or empty. |
278
|
| Missing a Javadoc comment. |
278
|
| '{' should be on the previous line. |
280
|
| '{' should be on the previous line. |
286
|
| '{' should be on the previous line. |
292
|
| '}' should be on the same line. |
295
|
| 'catch' is not followed by whitespace. |
296
|
| '(' is followed by whitespace. |
296
|
| ')' is preceded with whitespace. |
296
|
| '{' should be on the previous line. |
297
|
| Must have at least one statement. |
297
|
| '}' should be on the same line. |
300
|
| '{' should be on the previous line. |
302
|
| '(' is followed by whitespace. |
304
|
| 'cast' is not followed by whitespace. |
304
|
| ')' is preceded with whitespace. |
304
|
| Method 'clearAllocatedStatements' is not designed for extension - needs to be abstract, final or empty. |
321
|
| '{' should be on the previous line. |
322
|
| 'synchronized' is not followed by whitespace. |
323
|
| '(' is followed by whitespace. |
323
|
| ')' is preceded with whitespace. |
323
|
| '{' should be on the previous line. |
324
|
| '{' should be on the previous line. |
326
|
| 'while' is not followed by whitespace. |
328
|
| '(' is followed by whitespace. |
328
|
| ')' is preceded with whitespace. |
328
|
| '{' should be on the previous line. |
329
|
| 'cast' is not followed by whitespace. |
330
|
| '}' should be on the same line. |
333
|
| '{' should be on the previous line. |
335
|
| Method 'registerAllocatedStatement' is not designed for extension - needs to be abstract, final or empty. |
346
|
| '(' is followed by whitespace. |
346
|
| Parameter stmt should be final. |
346
|
| Expected @param tag for 'stmt'. |
346
|
| ')' is preceded with whitespace. |
346
|
| '{' should be on the previous line. |
347
|
| 'synchronized' is not followed by whitespace. |
348
|
| '(' is followed by whitespace. |
348
|
| ')' is preceded with whitespace. |
348
|
| '{' should be on the previous line. |
349
|
| '(' is followed by whitespace. |
350
|
| ')' is preceded with whitespace. |
350
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
354
|
| Missing a Javadoc comment. |
354
|
| '{' should be on the previous line. |
355
|
| '{' should be on the previous line. |
357
|
| '}' should be on the same line. |
359
|
| 'catch' is not followed by whitespace. |
360
|
| '(' is followed by whitespace. |
360
|
| ')' is preceded with whitespace. |
360
|
| '{' should be on the previous line. |
361
|
| 'if' is not followed by whitespace. |
362
|
| '(' is followed by whitespace. |
362
|
| ')' is preceded with whitespace. |
362
|
| '{' should be on the previous line. |
363
|
| '(' is followed by whitespace. |
364
|
| ')' is preceded with whitespace. |
364
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
369
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
369
|
| Missing a Javadoc comment. |
369
|
| '(' is followed by whitespace. |
369
|
| Parameter obj should be final. |
369
|
| ')' is preceded with whitespace. |
369
|
| '{' should be on the previous line. |
370
|
| 'if' is not followed by whitespace. |
371
|
| '(' is followed by whitespace. |
371
|
| '(' is followed by whitespace. |
371
|
| ')' is preceded with whitespace. |
371
|
| ')' is preceded with whitespace. |
371
|
| '{' should be on the previous line. |
372
|
| ')' is preceded with whitespace. |
373
|
| 'if' is not followed by whitespace. |
375
|
| '(' is followed by whitespace. |
375
|
| ')' is preceded with whitespace. |
375
|
| '{' should be on the previous line. |
376
|
| Line is longer than 80 characters. |
377
|
| '(' is followed by whitespace. |
377
|
| '(' is followed by whitespace. |
377
|
| 'cast' is not followed by whitespace. |
377
|
| ')' is preceded with whitespace. |
377
|
| ')' is preceded with whitespace. |
377
|
| Method 'invoke' is not designed for extension - needs to be abstract, final or empty. |
384
|
| Missing a Javadoc comment. |
384
|
| '(' is followed by whitespace. |
384
|
| Parameter proxy should be final. |
384
|
| Parameter method should be final. |
384
|
| Parameter args should be final. |
384
|
| ')' is preceded with whitespace. |
384
|
| '{' should be on the previous line. |
386
|
| Line is longer than 80 characters. |
387
|
| Line has trailing spaces. |
389
|
| 'cast' is not followed by whitespace. |
391
|
| '(' is followed by whitespace. |
391
|
| ')' is preceded with whitespace. |
391
|
| '{' should be on the previous line. |
394
|
| 'if' is not followed by whitespace. |
395
|
| '(' is followed by whitespace. |
395
|
| ')' is preceded with whitespace. |
395
|
| '{' should be on the previous line. |
396
|
| '(' is followed by whitespace. |
397
|
| ')' is preceded with whitespace. |
397
|
| '}' should be on the same line. |
398
|
| '{' should be on the previous line. |
400
|
| '(' is followed by whitespace. |
401
|
| ')' is preceded with whitespace. |
401
|
| '}' should be on the same line. |
403
|
| 'catch' is not followed by whitespace. |
404
|
| '(' is followed by whitespace. |
404
|
| ')' is preceded with whitespace. |
404
|
| '{' should be on the previous line. |
405
|
| Line is longer than 80 characters. |
406
|
| Line has trailing spaces. |
409
|
| Line has trailing spaces. |
412
|
| '(' is followed by whitespace. |
414
|
| ')' is preceded with whitespace. |
414
|
| '{' should be on the previous line. |
415
|
| Line is longer than 80 characters. |
416
|
| '(' is followed by whitespace. |
418
|
| ')' is preceded with whitespace. |
418
|
| '{' should be on the previous line. |
419
|
| Line is longer than 80 characters. |
420
|
| '(' is followed by whitespace. |
420
|
| Line is longer than 80 characters. |
421
|
| '{' is followed by whitespace. |
421
|
| '(' is followed by whitespace. |
421
|
| ')' is preceded with whitespace. |
421
|
| ')' is preceded with whitespace. |
421
|
| '}' should be on the same line. |
422
|
| '(' is followed by whitespace. |
423
|
| ')' is preceded with whitespace. |
423
|
| '{' should be on the previous line. |
424
|
| Line is longer than 80 characters. |
425
|
| '(' is followed by whitespace. |
425
|
| Line is longer than 80 characters. |
426
|
| '{' is followed by whitespace. |
426
|
| '(' is followed by whitespace. |
426
|
| ')' is preceded with whitespace. |
426
|
| ')' is preceded with whitespace. |
426
|
| '}' should be on the same line. |
427
|
| '(' is followed by whitespace. |
428
|
| ')' is preceded with whitespace. |
428
|
| '{' should be on the previous line. |
429
|
| Line is longer than 80 characters. |
430
|
| '(' is followed by whitespace. |
430
|
| Line is longer than 80 characters. |
431
|
| '{' is followed by whitespace. |
431
|
| '(' is followed by whitespace. |
431
|
| ')' is preceded with whitespace. |
431
|
| ')' is preceded with whitespace. |
431
|
| '}' should be on the same line. |
432
|
| '(' is followed by whitespace. |
433
|
| ')' is preceded with whitespace. |
433
|
| '{' should be on the previous line. |
434
|
| Line is longer than 80 characters. |
435
|
| '(' is followed by whitespace. |
435
|
| Line is longer than 80 characters. |
436
|
| '{' is followed by whitespace. |
436
|
| '(' is followed by whitespace. |
436
|
| ')' is preceded with whitespace. |
436
|
| ')' is preceded with whitespace. |
436
|
| '}' should be on the same line. |
437
|
| '{' should be on the previous line. |
439
|
| Must have at least one statement. |
439
|
| Class ProxiedObject should be declared as final. |
447
|
| Missing a Javadoc comment. |
447
|
| '{' should be on the previous line. |
449
|
| Missing a Javadoc comment. |
450
|
| Name 'm_originalObject' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
450
|
| Variable 'm_originalObject' must be private and have accessor methods. |
450
|
| Line has trailing spaces. |
451
|
| Missing a Javadoc comment. |
452
|
| '(' is followed by whitespace. |
452
|
| Parameter originalObject should be final. |
452
|
| ')' is preceded with whitespace. |
452
|
| '{' should be on the previous line. |
453
|
| Line has trailing spaces. |
456
|
| Missing a Javadoc comment. |
457
|
| '(' is followed by whitespace. |
457
|
| Parameter proxy should be final. |
457
|
| Parameter method should be final. |
457
|
| Parameter args should be final. |
457
|
| ')' is preceded with whitespace. |
457
|
| '{' should be on the previous line. |
459
|
| Line is longer than 80 characters. |
460
|
| Line is longer than 80 characters. |
461
|
| Line is longer than 80 characters. |
462
|
| Line has trailing spaces. |
464
|
| '{' should be on the previous line. |
467
|
| '(' is followed by whitespace. |
468
|
| ')' is preceded with whitespace. |
468
|
| '}' should be on the same line. |
469
|
| 'catch' is not followed by whitespace. |
470
|
| '(' is followed by whitespace. |
470
|
| ')' is preceded with whitespace. |
470
|
| '{' should be on the previous line. |
471
|
| Line is longer than 80 characters. |
472
|
| Line has trailing spaces. |
475
|
| Line has trailing spaces. |
478
|
| '(' is followed by whitespace. |
480
|
| ')' is preceded with whitespace. |
480
|
| '{' should be on the previous line. |
481
|
| Line is longer than 80 characters. |
482
|
| '(' is followed by whitespace. |
484
|
| ')' is preceded with whitespace. |
484
|
| '{' should be on the previous line. |
485
|
| Line is longer than 80 characters. |
486
|
| '(' is followed by whitespace. |
486
|
| Line is longer than 80 characters. |
487
|
| '{' is followed by whitespace. |
487
|
| '(' is followed by whitespace. |
487
|
| ')' is preceded with whitespace. |
487
|
| ')' is preceded with whitespace. |
487
|
| '}' should be on the same line. |
488
|
| Line is longer than 80 characters. |
489
|
| '(' is followed by whitespace. |
489
|
| '(' is followed by whitespace. |
489
|
| ')' is preceded with whitespace. |
489
|
| '(' is followed by whitespace. |
489
|
| ')' is preceded with whitespace. |
489
|
| ')' is preceded with whitespace. |
489
|
| Line is longer than 80 characters. |
491
|
| Line is longer than 80 characters. |
492
|
| '(' is followed by whitespace. |
492
|
| Line is longer than 80 characters. |
493
|
| '{' is followed by whitespace. |
493
|
| '(' is followed by whitespace. |
494
|
| ')' is preceded with whitespace. |
494
|
| ')' is preceded with whitespace. |
494
|
| '}' should be on the same line. |
495
|
| '(' is followed by whitespace. |
496
|
| ')' is preceded with whitespace. |
496
|
| '{' should be on the previous line. |
497
|
| Line is longer than 80 characters. |
498
|
| '(' is followed by whitespace. |
498
|
| Line is longer than 80 characters. |
499
|
| '{' is followed by whitespace. |
499
|
| '(' is followed by whitespace. |
499
|
| ')' is preceded with whitespace. |
499
|
| ')' is preceded with whitespace. |
499
|
| '}' should be on the same line. |
500
|
| '(' is followed by whitespace. |
501
|
| ')' is preceded with whitespace. |
501
|
| '{' should be on the previous line. |
502
|
| Line is longer than 80 characters. |
503
|
| '(' is followed by whitespace. |
503
|
| Line is longer than 80 characters. |
504
|
| '{' is followed by whitespace. |
504
|
| '(' is followed by whitespace. |
504
|
| ')' is preceded with whitespace. |
504
|
| ')' is preceded with whitespace. |
504
|
| '}' should be on the same line. |
505
|
| '(' is followed by whitespace. |
506
|
| ')' is preceded with whitespace. |
506
|
| '{' should be on the previous line. |
507
|
| Line is longer than 80 characters. |
508
|
| '(' is followed by whitespace. |
508
|
| Line is longer than 80 characters. |
509
|
| '{' is followed by whitespace. |
509
|
| '(' is followed by whitespace. |
509
|
| ')' is preceded with whitespace. |
509
|
| ')' is preceded with whitespace. |
509
|
| '}' should be on the same line. |
510
|
| '{' should be on the previous line. |
512
|
| Must have at least one statement. |
512
|
| Line has trailing spaces. |
516
|
org/apache/avalon/excalibur/datasource/DataSourceComponent.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
36
|
| First sentence should end with a period. |
37
|
| First sentence should end with a period. |
42
|
| Line is longer than 80 characters. |
47
|
| Unused @throws tag for 'NoValidConnectionException'. |
47
|
| Unused @throws tag for 'NoAvailableConnectionException'. |
50
|
| Expected @throws tag for 'SQLException'. |
54
|
org/apache/avalon/excalibur/datasource/InformixDataSource.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line has trailing spaces. |
84
|
| '{' should be on the previous line. |
97
|
| Missing a Javadoc comment. |
98
|
| Name 'm_dataSource' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
98
|
| Missing a Javadoc comment. |
99
|
| Name 'm_autocommit' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
99
|
| Missing a Javadoc comment. |
100
|
| Name 'INIT_FACTORY' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
100
|
| '{' should be on the previous line. |
108
|
| 'if' is not followed by whitespace. |
109
|
| '(' is followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| '{' should be on the previous line. |
110
|
| '(' is followed by whitespace. |
111
|
| Line is longer than 80 characters. |
112
|
| ')' is preceded with whitespace. |
112
|
| First sentence should end with a period. |
116
|
| Expected an @return tag. |
119
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Expected @throws tag for 'SQLException'. |
119
|
| '{' should be on the previous line. |
120
|
| 'if' is not followed by whitespace. |
123
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| '{' should be on the previous line. |
124
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
134
|
| '(' is followed by whitespace. |
134
|
| Parameter conf should be final. |
134
|
| Expected @param tag for 'conf'. |
134
|
| ')' is preceded with whitespace. |
134
|
| Expected @throws tag for 'ConfigurationException'. |
134
|
| '{' should be on the previous line. |
135
|
| '(' is followed by whitespace. |
136
|
| ')' is preceded with whitespace. |
136
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| Line is longer than 80 characters. |
138
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| '(' is followed by whitespace. |
139
|
| ')' is preceded with whitespace. |
139
|
| '(' is followed by whitespace. |
139
|
| ')' is preceded with whitespace. |
139
|
| Line is longer than 80 characters. |
141
|
| '(' is followed by whitespace. |
141
|
| '5' is a magic number. |
141
|
| ')' is preceded with whitespace. |
141
|
| ')' is preceded with whitespace. |
141
|
| ')' is preceded with whitespace. |
141
|
| Line is longer than 80 characters. |
142
|
| '(' is followed by whitespace. |
142
|
| '5' is a magic number. |
142
|
| ')' is preceded with whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| Line is longer than 80 characters. |
143
|
| '(' is followed by whitespace. |
143
|
| '10' is a magic number. |
143
|
| ')' is preceded with whitespace. |
143
|
| ')' is preceded with whitespace. |
143
|
| ')' is preceded with whitespace. |
143
|
| Line is longer than 80 characters. |
144
|
| '(' is followed by whitespace. |
144
|
| '100' is a magic number. |
144
|
| ')' is preceded with whitespace. |
144
|
| ')' is preceded with whitespace. |
144
|
| Line is longer than 80 characters. |
145
|
| '(' is followed by whitespace. |
145
|
| ')' is preceded with whitespace. |
145
|
| ')' is preceded with whitespace. |
145
|
| Line is longer than 80 characters. |
146
|
| '(' is followed by whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| Line is longer than 80 characters. |
147
|
| '(' is followed by whitespace. |
147
|
| ')' is preceded with whitespace. |
147
|
| ')' is preceded with whitespace. |
147
|
| Line is longer than 80 characters. |
148
|
| '(' is followed by whitespace. |
148
|
| '(' is followed by whitespace. |
148
|
| ')' is preceded with whitespace. |
148
|
| '(' is followed by whitespace. |
148
|
| ')' is preceded with whitespace. |
148
|
| ')' is preceded with whitespace. |
148
|
| ')' is preceded with whitespace. |
148
|
| Line is longer than 80 characters. |
149
|
| '(' is followed by whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| Line is longer than 80 characters. |
150
|
| '(' is followed by whitespace. |
150
|
| ')' is preceded with whitespace. |
150
|
| ')' is preceded with whitespace. |
150
|
| '{' should be on the previous line. |
153
|
| '(' is followed by whitespace. |
156
|
| ')' is preceded with whitespace. |
156
|
| Line is longer than 80 characters. |
158
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
158
|
| ')' is preceded with whitespace. |
159
|
| Line is longer than 80 characters. |
160
|
| '(' is followed by whitespace. |
160
|
| ')' is preceded with whitespace. |
160
|
| ')' is preceded with whitespace. |
160
|
| Line is longer than 80 characters. |
161
|
| '(' is followed by whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| Line is longer than 80 characters. |
162
|
| '(' is followed by whitespace. |
162
|
| ')' is preceded with whitespace. |
162
|
| ')' is preceded with whitespace. |
162
|
| Line is longer than 80 characters. |
163
|
| '(' is followed by whitespace. |
163
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| Line is longer than 80 characters. |
164
|
| '(' is followed by whitespace. |
164
|
| ')' is preceded with whitespace. |
164
|
| ')' is preceded with whitespace. |
164
|
| Line is longer than 80 characters. |
165
|
| '(' is followed by whitespace. |
165
|
| ')' is preceded with whitespace. |
165
|
| ')' is preceded with whitespace. |
165
|
| '(' is followed by whitespace. |
166
|
| '(' is followed by whitespace. |
166
|
| ')' is preceded with whitespace. |
166
|
| ')' is preceded with whitespace. |
166
|
| '(' is followed by whitespace. |
168
|
| ')' is preceded with whitespace. |
168
|
| '}' should be on the same line. |
169
|
| 'catch' is not followed by whitespace. |
170
|
| '(' is followed by whitespace. |
170
|
| ')' is preceded with whitespace. |
170
|
| '{' should be on the previous line. |
171
|
| 'if' is not followed by whitespace. |
172
|
| '(' is followed by whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| '{' should be on the previous line. |
173
|
| Line is longer than 80 characters. |
174
|
| '(' is followed by whitespace. |
174
|
| ')' is preceded with whitespace. |
174
|
| Line is longer than 80 characters. |
176
|
| '(' is followed by whitespace. |
176
|
| ')' is preceded with whitespace. |
176
|
| '(' is followed by whitespace. |
186
|
| ')' is preceded with whitespace. |
186
|
| '{' should be on the previous line. |
188
|
| '(' is followed by whitespace. |
189
|
| ')' is preceded with whitespace. |
189
|
| '{' should be on the previous line. |
190
|
| '(' is followed by whitespace. |
191
|
| ')' is preceded with whitespace. |
191
|
| '{' should be on the previous line. |
194
|
| Line is longer than 80 characters. |
196
|
| '(' is followed by whitespace. |
196
|
| '(' is followed by whitespace. |
196
|
| ')' is preceded with whitespace. |
196
|
| ')' is preceded with whitespace. |
196
|
| ')' is preceded with whitespace. |
196
|
| Line is longer than 80 characters. |
197
|
| '(' is followed by whitespace. |
197
|
| ')' is preceded with whitespace. |
197
|
| ')' is preceded with whitespace. |
197
|
| '(' is followed by whitespace. |
200
|
| ')' is preceded with whitespace. |
200
|
| '{' should be on the previous line. |
203
|
| Line is longer than 80 characters. |
205
|
| '(' is followed by whitespace. |
205
|
| '(' is followed by whitespace. |
205
|
| ')' is preceded with whitespace. |
205
|
| ')' is preceded with whitespace. |
205
|
| ')' is preceded with whitespace. |
205
|
| Line is longer than 80 characters. |
206
|
| '(' is followed by whitespace. |
206
|
| ')' is preceded with whitespace. |
206
|
| ')' is preceded with whitespace. |
206
|
| Line has trailing spaces. |
210
|
| Missing a Javadoc comment. |
211
|
| Parameter className should be final. |
211
|
| '{' should be on the previous line. |
213
|
| Line has trailing spaces. |
215
|
| '{' should be on the previous line. |
217
|
| Line is longer than 80 characters. |
218
|
| '}' should be on the same line. |
219
|
| '{' should be on the previous line. |
221
|
| Line has trailing spaces. |
224
|
| Line has trailing spaces. |
227
|
| Missing a Javadoc comment. |
228
|
| Parameter obj should be final. |
228
|
| Parameter propertyName should be final. |
228
|
| Parameter value should be final. |
228
|
| '{' should be on the previous line. |
230
|
| Line has trailing spaces. |
232
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
| '{' should be on the previous line. |
234
|
| '}' should be on the same line. |
236
|
| '(' is followed by whitespace. |
237
|
| ')' is preceded with whitespace. |
237
|
| '{' should be on the previous line. |
238
|
| Line has trailing spaces. |
241
|
| '{' should be on the previous line. |
243
|
| Line is longer than 80 characters. |
244
|
| '}' should be on the same line. |
246
|
| '{' should be on the previous line. |
248
|
org/apache/avalon/excalibur/datasource/J2eeDataSource.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
50
|
| Missing a Javadoc comment. |
51
|
| Missing a Javadoc comment. |
52
|
| Name 'm_dataSource' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
52
|
| Variable 'm_dataSource' must be private and have accessor methods. |
52
|
| Missing a Javadoc comment. |
53
|
| Name 'm_user' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
53
|
| Variable 'm_user' must be private and have accessor methods. |
53
|
| Missing a Javadoc comment. |
54
|
| Name 'm_password' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
54
|
| Variable 'm_password' must be private and have accessor methods. |
54
|
| Unused @param tag for 'conf'. |
61
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
66
|
| '(' is followed by whitespace. |
66
|
| Expected @param tag for 'configuration'. |
66
|
| ')' is preceded with whitespace. |
66
|
| Expected @throws tag for 'ConfigurationException'. |
67
|
| '{' should be on the previous line. |
68
|
| 'if' is not followed by whitespace. |
69
|
| '(' is followed by whitespace. |
69
|
| ')' is preceded with whitespace. |
69
|
| '{' should be on the previous line. |
70
|
| Line is longer than 80 characters. |
72
|
| '(' is followed by whitespace. |
72
|
| ')' is preceded with whitespace. |
72
|
| '(' is followed by whitespace. |
72
|
| ')' is preceded with whitespace. |
72
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| '(' is followed by whitespace. |
76
|
| ')' is preceded with whitespace. |
76
|
| '(' is followed by whitespace. |
76
|
| ')' is preceded with whitespace. |
76
|
| '(' is followed by whitespace. |
78
|
| ')' is preceded with whitespace. |
78
|
| '{' should be on the previous line. |
79
|
| '+' should be on a new line. |
80
|
| '(' is followed by whitespace. |
81
|
| ')' is preceded with whitespace. |
81
|
| '{' should be on the previous line. |
85
|
| '(' is followed by whitespace. |
87
|
| ')' is preceded with whitespace. |
87
|
| '{' should be on the previous line. |
88
|
| '}' should be on the same line. |
90
|
| '{' should be on the previous line. |
92
|
| '(' is followed by whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| '{' should be on the previous line. |
95
|
| Line is longer than 80 characters. |
96
|
| '(' is followed by whitespace. |
96
|
| ')' is preceded with whitespace. |
96
|
| '(' is followed by whitespace. |
98
|
| ')' is preceded with whitespace. |
98
|
| '{' should be on the previous line. |
99
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
100
|
| '(' is followed by whitespace. |
102
|
| ')' is preceded with whitespace. |
102
|
| '(' is followed by whitespace. |
105
|
| ')' is preceded with whitespace. |
105
|
| '{' should be on the previous line. |
106
|
| 'cast' is not followed by whitespace. |
108
|
| '(' is followed by whitespace. |
108
|
| ')' is preceded with whitespace. |
108
|
| '}' should be on the same line. |
109
|
| '{' should be on the previous line. |
111
|
| Line is longer than 80 characters. |
112
|
| 'cast' is not followed by whitespace. |
112
|
| '(' is followed by whitespace. |
112
|
| ')' is preceded with whitespace. |
112
|
| '}' should be on the same line. |
114
|
| 'catch' is not followed by whitespace. |
115
|
| '(' is followed by whitespace. |
115
|
| ')' is preceded with whitespace. |
115
|
| '{' should be on the previous line. |
116
|
| 'if' is not followed by whitespace. |
117
|
| '(' is followed by whitespace. |
117
|
| ')' is preceded with whitespace. |
117
|
| '{' should be on the previous line. |
118
|
| Line is longer than 80 characters. |
119
|
| '(' is followed by whitespace. |
119
|
| ')' is preceded with whitespace. |
119
|
| Line is longer than 80 characters. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '(' is followed by whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| '(' is followed by whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| First sentence should end with a period. |
130
|
| Expected an @return tag. |
131
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Expected @throws tag for 'SQLException'. |
132
|
| '{' should be on the previous line. |
133
|
| 'if' is not followed by whitespace. |
134
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '{' should be on the previous line. |
135
|
| '(' is followed by whitespace. |
136
|
| ')' is preceded with whitespace. |
136
|
| '(' is followed by whitespace. |
139
|
| ')' is preceded with whitespace. |
139
|
| '{' should be on the previous line. |
140
|
| '}' should be on the same line. |
142
|
| '{' should be on the previous line. |
144
|
| '(' is followed by whitespace. |
145
|
| ')' is preceded with whitespace. |
145
|
org/apache/avalon/excalibur/datasource/Jdbc3Connection.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line has trailing spaces. |
27
|
| '{' should be on the previous line. |
35
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
39
|
| Line is longer than 80 characters. |
42
|
| '(' is followed by whitespace. |
42
|
| ')' is preceded with whitespace. |
42
|
| '(' is followed by whitespace. |
44
|
| ')' is preceded with whitespace. |
44
|
| Line has trailing spaces. |
46
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| '(' is followed by whitespace. |
56
|
| ')' is preceded with whitespace. |
58
|
| '{' should be on the previous line. |
59
|
| '(' is followed by whitespace. |
60
|
| ')' is preceded with whitespace. |
60
|
org/apache/avalon/excalibur/datasource/JdbcConnection.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line has trailing spaces. |
26
|
| '{' should be on the previous line. |
34
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| '(' is followed by whitespace. |
41
|
| ')' is preceded with whitespace. |
41
|
| '(' is followed by whitespace. |
43
|
| ')' is preceded with whitespace. |
43
|
| Line has trailing spaces. |
45
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| '(' is followed by whitespace. |
55
|
| ')' is preceded with whitespace. |
57
|
| '{' should be on the previous line. |
58
|
| '(' is followed by whitespace. |
59
|
| ')' is preceded with whitespace. |
59
|
org/apache/avalon/excalibur/datasource/JdbcConnectionFactory.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
40
|
| Name 'm_dburl' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
40
|
| Missing a Javadoc comment. |
41
|
| Name 'm_username' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
41
|
| Missing a Javadoc comment. |
42
|
| Name 'm_password' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| Missing a Javadoc comment. |
43
|
| Name 'm_autoCommit' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Missing a Javadoc comment. |
44
|
| Name 'm_keepAlive' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_keepAliveAge' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Missing a Javadoc comment. |
46
|
| Name 'm_connectionClass' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
46
|
| Missing a Javadoc comment. |
47
|
| Name 'm_class' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
47
|
| Missing a Javadoc comment. |
48
|
| Line is longer than 80 characters. |
49
|
| Missing a Javadoc comment. |
49
|
| Missing a Javadoc comment. |
50
|
| Name 'm_firstConnection' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
50
|
| Line is longer than 80 characters. |
53
|
| '(' is followed by whitespace. |
56
|
| Expected @param tag for 'url'. |
56
|
| Expected @param tag for 'username'. |
57
|
| Expected @param tag for 'password'. |
58
|
| Expected @param tag for 'autoCommit'. |
59
|
| Expected @param tag for 'oradb'. |
60
|
| ')' is preceded with whitespace. |
60
|
| '{' should be on the previous line. |
61
|
| '(' is followed by whitespace. |
62
|
| ')' is preceded with whitespace. |
62
|
| Line is longer than 80 characters. |
66
|
| '(' is followed by whitespace. |
69
|
| Expected @param tag for 'url'. |
69
|
| Expected @param tag for 'username'. |
70
|
| Expected @param tag for 'password'. |
71
|
| Expected @param tag for 'autoCommit'. |
72
|
| Expected @param tag for 'oradb'. |
73
|
| Expected @param tag for 'connectionClass'. |
74
|
| ')' is preceded with whitespace. |
74
|
| '{' should be on the previous line. |
75
|
| Line is longer than 80 characters. |
76
|
| '(' is followed by whitespace. |
76
|
| '(' is followed by whitespace. |
76
|
| ')' is preceded with whitespace. |
76
|
| Avoid inline conditionals. |
76
|
| ')' is preceded with whitespace. |
76
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
88
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
97
|
| '{' should be on the previous line. |
98
|
| Line is longer than 80 characters. |
99
|
| '(' is followed by whitespace. |
99
|
| '5000' is a magic number. |
99
|
| ')' is preceded with whitespace. |
99
|
| Line is longer than 80 characters. |
108
|
| Line is longer than 80 characters. |
110
|
| Line is longer than 80 characters. |
111
|
| Line is longer than 80 characters. |
113
|
| Line is longer than 80 characters. |
114
|
| '(' is followed by whitespace. |
118
|
| ')' is preceded with whitespace. |
124
|
| '{' should be on the previous line. |
125
|
| '{' should be on the previous line. |
135
|
| 'if' is not followed by whitespace. |
136
|
| '(' is followed by whitespace. |
136
|
| ')' is preceded with whitespace. |
136
|
| '{' should be on the previous line. |
137
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| '}' should be on the same line. |
139
|
| '{' should be on the previous line. |
141
|
| Line is longer than 80 characters. |
142
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| '}' should be on the same line. |
146
|
| 'catch' is not followed by whitespace. |
147
|
| '(' is followed by whitespace. |
147
|
| ')' is preceded with whitespace. |
147
|
| '{' should be on the previous line. |
148
|
| Must have at least one statement. |
148
|
| Line is longer than 80 characters. |
150
|
| Line is longer than 80 characters. |
151
|
| Line is longer than 80 characters. |
152
|
| Missing a Javadoc comment. |
156
|
| '{' should be on the previous line. |
157
|
| 'if' is not followed by whitespace. |
159
|
| '(' is followed by whitespace. |
159
|
| ')' is preceded with whitespace. |
159
|
| '{' should be on the previous line. |
160
|
| '}' should be on the same line. |
162
|
| '{' should be on the previous line. |
164
|
| Line is longer than 80 characters. |
165
|
| '(' is followed by whitespace. |
165
|
| ')' is preceded with whitespace. |
165
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Missing a Javadoc comment. |
169
|
| '{' should be on the previous line. |
170
|
| 'if' is not followed by whitespace. |
174
|
| '(' is followed by whitespace. |
174
|
| ')' is preceded with whitespace. |
174
|
| '{' should be on the previous line. |
175
|
| 'if' is not followed by whitespace. |
176
|
| '(' is followed by whitespace. |
176
|
| ')' is preceded with whitespace. |
176
|
| '{' should be on the previous line. |
177
|
| '(' is followed by whitespace. |
178
|
| ')' is preceded with whitespace. |
178
|
| '}' should be on the same line. |
179
|
| '{' should be on the previous line. |
181
|
| Line is longer than 80 characters. |
182
|
| '(' is followed by whitespace. |
182
|
| ')' is preceded with whitespace. |
182
|
| '}' should be on the same line. |
184
|
| '{' should be on the previous line. |
186
|
| 'if' is not followed by whitespace. |
190
|
| '(' is followed by whitespace. |
190
|
| ')' is preceded with whitespace. |
190
|
| '{' should be on the previous line. |
191
|
| '{' should be on the previous line. |
193
|
| '}' should be on the same line. |
195
|
| 'catch' is not followed by whitespace. |
196
|
| '(' is followed by whitespace. |
196
|
| ')' is preceded with whitespace. |
196
|
| '{' should be on the previous line. |
197
|
| 'if' is not followed by whitespace. |
198
|
| '(' is followed by whitespace. |
198
|
| ')' is preceded with whitespace. |
198
|
| '{' should be on the previous line. |
199
|
| Line is longer than 80 characters. |
200
|
| '(' is followed by whitespace. |
200
|
| ')' is preceded with whitespace. |
200
|
| Line is longer than 80 characters. |
202
|
| '(' is followed by whitespace. |
202
|
| ')' is preceded with whitespace. |
202
|
| '{' should be on the previous line. |
207
|
| Line is longer than 80 characters. |
208
|
| '(' is followed by whitespace. |
208
|
| ')' is preceded with whitespace. |
208
|
| '}' should be on the same line. |
209
|
| 'catch' is not followed by whitespace. |
210
|
| '(' is followed by whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| '{' should be on the previous line. |
211
|
| 'if' is not followed by whitespace. |
212
|
| '(' is followed by whitespace. |
212
|
| ')' is preceded with whitespace. |
212
|
| '{' should be on the previous line. |
213
|
| Line is longer than 80 characters. |
214
|
| '(' is followed by whitespace. |
214
|
| ')' is preceded with whitespace. |
214
|
| '(' is followed by whitespace. |
217
|
| ')' is preceded with whitespace. |
217
|
| Line is longer than 80 characters. |
220
|
| '(' is followed by whitespace. |
220
|
| '(' is followed by whitespace. |
220
|
| ')' is preceded with whitespace. |
220
|
| ')' is preceded with whitespace. |
220
|
| 'if' is not followed by whitespace. |
223
|
| '(' is followed by whitespace. |
223
|
| ')' is preceded with whitespace. |
223
|
| '{' should be on the previous line. |
224
|
| '(' is followed by whitespace. |
225
|
| ')' is preceded with whitespace. |
225
|
| 'if' is not followed by whitespace. |
228
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
| '{' should be on the previous line. |
229
|
| '(' is followed by whitespace. |
230
|
| ')' is preceded with whitespace. |
230
|
| Method 'getCreatedClass' is not designed for extension - needs to be abstract, final or empty. |
236
|
| Missing a Javadoc comment. |
236
|
| '{' should be on the previous line. |
237
|
| Method 'decommission' is not designed for extension - needs to be abstract, final or empty. |
241
|
| Missing a Javadoc comment. |
241
|
| '(' is followed by whitespace. |
241
|
| Parameter object should be final. |
241
|
| ')' is preceded with whitespace. |
241
|
| '{' should be on the previous line. |
242
|
| 'if' is not followed by whitespace. |
243
|
| '(' is followed by whitespace. |
243
|
| ')' is preceded with whitespace. |
243
|
| '{' should be on the previous line. |
244
|
| '(' is followed by whitespace. |
245
|
| 'cast' is not followed by whitespace. |
245
|
| ')' is preceded with whitespace. |
245
|
| 'if' is not followed by whitespace. |
247
|
| '(' is followed by whitespace. |
247
|
| ')' is preceded with whitespace. |
247
|
| '{' should be on the previous line. |
248
|
| '(' is followed by whitespace. |
249
|
| ')' is preceded with whitespace. |
249
|
| Line is longer than 80 characters. |
254
|
| Missing a Javadoc comment. |
254
|
| '(' is followed by whitespace. |
254
|
| Parameter conn should be final. |
254
|
| Parameter keepAlive should be final. |
254
|
| Parameter keepAliveAge should be final. |
254
|
| ')' is preceded with whitespace. |
254
|
| '{' should be on the previous line. |
259
|
| Line is longer than 80 characters. |
260
|
| '(' is followed by whitespace. |
260
|
| Line is longer than 80 characters. |
261
|
| Line is longer than 80 characters. |
262
|
| ')' is preceded with whitespace. |
262
|
| 'cast' is not followed by whitespace. |
263
|
| '(' is followed by whitespace. |
264
|
| ')' is preceded with whitespace. |
264
|
| ')' is preceded with whitespace. |
264
|
| '}' should be on the same line. |
265
|
| 'catch' is not followed by whitespace. |
266
|
| '(' is followed by whitespace. |
266
|
| ')' is preceded with whitespace. |
266
|
| '{' should be on the previous line. |
267
|
| Line is longer than 80 characters. |
268
|
| '(' is followed by whitespace. |
270
|
| ')' is preceded with whitespace. |
270
|
| Line is longer than 80 characters. |
271
|
| '(' is followed by whitespace. |
271
|
| ')' is preceded with whitespace. |
271
|
| 'cast' is not followed by whitespace. |
274
|
| ')' is preceded with whitespace. |
280
|
| '(' is followed by whitespace. |
282
|
| ')' is preceded with whitespace. |
282
|
org/apache/avalon/excalibur/datasource/JdbcConnectionPool.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
39
|
| Missing a Javadoc comment. |
40
|
| Name 'm_cause' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
40
|
| Missing a Javadoc comment. |
41
|
| Name 'm_initThread' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
41
|
| Missing a Javadoc comment. |
42
|
| Name 'm_autoCommit' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| Missing a Javadoc comment. |
43
|
| Name 'm_noConnections' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Missing a Javadoc comment. |
44
|
| Name 'm_wait' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_spinLock' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Line has trailing spaces. |
47
|
| Missing a Javadoc comment. |
47
|
| '(' is followed by whitespace. |
47
|
| Line has trailing spaces. |
48
|
| Line has trailing spaces. |
49
|
| Line has trailing spaces. |
50
|
| ')' is preceded with whitespace. |
51
|
| '{' should be on the previous line. |
53
|
| '(' is followed by whitespace. |
54
|
| ')' is preceded with whitespace. |
54
|
| Method 'setTimeout' is not designed for extension - needs to be abstract, final or empty. |
66
|
| '(' is followed by whitespace. |
66
|
| Parameter timeout should be final. |
66
|
| Expected @param tag for 'timeout'. |
66
|
| ')' is preceded with whitespace. |
66
|
| '{' should be on the previous line. |
67
|
| 'if' is not followed by whitespace. |
68
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| '{' should be on the previous line. |
69
|
| Line is longer than 80 characters. |
70
|
| '(' is followed by whitespace. |
70
|
| ')' is preceded with whitespace. |
70
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Missing a Javadoc comment. |
76
|
| '{' should be on the previous line. |
77
|
| '(' is followed by whitespace. |
78
|
| ')' is preceded with whitespace. |
78
|
| Missing a Javadoc comment. |
82
|
| '{' should be on the previous line. |
83
|
| 'if' is not followed by whitespace. |
86
|
| '(' is followed by whitespace. |
86
|
| ')' is preceded with whitespace. |
86
|
| '{' should be on the previous line. |
87
|
| 'cast' is not followed by whitespace. |
88
|
| '}' should be on the same line. |
89
|
| '{' should be on the previous line. |
91
|
| 'while' is not followed by whitespace. |
94
|
| '(' is followed by whitespace. |
94
|
| '(' is followed by whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| '(' is followed by whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| '{' should be on the previous line. |
95
|
| '{' should be on the previous line. |
97
|
| 'synchronized' is not followed by whitespace. |
101
|
| '{' should be on the previous line. |
102
|
| '(' is followed by whitespace. |
103
|
| ')' is preceded with whitespace. |
103
|
| '}' should be on the same line. |
105
|
| '{' should be on the previous line. |
107
|
| '{' should be on the previous line. |
112
|
| 'cast' is not followed by whitespace. |
113
|
| '}' should be on the same line. |
114
|
| '{' should be on the previous line. |
116
|
| Must have at least one statement. |
116
|
| 'if' is not followed by whitespace. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '{' should be on the previous line. |
123
|
| Line is longer than 80 characters. |
124
|
| '(' is followed by whitespace. |
124
|
| ')' is preceded with whitespace. |
124
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Missing a Javadoc comment. |
131
|
| '{' should be on the previous line. |
133
|
| 'if' is not followed by whitespace. |
134
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '{' should be on the previous line. |
135
|
| 'if' is not followed by whitespace. |
136
|
| '(' is followed by whitespace. |
136
|
| ')' is preceded with whitespace. |
136
|
| '{' should be on the previous line. |
137
|
| 'if' construct must use '{}'s. |
138
|
| Line has trailing spaces. |
139
|
| Line is longer than 80 characters. |
140
|
| '(' is followed by whitespace. |
140
|
| ')' is preceded with whitespace. |
140
|
| '}' should be on the same line. |
141
|
| 'if' is not followed by whitespace. |
142
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| '{' should be on the previous line. |
143
|
| Line is longer than 80 characters. |
144
|
| '(' is followed by whitespace. |
144
|
| ')' is preceded with whitespace. |
144
|
| '}' should be on the same line. |
145
|
| '{' should be on the previous line. |
147
|
| 'cast' is not followed by whitespace. |
152
|
| 'if' is not followed by whitespace. |
154
|
| '(' is followed by whitespace. |
154
|
| 'cast' is not followed by whitespace. |
154
|
| ')' is preceded with whitespace. |
154
|
| '{' should be on the previous line. |
155
|
| 'if' is not followed by whitespace. |
156
|
| '(' is followed by whitespace. |
156
|
| ')' is preceded with whitespace. |
156
|
| '{' should be on the previous line. |
157
|
| Line is longer than 80 characters. |
158
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
158
|
| '{' should be on the previous line. |
162
|
| 'if' is not followed by whitespace. |
164
|
| '(' is followed by whitespace. |
164
|
| '(' is followed by whitespace. |
164
|
| ')' is preceded with whitespace. |
164
|
| ')' is preceded with whitespace. |
164
|
| '{' should be on the previous line. |
165
|
| '(' is followed by whitespace. |
166
|
| ')' is preceded with whitespace. |
166
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| 'cast' is not followed by whitespace. |
171
|
| '(' is followed by whitespace. |
173
|
| ')' is preceded with whitespace. |
173
|
| '}' should be on the same line. |
174
|
| 'catch' is not followed by whitespace. |
175
|
| '(' is followed by whitespace. |
175
|
| ')' is preceded with whitespace. |
175
|
| '{' should be on the previous line. |
176
|
| 'if' is not followed by whitespace. |
177
|
| '(' is followed by whitespace. |
177
|
| ')' is preceded with whitespace. |
177
|
| '{' should be on the previous line. |
178
|
| '(' is followed by whitespace. |
179
|
| ')' is preceded with whitespace. |
179
|
| '}' should be on the same line. |
182
|
| '{' should be on the previous line. |
184
|
| 'if' is not followed by whitespace. |
189
|
| '(' is followed by whitespace. |
189
|
| 'cast' is not followed by whitespace. |
189
|
| ')' is preceded with whitespace. |
189
|
| '{' should be on the previous line. |
190
|
| 'cast' is not followed by whitespace. |
191
|
| '(' is followed by whitespace. |
191
|
| ')' is preceded with whitespace. |
191
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
197
|
| Missing a Javadoc comment. |
197
|
| '(' is followed by whitespace. |
197
|
| Parameter obj should be final. |
197
|
| ')' is preceded with whitespace. |
197
|
| '{' should be on the previous line. |
198
|
| '(' is followed by whitespace. |
199
|
| ')' is preceded with whitespace. |
199
|
| 'synchronized' is not followed by whitespace. |
200
|
| '{' should be on the previous line. |
201
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
206
|
| Missing a Javadoc comment. |
206
|
| '{' should be on the previous line. |
207
|
| '{' should be on the previous line. |
209
|
| '(' is followed by whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| 'if' is not followed by whitespace. |
212
|
| '(' is followed by whitespace. |
212
|
| ')' is preceded with whitespace. |
212
|
| '{' should be on the previous line. |
213
|
| '}' should be on the same line. |
215
|
| '{' should be on the previous line. |
217
|
| 'if' is not followed by whitespace. |
220
|
| '(' is followed by whitespace. |
220
|
| ')' is preceded with whitespace. |
220
|
| '{' should be on the previous line. |
221
|
| Line is longer than 80 characters. |
222
|
| '(' is followed by whitespace. |
222
|
| '+' should be on a new line. |
222
|
| Line is longer than 80 characters. |
223
|
| '+' should be on a new line. |
223
|
| Line is longer than 80 characters. |
224
|
| ')' is preceded with whitespace. |
224
|
| '}' should be on the same line. |
227
|
| 'catch' is not followed by whitespace. |
228
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
| '{' should be on the previous line. |
229
|
| 'if' is not followed by whitespace. |
231
|
| '(' is followed by whitespace. |
231
|
| ')' is preceded with whitespace. |
231
|
| '{' should be on the previous line. |
232
|
| Line is longer than 80 characters. |
233
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
org/apache/avalon/excalibur/datasource/JdbcDataSource.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
82
|
| Line has trailing spaces. |
85
|
| '{' should be on the previous line. |
98
|
| Missing a Javadoc comment. |
99
|
| Name 'm_pool' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
99
|
| Variable 'm_pool' must be private and have accessor methods. |
99
|
| Unused @param tag for 'conf'. |
106
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
111
|
| '(' is followed by whitespace. |
111
|
| Expected @param tag for 'configuration'. |
111
|
| ')' is preceded with whitespace. |
111
|
| Expected @throws tag for 'ConfigurationException'. |
112
|
| '{' should be on the previous line. |
113
|
| 'if' is not followed by whitespace. |
114
|
| '(' is followed by whitespace. |
114
|
| ')' is preceded with whitespace. |
114
|
| '{' should be on the previous line. |
115
|
| Line is longer than 80 characters. |
116
|
| '(' is followed by whitespace. |
116
|
| ')' is preceded with whitespace. |
116
|
| '(' is followed by whitespace. |
116
|
| ')' is preceded with whitespace. |
116
|
| '(' is followed by whitespace. |
117
|
| ')' is preceded with whitespace. |
117
|
| Line is longer than 80 characters. |
118
|
| '(' is followed by whitespace. |
118
|
| ')' is preceded with whitespace. |
118
|
| '(' is followed by whitespace. |
118
|
| ')' is preceded with whitespace. |
118
|
| Line is longer than 80 characters. |
119
|
| '(' is followed by whitespace. |
119
|
| ')' is preceded with whitespace. |
119
|
| '(' is followed by whitespace. |
119
|
| ')' is preceded with whitespace. |
119
|
| Line is longer than 80 characters. |
120
|
| '(' is followed by whitespace. |
120
|
| ')' is preceded with whitespace. |
120
|
| Line is longer than 80 characters. |
121
|
| '(' is followed by whitespace. |
121
|
| ')' is preceded with whitespace. |
121
|
| '(' is followed by whitespace. |
121
|
| '5000' is a magic number. |
121
|
| ')' is preceded with whitespace. |
121
|
| Line is longer than 80 characters. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| Line is longer than 80 characters. |
123
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| '(' is followed by whitespace. |
126
|
| '3' is a magic number. |
126
|
| ')' is preceded with whitespace. |
126
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| Line is longer than 80 characters. |
128
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| Line is longer than 80 characters. |
129
|
| '(' is followed by whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| Line is longer than 80 characters. |
130
|
| Line is longer than 80 characters. |
131
|
| '(' is followed by whitespace. |
131
|
| ')' is preceded with whitespace. |
131
|
| Name 'l_max' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
133
|
| Name 'l_min' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
134
|
| 'if' is not followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| '{' should be on the previous line. |
138
|
| 'if' is not followed by whitespace. |
139
|
| '(' is followed by whitespace. |
139
|
| ')' is preceded with whitespace. |
139
|
| '{' should be on the previous line. |
140
|
| '(' is followed by whitespace. |
141
|
| ')' is preceded with whitespace. |
141
|
| '{' should be on the previous line. |
145
|
| Line is longer than 80 characters. |
146
|
| '(' is followed by whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| '}' should be on the same line. |
147
|
| 'catch' is not followed by whitespace. |
148
|
| '(' is followed by whitespace. |
148
|
| ')' is preceded with whitespace. |
148
|
| '{' should be on the previous line. |
149
|
| 'if' is not followed by whitespace. |
150
|
| '(' is followed by whitespace. |
150
|
| ')' is preceded with whitespace. |
150
|
| '{' should be on the previous line. |
151
|
| Line is longer than 80 characters. |
152
|
| '(' is followed by whitespace. |
152
|
| ')' is preceded with whitespace. |
152
|
| 'if' is not followed by whitespace. |
158
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
158
|
| '{' should be on the previous line. |
159
|
| 'if' is not followed by whitespace. |
160
|
| '(' is followed by whitespace. |
160
|
| ')' is preceded with whitespace. |
160
|
| '{' should be on the previous line. |
161
|
| Line is longer than 80 characters. |
162
|
| '(' is followed by whitespace. |
162
|
| ')' is preceded with whitespace. |
162
|
| '}' should be on the same line. |
166
|
| '{' should be on the previous line. |
168
|
| 'if' is not followed by whitespace. |
172
|
| '(' is followed by whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| '{' should be on the previous line. |
173
|
| 'if' is not followed by whitespace. |
174
|
| '(' is followed by whitespace. |
174
|
| ')' is preceded with whitespace. |
174
|
| '{' should be on the previous line. |
175
|
| Line is longer than 80 characters. |
176
|
| '(' is followed by whitespace. |
176
|
| ')' is preceded with whitespace. |
176
|
| '}' should be on the same line. |
180
|
| '{' should be on the previous line. |
182
|
| 'if' is not followed by whitespace. |
183
|
| '(' is followed by whitespace. |
183
|
| ')' is preceded with whitespace. |
183
|
| '{' should be on the previous line. |
184
|
| 'if' is not followed by whitespace. |
185
|
| '(' is followed by whitespace. |
185
|
| ')' is preceded with whitespace. |
185
|
| '{' should be on the previous line. |
186
|
| Line is longer than 80 characters. |
187
|
| '(' is followed by whitespace. |
187
|
| '+' should be on a new line. |
187
|
| Line is longer than 80 characters. |
188
|
| ')' is preceded with whitespace. |
188
|
| '}' should be on the same line. |
192
|
| '{' should be on the previous line. |
194
|
| Line is longer than 80 characters. |
199
|
| 'if' is not followed by whitespace. |
200
|
| '(' is followed by whitespace. |
200
|
| ')' is preceded with whitespace. |
200
|
| '{' should be on the previous line. |
201
|
| Line is longer than 80 characters. |
205
|
| Line is longer than 80 characters. |
206
|
| 'if' is not followed by whitespace. |
208
|
| '(' is followed by whitespace. |
208
|
| ')' is preceded with whitespace. |
208
|
| '{' should be on the previous line. |
209
|
| 'if' is not followed by whitespace. |
212
|
| '(' is followed by whitespace. |
212
|
| ')' is preceded with whitespace. |
212
|
| '{' should be on the previous line. |
213
|
| Line is longer than 80 characters. |
214
|
| '(' is followed by whitespace. |
214
|
| '+' should be on a new line. |
214
|
| ')' is preceded with whitespace. |
215
|
| Line is longer than 80 characters. |
220
|
| ')' is preceded with whitespace. |
220
|
| Line is longer than 80 characters. |
221
|
| '(' is followed by whitespace. |
221
|
| '4' is a magic number. |
221
|
| ')' is preceded with whitespace. |
221
|
| '(' is followed by whitespace. |
223
|
| ')' is preceded with whitespace. |
223
|
| '{' should be on the previous line. |
226
|
| Line is longer than 80 characters. |
227
|
| '(' is followed by whitespace. |
227
|
| ')' is preceded with whitespace. |
227
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
| '(' is followed by whitespace. |
229
|
| ')' is preceded with whitespace. |
229
|
| '}' should be on the same line. |
231
|
| 'catch' is not followed by whitespace. |
232
|
| '(' is followed by whitespace. |
232
|
| ')' is preceded with whitespace. |
232
|
| '{' should be on the previous line. |
233
|
| 'if' is not followed by whitespace. |
234
|
| '(' is followed by whitespace. |
234
|
| ')' is preceded with whitespace. |
234
|
| '{' should be on the previous line. |
235
|
| '(' is followed by whitespace. |
236
|
| ')' is preceded with whitespace. |
236
|
| Line is longer than 80 characters. |
239
|
| '(' is followed by whitespace. |
239
|
| ')' is preceded with whitespace. |
239
|
| First sentence should end with a period. |
244
|
| Expected an @return tag. |
245
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
245
|
| Expected @throws tag for 'SQLException'. |
246
|
| '{' should be on the previous line. |
247
|
| '{' should be on the previous line. |
249
|
| 'cast' is not followed by whitespace. |
250
|
| '}' should be on the same line. |
251
|
| 'catch' is not followed by whitespace. |
252
|
| '(' is followed by whitespace. |
252
|
| ')' is preceded with whitespace. |
252
|
| '{' should be on the previous line. |
253
|
| 'if' is not followed by whitespace. |
254
|
| '(' is followed by whitespace. |
254
|
| ')' is preceded with whitespace. |
254
|
| '{' should be on the previous line. |
255
|
| '(' is followed by whitespace. |
256
|
| ')' is preceded with whitespace. |
256
|
| '}' should be on the same line. |
261
|
| 'catch' is not followed by whitespace. |
262
|
| '(' is followed by whitespace. |
262
|
| ')' is preceded with whitespace. |
262
|
| '{' should be on the previous line. |
263
|
| 'if' is not followed by whitespace. |
264
|
| '(' is followed by whitespace. |
264
|
| ')' is preceded with whitespace. |
264
|
| '{' should be on the previous line. |
265
|
| '(' is followed by whitespace. |
266
|
| ')' is preceded with whitespace. |
266
|
| '(' is followed by whitespace. |
269
|
| ')' is preceded with whitespace. |
269
|
| First sentence should end with a period. |
273
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
274
|
| '{' should be on the previous line. |
275
|
org/apache/avalon/excalibur/datasource/NoAvailableConnectionException.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
31
|
| Missing a Javadoc comment. |
33
|
| '{' should be on the previous line. |
34
|
| Missing a Javadoc comment. |
38
|
| '(' is followed by whitespace. |
38
|
| Parameter message should be final. |
38
|
| ')' is preceded with whitespace. |
38
|
| '{' should be on the previous line. |
39
|
| '(' is followed by whitespace. |
40
|
| ')' is preceded with whitespace. |
40
|
| Missing a Javadoc comment. |
43
|
| '(' is followed by whitespace. |
43
|
| Parameter message should be final. |
43
|
| Parameter SQLState should be final. |
43
|
| Name 'SQLState' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| ')' is preceded with whitespace. |
43
|
| '{' should be on the previous line. |
44
|
| '(' is followed by whitespace. |
45
|
| ')' is preceded with whitespace. |
45
|
| Line is longer than 80 characters. |
48
|
| Missing a Javadoc comment. |
48
|
| '(' is followed by whitespace. |
48
|
| Parameter message should be final. |
48
|
| Parameter SQLState should be final. |
48
|
| Name 'SQLState' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| Parameter vendorCode should be final. |
48
|
| ')' is preceded with whitespace. |
48
|
| '(' is followed by whitespace. |
50
|
| ')' is preceded with whitespace. |
50
|
org/apache/avalon/excalibur/datasource/NoValidConnectionException.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
31
|
| Missing a Javadoc comment. |
33
|
| '{' should be on the previous line. |
34
|
| Missing a Javadoc comment. |
38
|
| '(' is followed by whitespace. |
38
|
| Parameter message should be final. |
38
|
| ')' is preceded with whitespace. |
38
|
| '{' should be on the previous line. |
39
|
| '(' is followed by whitespace. |
40
|
| ')' is preceded with whitespace. |
40
|
| Missing a Javadoc comment. |
43
|
| '(' is followed by whitespace. |
43
|
| Parameter message should be final. |
43
|
| Parameter SQLState should be final. |
43
|
| Name 'SQLState' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| ')' is preceded with whitespace. |
43
|
| '{' should be on the previous line. |
44
|
| '(' is followed by whitespace. |
45
|
| ')' is preceded with whitespace. |
45
|
| Line is longer than 80 characters. |
48
|
| Missing a Javadoc comment. |
48
|
| '(' is followed by whitespace. |
48
|
| Parameter message should be final. |
48
|
| Parameter SQLState should be final. |
48
|
| Name 'SQLState' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| Parameter vendorCode should be final. |
48
|
| ')' is preceded with whitespace. |
48
|
| '(' is followed by whitespace. |
50
|
| ')' is preceded with whitespace. |
50
|
org/apache/avalon/excalibur/datasource/PoolSettable.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Unused import - java.sql.SQLException. |
20
|
| '{' should be on the previous line. |
32
|
| Line has trailing spaces. |
35
|
| '(' is followed by whitespace. |
38
|
| Expected @param tag for 'pool'. |
38
|
| ')' is preceded with whitespace. |
38
|
org/apache/avalon/excalibur/datasource/ProxiedJdbcConnection.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
24
|
| Line is longer than 80 characters. |
25
|
| '{' should be on the previous line. |
30
|
| Missing a Javadoc comment. |
31
|
| '(' is followed by whitespace. |
31
|
| ')' is preceded with whitespace. |
31
|
| Missing a Javadoc comment. |
33
|
org/apache/avalon/excalibur/datasource/ResourceLimitingJdbcConnectionPool.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
41
|
| Missing a Javadoc comment. |
42
|
| Name 'm_autoCommit' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| First sentence should end with a period. |
47
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
62
|
| Line is longer than 80 characters. |
63
|
| '(' is followed by whitespace. |
65
|
| Parameter max should be final. |
66
|
| Parameter maxStrict should be final. |
67
|
| Parameter blocking should be final. |
68
|
| Parameter blockTimeout should be final. |
69
|
| Parameter trimInterval should be final. |
70
|
| Parameter autoCommit should be final. |
71
|
| ')' is preceded with whitespace. |
71
|
| '{' should be on the previous line. |
72
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| Expected an @return tag. |
89
|
| Method 'newPoolable' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Expected @throws tag for 'Exception'. |
89
|
| '{' should be on the previous line. |
90
|
| Line has trailing spaces. |
92
|
| '(' is followed by whitespace. |
93
|
| ')' is preceded with whitespace. |
93
|
| '{' should be on the previous line. |
94
|
| Line has trailing spaces. |
97
|
| 'cast' is not followed by whitespace. |
98
|
| '(' is followed by whitespace. |
101
|
| ')' is preceded with whitespace. |
101
|
| 'cast' is not followed by whitespace. |
104
|
| '(' is followed by whitespace. |
104
|
| ')' is preceded with whitespace. |
104
|
| Line has trailing spaces. |
108
|
| Line is longer than 80 characters. |
110
|
| Line is longer than 80 characters. |
111
|
| Line is longer than 80 characters. |
116
|
| Method 'validatePoolable' is not designed for extension - needs to be abstract, final or empty. |
118
|
| '(' is followed by whitespace. |
118
|
| Parameter poolable should be final. |
118
|
| ')' is preceded with whitespace. |
118
|
| '{' should be on the previous line. |
119
|
| 'cast' is not followed by whitespace. |
120
|
| '{' should be on the previous line. |
122
|
| 'if' is not followed by whitespace. |
127
|
| '(' is followed by whitespace. |
127
|
| 'cast' is not followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| '{' should be on the previous line. |
128
|
| '(' is followed by whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| Line has trailing spaces. |
132
|
| Line is longer than 80 characters. |
133
|
| 'cast' is not followed by whitespace. |
135
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| '}' should be on the same line. |
136
|
| 'catch' is not followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| '{' should be on the previous line. |
138
|
| Line is longer than 80 characters. |
140
|
| ')' is preceded with whitespace. |
140
|
org/apache/avalon/excalibur/datasource/ResourceLimitingJdbcDataSource.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
71
|
| Line has trailing spaces. |
142
|
| '{' should be on the previous line. |
155
|
| Missing a Javadoc comment. |
156
|
| Name 'm_configured' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
156
|
| Missing a Javadoc comment. |
157
|
| Name 'm_disposed' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
157
|
| Missing a Javadoc comment. |
158
|
| Name 'm_pool' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
158
|
| Variable 'm_pool' must be private and have accessor methods. |
158
|
| Missing a Javadoc comment. |
163
|
| '{' should be on the previous line. |
164
|
| First sentence should end with a period. |
170
|
| Line is longer than 80 characters. |
173
|
| Unused @throws tag for 'NoValidConnectionException'. |
173
|
| Unused @throws tag for 'NoAvailableConnectionException'. |
176
|
| Expected an @return tag. |
179
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
179
|
| Expected @throws tag for 'SQLException'. |
180
|
| '{' should be on the previous line. |
181
|
| 'if' construct must use '{}'s. |
182
|
| 'if' is not followed by whitespace. |
182
|
| '(' is followed by whitespace. |
182
|
| ')' is preceded with whitespace. |
182
|
| '(' is followed by whitespace. |
182
|
| ')' is preceded with whitespace. |
182
|
| 'if' construct must use '{}'s. |
183
|
| 'if' is not followed by whitespace. |
183
|
| '(' is followed by whitespace. |
183
|
| ')' is preceded with whitespace. |
183
|
| '(' is followed by whitespace. |
183
|
| ')' is preceded with whitespace. |
183
|
| '{' should be on the previous line. |
187
|
| '{' should be on the previous line. |
190
|
| '}' should be on the same line. |
193
|
| 'catch' is not followed by whitespace. |
194
|
| '(' is followed by whitespace. |
194
|
| ')' is preceded with whitespace. |
194
|
| '{' should be on the previous line. |
195
|
| 'if' is not followed by whitespace. |
196
|
| '(' is followed by whitespace. |
196
|
| ')' is preceded with whitespace. |
196
|
| '{' should be on the previous line. |
197
|
| '(' is followed by whitespace. |
198
|
| ')' is preceded with whitespace. |
198
|
| '}' should be on the same line. |
202
|
| 'catch' is not followed by whitespace. |
203
|
| '(' is followed by whitespace. |
203
|
| ')' is preceded with whitespace. |
203
|
| '{' should be on the previous line. |
204
|
| 'if' is not followed by whitespace. |
205
|
| '(' is followed by whitespace. |
205
|
| ')' is preceded with whitespace. |
205
|
| '{' should be on the previous line. |
206
|
| '(' is followed by whitespace. |
207
|
| ')' is preceded with whitespace. |
207
|
| '(' is followed by whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| Line has trailing spaces. |
212
|
| 'cast' is not followed by whitespace. |
213
|
| Line is longer than 80 characters. |
226
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
226
|
| '(' is followed by whitespace. |
226
|
| Parameter configuration should be final. |
226
|
| ')' is preceded with whitespace. |
226
|
| Expected @throws tag for 'ConfigurationException'. |
226
|
| 'if' construct must use '{}'s. |
228
|
| Line is longer than 80 characters. |
228
|
| 'if' is not followed by whitespace. |
228
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
| '(' is followed by whitespace. |
230
|
| ')' is preceded with whitespace. |
230
|
| '(' is followed by whitespace. |
230
|
| ')' is preceded with whitespace. |
230
|
| '(' is followed by whitespace. |
231
|
| ')' is preceded with whitespace. |
231
|
| '(' is followed by whitespace. |
231
|
| ')' is preceded with whitespace. |
231
|
| '(' is followed by whitespace. |
232
|
| ')' is preceded with whitespace. |
232
|
| '(' is followed by whitespace. |
232
|
| ')' is preceded with whitespace. |
232
|
| Line is longer than 80 characters. |
233
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
| Line is longer than 80 characters. |
235
|
| '(' is followed by whitespace. |
235
|
| ')' is preceded with whitespace. |
235
|
| Line is longer than 80 characters. |
236
|
| '(' is followed by whitespace. |
236
|
| ')' is preceded with whitespace. |
236
|
| '(' is followed by whitespace. |
236
|
| '5000' is a magic number. |
236
|
| ')' is preceded with whitespace. |
236
|
| Line is longer than 80 characters. |
237
|
| '(' is followed by whitespace. |
237
|
| ')' is preceded with whitespace. |
237
|
| '(' is followed by whitespace. |
237
|
| ')' is preceded with whitespace. |
237
|
| Line is longer than 80 characters. |
239
|
| '(' is followed by whitespace. |
239
|
| ')' is preceded with whitespace. |
239
|
| '(' is followed by whitespace. |
239
|
| ')' is preceded with whitespace. |
239
|
| '(' is followed by whitespace. |
241
|
| '3' is a magic number. |
241
|
| ')' is preceded with whitespace. |
241
|
| Line is longer than 80 characters. |
242
|
| '(' is followed by whitespace. |
242
|
| ')' is preceded with whitespace. |
242
|
| Line is longer than 80 characters. |
243
|
| '(' is followed by whitespace. |
243
|
| ')' is preceded with whitespace. |
243
|
| '(' is followed by whitespace. |
244
|
| ')' is preceded with whitespace. |
244
|
| Line is longer than 80 characters. |
245
|
| '(' is followed by whitespace. |
245
|
| '60000' is a magic number. |
245
|
| ')' is preceded with whitespace. |
245
|
| Line is longer than 80 characters. |
246
|
| '(' is followed by whitespace. |
246
|
| ')' is preceded with whitespace. |
246
|
| Line is longer than 80 characters. |
248
|
| '(' is followed by whitespace. |
248
|
| ')' is preceded with whitespace. |
248
|
| '(' is followed by whitespace. |
248
|
| ')' is preceded with whitespace. |
248
|
| Line is longer than 80 characters. |
250
|
| '(' is followed by whitespace. |
250
|
| ')' is preceded with whitespace. |
250
|
| Name 'l_max' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
252
|
| 'if' is not followed by whitespace. |
255
|
| '(' is followed by whitespace. |
255
|
| '(' is followed by whitespace. |
255
|
| ')' is preceded with whitespace. |
255
|
| ')' is preceded with whitespace. |
255
|
| '{' should be on the previous line. |
256
|
| 'if' is not followed by whitespace. |
257
|
| '(' is followed by whitespace. |
257
|
| ')' is preceded with whitespace. |
257
|
| '{' should be on the previous line. |
258
|
| '(' is followed by whitespace. |
259
|
| ')' is preceded with whitespace. |
259
|
| '{' should be on the previous line. |
263
|
| Line is longer than 80 characters. |
264
|
| '(' is followed by whitespace. |
264
|
| ')' is preceded with whitespace. |
264
|
| '}' should be on the same line. |
265
|
| 'catch' is not followed by whitespace. |
266
|
| '(' is followed by whitespace. |
266
|
| ')' is preceded with whitespace. |
266
|
| '{' should be on the previous line. |
267
|
| 'if' is not followed by whitespace. |
268
|
| '(' is followed by whitespace. |
268
|
| ')' is preceded with whitespace. |
268
|
| '{' should be on the previous line. |
269
|
| Line is longer than 80 characters. |
270
|
| '(' is followed by whitespace. |
270
|
| ')' is preceded with whitespace. |
270
|
| 'if' is not followed by whitespace. |
276
|
| '(' is followed by whitespace. |
276
|
| ')' is preceded with whitespace. |
276
|
| '{' should be on the previous line. |
277
|
| 'if' is not followed by whitespace. |
278
|
| '(' is followed by whitespace. |
278
|
| ')' is preceded with whitespace. |
278
|
| '{' should be on the previous line. |
279
|
| Line is longer than 80 characters. |
280
|
| '(' is followed by whitespace. |
280
|
| ')' is preceded with whitespace. |
280
|
| '}' should be on the same line. |
284
|
| '{' should be on the previous line. |
286
|
| Line is longer than 80 characters. |
290
|
| 'if' is not followed by whitespace. |
292
|
| '(' is followed by whitespace. |
292
|
| ')' is preceded with whitespace. |
292
|
| '{' should be on the previous line. |
293
|
| 'if' is not followed by whitespace. |
300
|
| '(' is followed by whitespace. |
300
|
| ')' is preceded with whitespace. |
300
|
| '{' should be on the previous line. |
301
|
| 'if' is not followed by whitespace. |
304
|
| '(' is followed by whitespace. |
304
|
| ')' is preceded with whitespace. |
304
|
| '{' should be on the previous line. |
305
|
| Line is longer than 80 characters. |
306
|
| '(' is followed by whitespace. |
306
|
| '+' should be on a new line. |
306
|
| ')' is preceded with whitespace. |
307
|
| Line is longer than 80 characters. |
312
|
| '(' is followed by whitespace. |
312
|
| ')' is preceded with whitespace. |
312
|
| '(' is followed by whitespace. |
314
|
| ')' is preceded with whitespace. |
314
|
| '{' should be on the previous line. |
317
|
| Line is longer than 80 characters. |
319
|
| ')' is preceded with whitespace. |
319
|
| '(' is followed by whitespace. |
321
|
| ')' is preceded with whitespace. |
321
|
| Line has trailing spaces. |
322
|
| '(' is followed by whitespace. |
323
|
| ')' is preceded with whitespace. |
323
|
| '}' should be on the same line. |
324
|
| 'catch' is not followed by whitespace. |
325
|
| '(' is followed by whitespace. |
325
|
| ')' is preceded with whitespace. |
325
|
| '{' should be on the previous line. |
326
|
| 'if' is not followed by whitespace. |
327
|
| '(' is followed by whitespace. |
327
|
| ')' is preceded with whitespace. |
327
|
| '{' should be on the previous line. |
328
|
| Line is longer than 80 characters. |
329
|
| '(' is followed by whitespace. |
329
|
| ')' is preceded with whitespace. |
329
|
| Line is longer than 80 characters. |
332
|
| '(' is followed by whitespace. |
332
|
| ')' is preceded with whitespace. |
332
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
347
|
| '{' should be on the previous line. |
348
|
org/apache/avalon/excalibur/datasource/cluster/AbstractDataSourceCluster.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Missing a Javadoc comment. |
46
|
| Name 'm_size' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
46
|
| Variable 'm_size' must be private and have accessor methods. |
46
|
| Missing a Javadoc comment. |
47
|
| Name 'm_dataSourceNames' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
47
|
| Missing a Javadoc comment. |
48
|
| Name 'm_dbSelector' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| Missing a Javadoc comment. |
49
|
| Name 'm_dataSources' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
| Missing a Javadoc comment. |
54
|
| '{' should be on the previous line. |
55
|
| Method 'getClusterSize' is not designed for extension - needs to be abstract, final or empty. |
66
|
| '{' should be on the previous line. |
67
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
76
|
| Unused @throws tag for 'NoValidConnectionException'. |
76
|
| Unused @throws tag for 'NoValidConnectionException'. |
79
|
| Expected an @return tag. |
82
|
| Method 'getConnectionForIndex' is not designed for extension - needs to be abstract, final or empty. |
82
|
| '(' is followed by whitespace. |
82
|
| Parameter index should be final. |
82
|
| ')' is preceded with whitespace. |
82
|
| Expected @throws tag for 'SQLException'. |
82
|
| '{' should be on the previous line. |
83
|
| 'if' is not followed by whitespace. |
84
|
| '(' is followed by whitespace. |
84
|
| '(' is followed by whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
| '(' is followed by whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
| '{' should be on the previous line. |
85
|
| Line is longer than 80 characters. |
87
|
| '(' is followed by whitespace. |
87
|
| ')' is preceded with whitespace. |
87
|
| ')' is preceded with whitespace. |
87
|
| Line is longer than 80 characters. |
100
|
| Method 'service' is not designed for extension - needs to be abstract, final or empty. |
102
|
| '(' is followed by whitespace. |
102
|
| ')' is preceded with whitespace. |
102
|
| Expected @throws tag for 'ServiceException'. |
103
|
| '{' should be on the previous line. |
104
|
| Line is longer than 80 characters. |
106
|
| 'cast' is not followed by whitespace. |
106
|
| '(' is followed by whitespace. |
106
|
| ')' is preceded with whitespace. |
106
|
| Line is longer than 80 characters. |
117
|
| Line is longer than 80 characters. |
119
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
119
|
| '(' is followed by whitespace. |
119
|
| Parameter configuration should be final. |
119
|
| ')' is preceded with whitespace. |
119
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| 'if' is not followed by whitespace. |
123
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| '{' should be on the previous line. |
124
|
| ')' is preceded with whitespace. |
126
|
| Line is longer than 80 characters. |
131
|
| '(' is followed by whitespace. |
131
|
| ')' is preceded with whitespace. |
131
|
| 'for' is not followed by whitespace. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| '{' should be on the previous line. |
133
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| 'if' is not followed by whitespace. |
135
|
| '(' is followed by whitespace. |
135
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| '{' should be on the previous line. |
136
|
| Line is longer than 80 characters. |
137
|
| '(' is followed by whitespace. |
137
|
| '+' should be on a new line. |
137
|
| Line is longer than 80 characters. |
138
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| 'if' is not followed by whitespace. |
140
|
| '(' is followed by whitespace. |
140
|
| ')' is preceded with whitespace. |
140
|
| '{' should be on the previous line. |
141
|
| Line is longer than 80 characters. |
142
|
| '(' is followed by whitespace. |
142
|
| '+' should be on a new line. |
142
|
| ')' is preceded with whitespace. |
143
|
| 'for' is not followed by whitespace. |
149
|
| '(' is followed by whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| '{' should be on the previous line. |
150
|
| 'if' is not followed by whitespace. |
151
|
| '(' is followed by whitespace. |
151
|
| ')' is preceded with whitespace. |
151
|
| '{' should be on the previous line. |
152
|
| Line is longer than 80 characters. |
153
|
| '(' is followed by whitespace. |
153
|
| ')' is preceded with whitespace. |
153
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
166
|
| '{' should be on the previous line. |
167
|
| 'for' is not followed by whitespace. |
170
|
| '(' is followed by whitespace. |
170
|
| ')' is preceded with whitespace. |
170
|
| '{' should be on the previous line. |
171
|
| Line is longer than 80 characters. |
172
|
| 'cast' is not followed by whitespace. |
172
|
| '(' is followed by whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
182
|
| '{' should be on the previous line. |
183
|
| 'if' is not followed by whitespace. |
185
|
| '(' is followed by whitespace. |
185
|
| ')' is preceded with whitespace. |
185
|
| '{' should be on the previous line. |
186
|
| 'if' is not followed by whitespace. |
187
|
| '(' is followed by whitespace. |
187
|
| ')' is preceded with whitespace. |
187
|
| '{' should be on the previous line. |
188
|
| 'for' is not followed by whitespace. |
189
|
| '(' is followed by whitespace. |
189
|
| ')' is preceded with whitespace. |
189
|
| '{' should be on the previous line. |
190
|
| 'if' is not followed by whitespace. |
191
|
| '(' is followed by whitespace. |
191
|
| ')' is preceded with whitespace. |
191
|
| '{' should be on the previous line. |
192
|
| '(' is followed by whitespace. |
193
|
| ')' is preceded with whitespace. |
193
|
org/apache/avalon/excalibur/datasource/cluster/DefaultHashedDataSourceCluster.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
27
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
29
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
77
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
86
|
| Line is longer than 80 characters. |
89
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
93
|
| Line is longer than 80 characters. |
94
|
| Line is longer than 80 characters. |
107
|
| Line has trailing spaces. |
114
|
| Line is longer than 80 characters. |
116
|
| '{' should be on the previous line. |
128
|
| Missing a Javadoc comment. |
132
|
| '{' should be on the previous line. |
133
|
| Line is longer than 80 characters. |
140
|
| Expected an @return tag. |
142
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Expected @throws tag for 'SQLException'. |
142
|
| '{' should be on the previous line. |
143
|
| Line is longer than 80 characters. |
145
|
| '+' should be on a new line. |
145
|
| ')' is preceded with whitespace. |
146
|
| Line is longer than 80 characters. |
158
|
| Line is longer than 80 characters. |
161
|
| Unused @throws tag for 'NoValidConnectionException'. |
161
|
| Unused @throws tag for 'NoValidConnectionException'. |
164
|
| Expected an @return tag. |
167
|
| Line is longer than 80 characters. |
167
|
| Method 'getConnectionForHashObject' is not designed for extension - needs to be abstract, final or empty. |
167
|
| '(' is followed by whitespace. |
167
|
| Parameter hashObject should be final. |
167
|
| ')' is preceded with whitespace. |
167
|
| Expected @throws tag for 'SQLException'. |
167
|
| '(' is followed by whitespace. |
169
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| Line is longer than 80 characters. |
175
|
| Line is longer than 80 characters. |
178
|
| Unused @throws tag for 'NoValidConnectionException'. |
178
|
| Unused @throws tag for 'NoValidConnectionException'. |
181
|
| Expected an @return tag. |
184
|
| Line is longer than 80 characters. |
184
|
| Method 'getConnectionForHashCode' is not designed for extension - needs to be abstract, final or empty. |
184
|
| '(' is followed by whitespace. |
184
|
| Parameter hashCode should be final. |
184
|
| ')' is preceded with whitespace. |
184
|
| Expected @throws tag for 'SQLException'. |
184
|
| '(' is followed by whitespace. |
186
|
| '(' is followed by whitespace. |
186
|
| ')' is preceded with whitespace. |
186
|
| ')' is preceded with whitespace. |
186
|
| Line is longer than 80 characters. |
193
|
| Line is longer than 80 characters. |
200
|
| Expected an @return tag. |
203
|
| Method 'getIndexForHashObject' is not designed for extension - needs to be abstract, final or empty. |
203
|
| '(' is followed by whitespace. |
203
|
| Parameter hashObject should be final. |
203
|
| ')' is preceded with whitespace. |
203
|
| '{' should be on the previous line. |
204
|
| '(' is followed by whitespace. |
205
|
| ')' is preceded with whitespace. |
205
|
| Line is longer than 80 characters. |
209
|
| Line is longer than 80 characters. |
216
|
| Expected an @return tag. |
219
|
| Method 'getIndexForHashCode' is not designed for extension - needs to be abstract, final or empty. |
219
|
| '(' is followed by whitespace. |
219
|
| Parameter hashCode should be final. |
219
|
| ')' is preceded with whitespace. |
219
|
| '{' should be on the previous line. |
220
|
| Line is longer than 80 characters. |
225
|
| '(' is followed by whitespace. |
226
|
| 'cast' is not followed by whitespace. |
226
|
| ')' is preceded with whitespace. |
226
|
| '0xffffffffL' is a magic number. |
226
|
| 'cast' is not followed by whitespace. |
228
|
| '(' is followed by whitespace. |
228
|
| ')' is preceded with whitespace. |
228
|
org/apache/avalon/excalibur/datasource/cluster/DefaultIndexedDataSourceCluster.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
27
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
83
|
| Line is longer than 80 characters. |
84
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
101
|
| Line has trailing spaces. |
108
|
| Line is longer than 80 characters. |
110
|
| '{' should be on the previous line. |
122
|
| Missing a Javadoc comment. |
127
|
| '{' should be on the previous line. |
128
|
| Line is longer than 80 characters. |
135
|
| Expected an @return tag. |
137
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
137
|
| Expected @throws tag for 'SQLException'. |
137
|
| '{' should be on the previous line. |
138
|
| Line is longer than 80 characters. |
140
|
| '+' should be on a new line. |
140
|
| ')' is preceded with whitespace. |
141
|
org/apache/avalon/excalibur/datasource/cluster/DefaultRoundRobinDataSourceCluster.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
24
|
| Line is longer than 80 characters. |
25
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
29
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
78
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line has trailing spaces. |
83
|
| Line is longer than 80 characters. |
85
|
| '{' should be on the previous line. |
97
|
| Missing a Javadoc comment. |
98
|
| Name 'm_semaphore' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
98
|
| Missing a Javadoc comment. |
99
|
| Name 'm_nextIndex' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
99
|
| Missing a Javadoc comment. |
104
|
| '{' should be on the previous line. |
105
|
| Line is longer than 80 characters. |
114
|
| Unused @throws tag for 'NoValidConnectionException'. |
114
|
| Unused @throws tag for 'NoValidConnectionException'. |
117
|
| Expected an @return tag. |
120
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Expected @throws tag for 'SQLException'. |
120
|
| '{' should be on the previous line. |
121
|
| 'synchronized' is not followed by whitespace. |
123
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| '{' should be on the previous line. |
124
|
| 'if' is not followed by whitespace. |
126
|
| '(' is followed by whitespace. |
126
|
| '(' is followed by whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| '{' should be on the previous line. |
127
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
org/apache/avalon/excalibur/datasource/cluster/HashedDataSourceCluster.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
32
|
| First sentence should end with a period. |
33
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
51
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoValidConnectionException'. |
51
|
| Line is longer than 80 characters. |
54
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoAvailableConnectionException'. |
54
|
| Expected an @return tag. |
57
|
| Line is longer than 80 characters. |
57
|
| '(' is followed by whitespace. |
57
|
| ')' is preceded with whitespace. |
57
|
| Expected @throws tag for 'SQLException'. |
57
|
| Line is longer than 80 characters. |
62
|
| Line is longer than 80 characters. |
65
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoValidConnectionException'. |
65
|
| Line is longer than 80 characters. |
68
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoAvailableConnectionException'. |
68
|
| Expected an @return tag. |
71
|
| '(' is followed by whitespace. |
71
|
| ')' is preceded with whitespace. |
71
|
| Expected @throws tag for 'SQLException'. |
71
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
78
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoValidConnectionException'. |
78
|
| Line is longer than 80 characters. |
81
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoAvailableConnectionException'. |
81
|
| Expected an @return tag. |
84
|
| '(' is followed by whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
| Expected @throws tag for 'SQLException'. |
84
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
90
|
| Expected an @return tag. |
93
|
| '(' is followed by whitespace. |
93
|
| ')' is preceded with whitespace. |
93
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
99
|
| Expected an @return tag. |
102
|
| '(' is followed by whitespace. |
102
|
| ')' is preceded with whitespace. |
102
|
org/apache/avalon/excalibur/datasource/cluster/IndexedDataSourceCluster.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
32
|
| First sentence should end with a period. |
33
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
50
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoValidConnectionException'. |
50
|
| Line is longer than 80 characters. |
53
|
| Unused @throws tag for 'org.apache.avalon.excalibur.datasource.NoAvailableConnectionException'. |
53
|
| Expected an @return tag. |
56
|
| '(' is followed by whitespace. |
56
|
| ')' is preceded with whitespace. |
56
|
| Expected @throws tag for 'SQLException'. |
56
|
org/apache/avalon/excalibur/datasource/cluster/RoundRobinDataSourceCluster.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| interfaces should describe a type and hence have methods. |
27
|
| '{' should be on the previous line. |
29
|
| First sentence should end with a period. |
30
|
org/apache/avalon/excalibur/datasource/cluster/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/apache/avalon/excalibur/datasource/ids/AbstractDataSourceBlockIdGenerator.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
27
|
| '{' should be on the previous line. |
36
|
| Name 'm_firstBigDecimal' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
40
|
| Name 'm_firstLong' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Name 'm_blockSize' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
50
|
| Name 'm_allocated' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
55
|
| Missing a Javadoc comment. |
60
|
| '{' should be on the previous line. |
61
|
| Line is longer than 80 characters. |
74
|
| '(' is followed by whitespace. |
76
|
| Parameter blockSize should be final. |
76
|
| ')' is preceded with whitespace. |
76
|
| Line is longer than 80 characters. |
86
|
| '(' is followed by whitespace. |
88
|
| Parameter blockSize should be final. |
88
|
| ')' is preceded with whitespace. |
88
|
| Method 'getNextBigDecimalIdInner' is not designed for extension - needs to be abstract, final or empty. |
102
|
| '{' should be on the previous line. |
104
|
| 'if' is not followed by whitespace. |
105
|
| '(' is followed by whitespace. |
105
|
| ')' is preceded with whitespace. |
105
|
| '{' should be on the previous line. |
106
|
| '{' should be on the previous line. |
109
|
| '(' is followed by whitespace. |
110
|
| ')' is preceded with whitespace. |
110
|
| '}' should be on the same line. |
114
|
| 'catch' is not followed by whitespace. |
115
|
| '(' is followed by whitespace. |
115
|
| ')' is preceded with whitespace. |
115
|
| '{' should be on the previous line. |
116
|
| Line is longer than 80 characters. |
117
|
| '(' is followed by whitespace. |
125
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| Method 'getNextLongIdInner' is not designed for extension - needs to be abstract, final or empty. |
139
|
| '{' should be on the previous line. |
141
|
| 'if' is not followed by whitespace. |
142
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| '{' should be on the previous line. |
143
|
| '{' should be on the previous line. |
146
|
| '(' is followed by whitespace. |
147
|
| ')' is preceded with whitespace. |
147
|
| '}' should be on the same line. |
151
|
| 'catch' is not followed by whitespace. |
152
|
| '(' is followed by whitespace. |
152
|
| ')' is preceded with whitespace. |
152
|
| '{' should be on the previous line. |
153
|
| Line is longer than 80 characters. |
154
|
| 'if' is not followed by whitespace. |
163
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| '{' should be on the previous line. |
164
|
| Line is longer than 80 characters. |
166
|
| '(' is followed by whitespace. |
167
|
| ')' is preceded with whitespace. |
167
|
| '(' is followed by whitespace. |
168
|
| ')' is preceded with whitespace. |
168
|
| Line is longer than 80 characters. |
183
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
185
|
| '(' is followed by whitespace. |
185
|
| Parameter configuration should be final. |
185
|
| ')' is preceded with whitespace. |
185
|
| '{' should be on the previous line. |
187
|
| '(' is followed by whitespace. |
188
|
| ')' is preceded with whitespace. |
188
|
| '(' is followed by whitespace. |
191
|
| '10' is a magic number. |
191
|
| ')' is preceded with whitespace. |
191
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
202
|
| '{' should be on the previous line. |
204
|
| Line is longer than 80 characters. |
207
|
org/apache/avalon/excalibur/datasource/ids/AbstractDataSourceIdGenerator.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
42
|
| Missing a Javadoc comment. |
43
|
| Name 'm_dataSourceName' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Missing a Javadoc comment. |
44
|
| Name 'm_dbSelector' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_dataSource' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Variable 'm_dataSource' must be private and have accessor methods. |
45
|
| Name 'm_allocated' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
50
|
| Variable 'm_allocated' must be private and have accessor methods. |
50
|
| Missing a Javadoc comment. |
51
|
| Name 'm_nextId' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
51
|
| Variable 'm_nextId' must be private and have accessor methods. |
51
|
| Missing a Javadoc comment. |
56
|
| '{' should be on the previous line. |
57
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
69
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
71
|
| '{' should be on the previous line. |
73
|
| Line is longer than 80 characters. |
85
|
| Method 'service' is not designed for extension - needs to be abstract, final or empty. |
87
|
| '(' is followed by whitespace. |
87
|
| ')' is preceded with whitespace. |
87
|
| Expected @throws tag for 'ServiceException'. |
88
|
| '{' should be on the previous line. |
89
|
| Line is longer than 80 characters. |
90
|
| 'cast' is not followed by whitespace. |
90
|
| '(' is followed by whitespace. |
90
|
| ')' is preceded with whitespace. |
90
|
| Line is longer than 80 characters. |
101
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
103
|
| '(' is followed by whitespace. |
103
|
| Parameter configuration should be final. |
103
|
| ')' is preceded with whitespace. |
103
|
| '{' should be on the previous line. |
105
|
| Line is longer than 80 characters. |
107
|
| '(' is followed by whitespace. |
107
|
| '(' is followed by whitespace. |
107
|
| ')' is preceded with whitespace. |
107
|
| ')' is preceded with whitespace. |
107
|
| '(' is followed by whitespace. |
110
|
| ')' is preceded with whitespace. |
110
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
121
|
| '{' should be on the previous line. |
123
|
| Line is longer than 80 characters. |
125
|
| 'cast' is not followed by whitespace. |
125
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
134
|
| '{' should be on the previous line. |
135
|
| 'if' is not followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| '{' should be on the previous line. |
138
|
| 'if' is not followed by whitespace. |
139
|
| '(' is followed by whitespace. |
139
|
| ')' is preceded with whitespace. |
139
|
| '{' should be on the previous line. |
140
|
| '(' is followed by whitespace. |
141
|
| ')' is preceded with whitespace. |
141
|
org/apache/avalon/excalibur/datasource/ids/AbstractIdGenerator.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
33
|
| Line is longer than 80 characters. |
34
|
| Missing a Javadoc comment. |
34
|
| '(' is followed by whitespace. |
34
|
| ')' is preceded with whitespace. |
34
|
| Name 'm_semaphore' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
39
|
| Name 'm_useBigDecimals' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
49
|
| '{' should be on the previous line. |
50
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
82
|
| '(' is followed by whitespace. |
86
|
| Parameter useBigDecimals should be final. |
86
|
| ')' is preceded with whitespace. |
86
|
| '{' should be on the previous line. |
87
|
| Line is longer than 80 characters. |
92
|
| Expected an @return tag. |
94
|
| '{' should be on the previous line. |
95
|
| Line is longer than 80 characters. |
100
|
| Expected an @return tag. |
104
|
| '(' is followed by whitespace. |
104
|
| Parameter maxId should be final. |
104
|
| Expected @param tag for 'maxId'. |
104
|
| ')' is preceded with whitespace. |
104
|
| '{' should be on the previous line. |
106
|
| 'if' is not followed by whitespace. |
108
|
| '(' is followed by whitespace. |
108
|
| ')' is preceded with whitespace. |
108
|
| '{' should be on the previous line. |
109
|
| 'synchronized' is not followed by whitespace. |
112
|
| '(' is followed by whitespace. |
112
|
| ')' is preceded with whitespace. |
112
|
| '{' should be on the previous line. |
113
|
| Line is longer than 80 characters. |
117
|
| 'if' is not followed by whitespace. |
118
|
| '(' is followed by whitespace. |
118
|
| '(' is followed by whitespace. |
118
|
| ')' is preceded with whitespace. |
118
|
| ')' is preceded with whitespace. |
118
|
| '{' should be on the previous line. |
119
|
| '+' should be on a new line. |
120
|
| '(' is followed by whitespace. |
122
|
| ')' is preceded with whitespace. |
122
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| '}' should be on the same line. |
126
|
| '{' should be on the previous line. |
128
|
| 'synchronized' is not followed by whitespace. |
130
|
| '(' is followed by whitespace. |
130
|
| ')' is preceded with whitespace. |
130
|
| '{' should be on the previous line. |
131
|
| 'if' is not followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| '{' should be on the previous line. |
138
|
| '+' should be on a new line. |
139
|
| '(' is followed by whitespace. |
141
|
| ')' is preceded with whitespace. |
141
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| Expected @throws tag for 'IdException'. |
157
|
| '{' should be on the previous line. |
158
|
| 'if' is not followed by whitespace. |
160
|
| '(' is followed by whitespace. |
160
|
| ')' is preceded with whitespace. |
160
|
| '{' should be on the previous line. |
161
|
| 'synchronized' is not followed by whitespace. |
163
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| '{' should be on the previous line. |
164
|
| '}' should be on the same line. |
167
|
| '{' should be on the previous line. |
169
|
| 'synchronized' is not followed by whitespace. |
171
|
| '(' is followed by whitespace. |
171
|
| ')' is preceded with whitespace. |
171
|
| '{' should be on the previous line. |
172
|
| '(' is followed by whitespace. |
173
|
| ')' is preceded with whitespace. |
173
|
| Line is longer than 80 characters. |
185
|
| '{' should be on the previous line. |
189
|
| '(' is followed by whitespace. |
190
|
| ')' is preceded with whitespace. |
190
|
| Line is longer than 80 characters. |
198
|
| '{' should be on the previous line. |
202
|
| 'cast' is not followed by whitespace. |
203
|
| '(' is followed by whitespace. |
203
|
| ')' is preceded with whitespace. |
203
|
| Line is longer than 80 characters. |
211
|
| '{' should be on the previous line. |
215
|
| 'cast' is not followed by whitespace. |
216
|
| '(' is followed by whitespace. |
216
|
| ')' is preceded with whitespace. |
216
|
| Line is longer than 80 characters. |
224
|
| '{' should be on the previous line. |
228
|
| 'cast' is not followed by whitespace. |
229
|
| '(' is followed by whitespace. |
229
|
| ')' is preceded with whitespace. |
229
|
org/apache/avalon/excalibur/datasource/ids/IdException.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
31
|
| '(' is followed by whitespace. |
40
|
| Parameter message should be final. |
40
|
| ')' is preceded with whitespace. |
40
|
| '{' should be on the previous line. |
41
|
| '(' is followed by whitespace. |
42
|
| ')' is preceded with whitespace. |
42
|
| '(' is followed by whitespace. |
51
|
| Parameter message should be final. |
51
|
| Parameter throwable should be final. |
51
|
| ')' is preceded with whitespace. |
51
|
| '{' should be on the previous line. |
52
|
| '(' is followed by whitespace. |
53
|
| ')' is preceded with whitespace. |
53
|
org/apache/avalon/excalibur/datasource/ids/IdGenerator.java
Error | Line |
| Line has trailing spaces. |
1
|
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line has trailing spaces. |
25
|
| '{' should be on the previous line. |
32
|
| First sentence should end with a period. |
33
|
| Expected @throws tag for 'IdException'. |
44
|
| Line is longer than 80 characters. |
51
|
| Unused @throws tag for 'IllegalStateException'. |
51
|
| Expected @throws tag for 'IdException'. |
54
|
| Line is longer than 80 characters. |
61
|
| Unused @throws tag for 'IllegalStateException'. |
61
|
| Expected @throws tag for 'IdException'. |
64
|
| Line is longer than 80 characters. |
71
|
| Unused @throws tag for 'IllegalStateException'. |
71
|
| Expected @throws tag for 'IdException'. |
74
|
| Line is longer than 80 characters. |
81
|
| Unused @throws tag for 'IllegalStateException'. |
81
|
| Expected @throws tag for 'IdException'. |
84
|
org/apache/avalon/excalibur/datasource/ids/SequenceIdGenerator.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
76
|
| Line has trailing spaces. |
78
|
| '{' should be on the previous line. |
90
|
| Missing a Javadoc comment. |
91
|
| Name 'm_query' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
91
|
| Missing a Javadoc comment. |
96
|
| '{' should be on the previous line. |
97
|
| Method 'getNextBigDecimalIdInner' is not designed for extension - needs to be abstract, final or empty. |
111
|
| '{' should be on the previous line. |
113
|
| 'if' is not followed by whitespace. |
114
|
| '(' is followed by whitespace. |
114
|
| ')' is preceded with whitespace. |
114
|
| '{' should be on the previous line. |
115
|
| '(' is followed by whitespace. |
116
|
| ')' is preceded with whitespace. |
116
|
| '{' should be on the previous line. |
120
|
| '{' should be on the previous line. |
123
|
| '(' is followed by whitespace. |
124
|
| ')' is preceded with whitespace. |
124
|
| 'if' is not followed by whitespace. |
126
|
| '(' is followed by whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| '{' should be on the previous line. |
127
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| '}' should be on the same line. |
129
|
| '{' should be on the previous line. |
131
|
| '(' is followed by whitespace. |
133
|
| ')' is preceded with whitespace. |
133
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '}' should be on the same line. |
136
|
| '{' should be on the previous line. |
138
|
| '}' should be on the same line. |
141
|
| 'catch' is not followed by whitespace. |
142
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| '{' should be on the previous line. |
143
|
| '(' is followed by whitespace. |
145
|
| ')' is preceded with whitespace. |
145
|
| '(' is followed by whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| Method 'getNextLongIdInner' is not designed for extension - needs to be abstract, final or empty. |
158
|
| '{' should be on the previous line. |
160
|
| 'if' is not followed by whitespace. |
161
|
| '(' is followed by whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| '{' should be on the previous line. |
162
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| '{' should be on the previous line. |
167
|
| '{' should be on the previous line. |
170
|
| '(' is followed by whitespace. |
171
|
| ')' is preceded with whitespace. |
171
|
| 'if' is not followed by whitespace. |
173
|
| '(' is followed by whitespace. |
173
|
| ')' is preceded with whitespace. |
173
|
| '{' should be on the previous line. |
174
|
| '(' is followed by whitespace. |
175
|
| ')' is preceded with whitespace. |
175
|
| '}' should be on the same line. |
176
|
| '{' should be on the previous line. |
178
|
| '(' is followed by whitespace. |
180
|
| ')' is preceded with whitespace. |
180
|
| '(' is followed by whitespace. |
181
|
| ')' is preceded with whitespace. |
181
|
| '}' should be on the same line. |
183
|
| '{' should be on the previous line. |
185
|
| '}' should be on the same line. |
188
|
| 'catch' is not followed by whitespace. |
189
|
| '(' is followed by whitespace. |
189
|
| ')' is preceded with whitespace. |
189
|
| '{' should be on the previous line. |
190
|
| '(' is followed by whitespace. |
192
|
| ')' is preceded with whitespace. |
192
|
| '(' is followed by whitespace. |
193
|
| ')' is preceded with whitespace. |
193
|
| Line is longer than 80 characters. |
205
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
207
|
| '(' is followed by whitespace. |
207
|
| Parameter configuration should be final. |
207
|
| ')' is preceded with whitespace. |
207
|
| '{' should be on the previous line. |
209
|
| '(' is followed by whitespace. |
210
|
| ')' is preceded with whitespace. |
210
|
| '(' is followed by whitespace. |
213
|
| ')' is preceded with whitespace. |
213
|
org/apache/avalon/excalibur/datasource/ids/TableIdGenerator.java
Error | Line |
| Line does not match expected header line of ''. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
43
|
| Line is longer than 80 characters. |
44
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
71
|
| Line has trailing spaces. |
79
|
| '{' should be on the previous line. |
91
|
| Name 'm_table' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
95
|
| Name 'm_tableName' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
100
|
| Missing a Javadoc comment. |
105
|
| '{' should be on the previous line. |
106
|
| Line is longer than 80 characters. |
116
|
| Line is longer than 80 characters. |
118
|
| '(' is followed by whitespace. |
122
|
| Parameter blockSize should be final. |
122
|
| Parameter useBigDecimals should be final. |
122
|
| ')' is preceded with whitespace. |
122
|
| '{' should be on the previous line. |
124
|
| 'if' is not followed by whitespace. |
125
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| '{' should be on the previous line. |
126
|
| '(' is followed by whitespace. |
127
|
| '+' should be on a new line. |
127
|
| ')' is preceded with whitespace. |
128
|
| '{' should be on the previous line. |
132
|
| '{' should be on the previous line. |
135
|
| Line has trailing spaces. |
137
|
| '{' should be on the previous line. |
140
|
| Line is longer than 80 characters. |
141
|
| Line is longer than 80 characters. |
142
|
| 'while' is not followed by whitespace. |
145
|
| '(' is followed by whitespace. |
145
|
| '50' is a magic number. |
145
|
| ')' is preceded with whitespace. |
145
|
| '{' should be on the previous line. |
146
|
| Line is longer than 80 characters. |
148
|
| '(' is followed by whitespace. |
150
|
| ')' is preceded with whitespace. |
150
|
| '(' is followed by whitespace. |
151
|
| ')' is preceded with whitespace. |
151
|
| '{' should be on the previous line. |
152
|
| Line is longer than 80 characters. |
155
|
| Line is longer than 80 characters. |
156
|
| '(' is followed by whitespace. |
157
|
| ')' is preceded with whitespace. |
157
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
158
|
| '{' should be on the previous line. |
159
|
| '(' is followed by whitespace. |
163
|
| ')' is preceded with whitespace. |
163
|
| Line has trailing spaces. |
165
|
| 'if' is not followed by whitespace. |
169
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| '{' should be on the previous line. |
170
|
| '(' is followed by whitespace. |
171
|
| ')' is preceded with whitespace. |
171
|
| Line is longer than 80 characters. |
172
|
| '(' is followed by whitespace. |
172
|
| '(' is followed by whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| '}' should be on the same line. |
174
|
| '{' should be on the previous line. |
176
|
| '(' is followed by whitespace. |
177
|
| ')' is preceded with whitespace. |
177
|
| '(' is followed by whitespace. |
178
|
| ')' is preceded with whitespace. |
178
|
| '(' is followed by whitespace. |
179
|
| ')' is preceded with whitespace. |
179
|
| Line has trailing spaces. |
181
|
| Line is longer than 80 characters. |
182
|
| Line is longer than 80 characters. |
183
|
| Line is longer than 80 characters. |
184
|
| Line is longer than 80 characters. |
185
|
| '{' should be on the previous line. |
187
|
| Line is longer than 80 characters. |
188
|
| '(' is followed by whitespace. |
194
|
| ')' is preceded with whitespace. |
194
|
| 'if' is not followed by whitespace. |
195
|
| '(' is followed by whitespace. |
195
|
| ')' is preceded with whitespace. |
195
|
| '{' should be on the previous line. |
196
|
| '(' is followed by whitespace. |
198
|
| ')' is preceded with whitespace. |
198
|
| '{' should be on the previous line. |
199
|
| '}' should be on the same line. |
205
|
| '{' should be on the previous line. |
207
|
| Line is longer than 80 characters. |
208
|
| 'if' is not followed by whitespace. |
209
|
| '(' is followed by whitespace. |
209
|
| ')' is preceded with whitespace. |
209
|
| '{' should be on the previous line. |
210
|
| Line is longer than 80 characters. |
212
|
| ')' is preceded with whitespace. |
212
|
| '}' should be on the same line. |
215
|
| '(' is followed by whitespace. |
216
|
| ')' is preceded with whitespace. |
216
|
| '{' should be on the previous line. |
217
|
| Line is longer than 80 characters. |
218
|
| 'if' is not followed by whitespace. |
219
|
| '(' is followed by whitespace. |
219
|
| ')' is preceded with whitespace. |
219
|
| '{' should be on the previous line. |
220
|
| Line is longer than 80 characters. |
221
|
| Line is longer than 80 characters. |
223
|
| Line is longer than 80 characters. |
224
|
| ')' is preceded with whitespace. |
225
|
| Line has trailing spaces. |
228
|
| Line is longer than 80 characters. |
229
|
| '(' is followed by whitespace. |
231
|
| ')' is preceded with whitespace. |
231
|
| '{' should be on the previous line. |
232
|
| Line has trailing spaces. |
238
|
| Line is longer than 80 characters. |
240
|
| '(' is followed by whitespace. |
240
|
| ')' is preceded with whitespace. |
240
|
| '}' should be on the same line. |
242
|
| '{' should be on the previous line. |
244
|
| '}' should be on the same line. |
247
|
| '{' should be on the previous line. |
249
|
| '}' should be on the same line. |
252
|
| '(' is followed by whitespace. |
253
|
| ')' is preceded with whitespace. |
253
|
| '{' should be on the previous line. |
254
|
| '(' is followed by whitespace. |
256
|
| ')' is preceded with whitespace. |
256
|
| '(' is followed by whitespace. |
257
|
| ')' is preceded with whitespace. |
257
|
| Line is longer than 80 characters. |
271
|
| Method 'allocateBigDecimalIdBlock' is not designed for extension - needs to be abstract, final or empty. |
273
|
| '(' is followed by whitespace. |
273
|
| Parameter blockSize should be final. |
273
|
| ')' is preceded with whitespace. |
273
|
| '{' should be on the previous line. |
275
|
| 'cast' is not followed by whitespace. |
276
|
| '(' is followed by whitespace. |
276
|
| ')' is preceded with whitespace. |
276
|
| Line is longer than 80 characters. |
286
|
| Method 'allocateLongIdBlock' is not designed for extension - needs to be abstract, final or empty. |
288
|
| '(' is followed by whitespace. |
288
|
| Parameter blockSize should be final. |
288
|
| ')' is preceded with whitespace. |
288
|
| '{' should be on the previous line. |
290
|
| 'cast' is not followed by whitespace. |
291
|
| '(' is followed by whitespace. |
291
|
| ')' is preceded with whitespace. |
291
|
| Line is longer than 80 characters. |
304
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
306
|
| '(' is followed by whitespace. |
306
|
| Parameter configuration should be final. |
306
|
| ')' is preceded with whitespace. |
306
|
| '{' should be on the previous line. |
308
|
| '(' is followed by whitespace. |
309
|
| ')' is preceded with whitespace. |
309
|
| '(' is followed by whitespace. |
312
|
| ')' is preceded with whitespace. |
312
|
| '(' is followed by whitespace. |
315
|
| ')' is preceded with whitespace. |
315
|
org/apache/avalon/excalibur/datasource/ids/package.html
Error | Line |
| Missing package documentation file. | 0 |