Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
15 | 0 | 0 | 683 |
Files
org/apache/avalon/cornerstone/blocks/sockets/AbstractTLSSocketFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
40
|
| Missing a Javadoc comment. |
41
|
| 'static' modifier out of order with the JLS suggestions. |
41
|
| Missing a Javadoc comment. |
42
|
| Name 'm_socketTimeOut' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| Variable 'm_socketTimeOut' must be private and have accessor methods. |
42
|
| Missing a Javadoc comment. |
44
|
| Name 'm_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_childConfig' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Missing a Javadoc comment. |
47
|
| '(' is followed by whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
| '{' should be on the previous line. |
48
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
58
|
| '(' is followed by whitespace. |
58
|
| ')' is preceded with whitespace. |
58
|
| '{' should be on the previous line. |
60
|
| Line is longer than 80 characters. |
61
|
| '(' is followed by whitespace. |
61
|
| ')' is preceded with whitespace. |
61
|
| '(' is followed by whitespace. |
61
|
| ')' is preceded with whitespace. |
61
|
| '(' is followed by whitespace. |
62
|
| ')' is preceded with whitespace. |
62
|
| 'if' is not followed by whitespace. |
63
|
| '(' is followed by whitespace. |
63
|
| ')' is preceded with whitespace. |
63
|
| '{' should be on the previous line. |
64
|
| '+' should be on a new line. |
65
|
| '+' should be on a new line. |
66
|
| '+' should be on a new line. |
67
|
| '(' is followed by whitespace. |
69
|
| ')' is preceded with whitespace. |
69
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Expected @throws tag for 'Exception'. |
78
|
| '{' should be on the previous line. |
79
|
| '(' is followed by whitespace. |
81
|
| ')' is preceded with whitespace. |
81
|
| '(' is followed by whitespace. |
82
|
| ')' is preceded with whitespace. |
82
|
| '(' is followed by whitespace. |
83
|
| ')' is preceded with whitespace. |
83
|
| '(' is followed by whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
| '(' is followed by whitespace. |
86
|
| ')' is preceded with whitespace. |
86
|
| '(' is followed by whitespace. |
88
|
| ')' is preceded with whitespace. |
88
|
| '(' is followed by whitespace. |
101
|
| Parameter builder should be final. |
101
|
| Expected @param tag for 'builder'. |
101
|
| ')' is preceded with whitespace. |
101
|
org/apache/avalon/cornerstone/blocks/sockets/DefaultServerSocketFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
33
|
| Method 'createServerSocket' is not designed for extension - needs to be abstract, final or empty. |
41
|
| '(' is followed by whitespace. |
41
|
| ')' is preceded with whitespace. |
41
|
| '{' should be on the previous line. |
43
|
| '(' is followed by whitespace. |
44
|
| ')' is preceded with whitespace. |
44
|
| Method 'createServerSocket' is not designed for extension - needs to be abstract, final or empty. |
55
|
| '(' is followed by whitespace. |
55
|
| Parameter port should be final. |
55
|
| Parameter backLog should be final. |
55
|
| ')' is preceded with whitespace. |
55
|
| '{' should be on the previous line. |
57
|
| '(' is followed by whitespace. |
58
|
| ')' is preceded with whitespace. |
58
|
| Line is longer than 80 characters. |
71
|
| Method 'createServerSocket' is not designed for extension - needs to be abstract, final or empty. |
71
|
| '(' is followed by whitespace. |
71
|
| Parameter port should be final. |
71
|
| Parameter backLog should be final. |
71
|
| Parameter bindAddress should be final. |
71
|
| ')' is preceded with whitespace. |
71
|
| '{' should be on the previous line. |
73
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
org/apache/avalon/cornerstone/blocks/sockets/DefaultSocketFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
32
|
| Method 'createSocket' is not designed for extension - needs to be abstract, final or empty. |
41
|
| '(' is followed by whitespace. |
41
|
| ')' is preceded with whitespace. |
41
|
| '{' should be on the previous line. |
43
|
| '(' is followed by whitespace. |
44
|
| ')' is preceded with whitespace. |
44
|
| Method 'createSocket' is not designed for extension - needs to be abstract, final or empty. |
58
|
| '(' is followed by whitespace. |
58
|
| ')' is preceded with whitespace. |
61
|
| '{' should be on the previous line. |
63
|
| '(' is followed by whitespace. |
64
|
| ')' is preceded with whitespace. |
64
|
org/apache/avalon/cornerstone/blocks/sockets/DefaultSocketManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
39
|
| '{' should be on the previous line. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_serverSockets' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Variable 'm_serverSockets' must be private and have accessor methods. |
45
|
| Missing a Javadoc comment. |
46
|
| Name 'm_sockets' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
46
|
| Variable 'm_sockets' must be private and have accessor methods. |
46
|
| Missing a Javadoc comment. |
48
|
| Name 'm_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| Variable 'm_context' must be private and have accessor methods. |
48
|
| Missing a Javadoc comment. |
49
|
| Name 'm_configuration' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
| Variable 'm_configuration' must be private and have accessor methods. |
49
|
| Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
56
|
| '(' is followed by whitespace. |
56
|
| Expected @param tag for 'context'. |
56
|
| ')' is preceded with whitespace. |
56
|
| '{' should be on the previous line. |
57
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
68
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| '{' should be on the previous line. |
70
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Missing a Javadoc comment. |
74
|
| '{' should be on the previous line. |
76
|
| Line is longer than 80 characters. |
78
|
| '(' is followed by whitespace. |
78
|
| ')' is preceded with whitespace. |
78
|
| '(' is followed by whitespace. |
78
|
| ')' is preceded with whitespace. |
78
|
| 'for' is not followed by whitespace. |
80
|
| '(' is followed by whitespace. |
80
|
| ')' is preceded with whitespace. |
80
|
| '{' should be on the previous line. |
81
|
| '(' is followed by whitespace. |
83
|
| ')' is preceded with whitespace. |
83
|
| '(' is followed by whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
| '(' is followed by whitespace. |
86
|
| ')' is preceded with whitespace. |
86
|
| Line is longer than 80 characters. |
90
|
| '(' is followed by whitespace. |
90
|
| ')' is preceded with whitespace. |
90
|
| '(' is followed by whitespace. |
90
|
| ')' is preceded with whitespace. |
90
|
| 'for' is not followed by whitespace. |
92
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
92
|
| '{' should be on the previous line. |
93
|
| '(' is followed by whitespace. |
95
|
| ')' is preceded with whitespace. |
95
|
| '(' is followed by whitespace. |
96
|
| ')' is preceded with whitespace. |
96
|
| '(' is followed by whitespace. |
98
|
| ')' is preceded with whitespace. |
98
|
| Method 'setupServerSocketFactory' is not designed for extension - needs to be abstract, final or empty. |
102
|
| Missing a Javadoc comment. |
102
|
| '(' is followed by whitespace. |
102
|
| ')' is preceded with whitespace. |
104
|
| '{' should be on the previous line. |
106
|
| '(' is followed by whitespace. |
107
|
| ')' is preceded with whitespace. |
107
|
| 'if' is not followed by whitespace. |
109
|
| '(' is followed by whitespace. |
109
|
| '(' is followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| '{' should be on the previous line. |
110
|
| '(' is followed by whitespace. |
111
|
| '+' should be on a new line. |
111
|
| '+' should be on a new line. |
112
|
| '+' should be on a new line. |
113
|
| ')' is preceded with whitespace. |
114
|
| '(' is followed by whitespace. |
117
|
| ')' is preceded with whitespace. |
117
|
| Method 'setupClientSocketFactory' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Missing a Javadoc comment. |
120
|
| '(' is followed by whitespace. |
120
|
| ')' is preceded with whitespace. |
122
|
| '{' should be on the previous line. |
124
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| 'if' is not followed by whitespace. |
127
|
| '(' is followed by whitespace. |
127
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| '{' should be on the previous line. |
128
|
| '(' is followed by whitespace. |
129
|
| '+' should be on a new line. |
129
|
| '+' should be on a new line. |
130
|
| '+' should be on a new line. |
131
|
| ')' is preceded with whitespace. |
132
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| Method 'createFactory' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Missing a Javadoc comment. |
138
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
140
|
| '{' should be on the previous line. |
142
|
| '{' should be on the previous line. |
146
|
| '(' is followed by whitespace. |
149
|
| ')' is preceded with whitespace. |
149
|
| '}' should be on the same line. |
150
|
| 'catch' is not followed by whitespace. |
151
|
| '(' is followed by whitespace. |
151
|
| ')' is preceded with whitespace. |
151
|
| '{' should be on the previous line. |
152
|
| Line has trailing spaces. |
153
|
| Line is longer than 80 characters. |
155
|
| '(' is followed by whitespace. |
155
|
| ')' is preceded with whitespace. |
155
|
| '(' is followed by whitespace. |
156
|
| ')' is preceded with whitespace. |
156
|
| '(' is followed by whitespace. |
159
|
| ')' is preceded with whitespace. |
159
|
| '(' is followed by whitespace. |
160
|
| ')' is preceded with whitespace. |
160
|
| '(' is followed by whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| '(' is followed by whitespace. |
162
|
| ')' is preceded with whitespace. |
162
|
| Method 'getServerSocketFactory' is not designed for extension - needs to be abstract, final or empty. |
174
|
| '(' is followed by whitespace. |
174
|
| Parameter name should be final. |
174
|
| ')' is preceded with whitespace. |
174
|
| '{' should be on the previous line. |
176
|
| Line is longer than 80 characters. |
177
|
| 'cast' is not followed by whitespace. |
177
|
| '(' is followed by whitespace. |
177
|
| ')' is preceded with whitespace. |
177
|
| 'if' is not followed by whitespace. |
179
|
| '(' is followed by whitespace. |
179
|
| ')' is preceded with whitespace. |
179
|
| '{' should be on the previous line. |
180
|
| '}' should be on the same line. |
182
|
| '{' should be on the previous line. |
184
|
| '(' is followed by whitespace. |
185
|
| '+' should be on a new line. |
185
|
| ')' is preceded with whitespace. |
186
|
| Method 'getSocketFactory' is not designed for extension - needs to be abstract, final or empty. |
197
|
| '(' is followed by whitespace. |
197
|
| ')' is preceded with whitespace. |
197
|
| '{' should be on the previous line. |
199
|
| 'cast' is not followed by whitespace. |
200
|
| '(' is followed by whitespace. |
200
|
| ')' is preceded with whitespace. |
200
|
| 'if' is not followed by whitespace. |
202
|
| '(' is followed by whitespace. |
202
|
| ')' is preceded with whitespace. |
202
|
| '{' should be on the previous line. |
203
|
| '}' should be on the same line. |
205
|
| '{' should be on the previous line. |
207
|
| '(' is followed by whitespace. |
208
|
| '+' should be on a new line. |
208
|
| ')' is preceded with whitespace. |
209
|
org/apache/avalon/cornerstone/blocks/sockets/SSLFactoryBuilder.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
57
|
| '{' should be on the previous line. |
73
|
| Missing a Javadoc comment. |
74
|
| Name 'm_baseDirectory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
74
|
| Missing a Javadoc comment. |
75
|
| Name 'm_keystoreFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
75
|
| Missing a Javadoc comment. |
77
|
| Name 'm_keystorePassword' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
77
|
| Missing a Javadoc comment. |
78
|
| Name 'm_keyPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
78
|
| Missing a Javadoc comment. |
79
|
| Name 'm_protocol' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
79
|
| Missing a Javadoc comment. |
80
|
| Name 'm_provider' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
80
|
| Missing a Javadoc comment. |
81
|
| Name 'm_keystoreFormat' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
81
|
| Missing a Javadoc comment. |
83
|
| Name 'm_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
83
|
| '(' is followed by whitespace. |
88
|
| ')' is preceded with whitespace. |
88
|
| Line is longer than 80 characters. |
89
|
| '(' is followed by whitespace. |
89
|
| ')' is preceded with whitespace. |
89
|
| Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
97
|
| '(' is followed by whitespace. |
97
|
| Expected @param tag for 'context'. |
97
|
| ')' is preceded with whitespace. |
97
|
| Expected @throws tag for 'ContextException'. |
97
|
| '{' should be on the previous line. |
98
|
| '{' should be on the previous line. |
100
|
| '(' is followed by whitespace. |
101
|
| ')' is preceded with whitespace. |
101
|
| '}' should be on the same line. |
102
|
| 'catch' is not followed by whitespace. |
103
|
| '(' is followed by whitespace. |
103
|
| ')' is preceded with whitespace. |
103
|
| '{' should be on the previous line. |
104
|
| 'cast' is not followed by whitespace. |
105
|
| '(' is followed by whitespace. |
105
|
| ')' is preceded with whitespace. |
105
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Missing a Javadoc comment. |
109
|
| '(' is followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| '{' should be on the previous line. |
111
|
| '(' is followed by whitespace. |
112
|
| ')' is preceded with whitespace. |
112
|
| Line is longer than 80 characters. |
113
|
| '(' is followed by whitespace. |
113
|
| ')' is preceded with whitespace. |
113
|
| '(' is followed by whitespace. |
113
|
| ')' is preceded with whitespace. |
113
|
| '(' is followed by whitespace. |
114
|
| ')' is preceded with whitespace. |
114
|
| 'if' is not followed by whitespace. |
115
|
| '(' is followed by whitespace. |
115
|
| ')' is preceded with whitespace. |
115
|
| '{' should be on the previous line. |
116
|
| '(' is followed by whitespace. |
117
|
| ')' is preceded with whitespace. |
117
|
| '}' should be on the same line. |
118
|
| '{' should be on the previous line. |
120
|
| Line is longer than 80 characters. |
124
|
| '(' is followed by whitespace. |
124
|
| ')' is preceded with whitespace. |
124
|
| '(' is followed by whitespace. |
124
|
| ')' is preceded with whitespace. |
124
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| '(' is followed by whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| '(' is followed by whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| '(' is followed by whitespace. |
131
|
| ')' is preceded with whitespace. |
131
|
| '(' is followed by whitespace. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| Expected an @return tag. |
138
|
| Method 'buildSocketFactory' is not designed for extension - needs to be abstract, final or empty. |
138
|
| '{' should be on the previous line. |
139
|
| Expected an @return tag. |
147
|
| Method 'buildServerSocketFactory' is not designed for extension - needs to be abstract, final or empty. |
147
|
| '{' should be on the previous line. |
148
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
152
|
| Missing a Javadoc comment. |
152
|
| '{' should be on the previous line. |
154
|
| '(' is followed by whitespace. |
155
|
| ')' is preceded with whitespace. |
155
|
| '{' should be on the previous line. |
157
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
160
|
| '}' should be on the same line. |
161
|
| '{' should be on the previous line. |
163
|
| '{' should be on the previous line. |
165
|
| '}' should be on the same line. |
167
|
| 'catch' is not followed by whitespace. |
168
|
| '(' is followed by whitespace. |
168
|
| ')' is preceded with whitespace. |
168
|
| '{' should be on the previous line. |
169
|
| '(' is followed by whitespace. |
172
|
| ')' is preceded with whitespace. |
172
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Missing a Javadoc comment. |
177
|
| '{' should be on the previous line. |
178
|
| '(' is followed by whitespace. |
203
|
| Parameter keyStream should be final. |
203
|
| Parameter keystorePassword should be final. |
204
|
| Parameter keyPassword should be final. |
205
|
| Parameter protocol should be final. |
206
|
| Parameter provider should be final. |
207
|
| Parameter keystoreFormat should be final. |
208
|
| ')' is preceded with whitespace. |
208
|
| '{' should be on the previous line. |
210
|
| '(' is followed by whitespace. |
211
|
| ')' is preceded with whitespace. |
213
|
| '(' is followed by whitespace. |
214
|
| ')' is preceded with whitespace. |
214
|
| '(' is followed by whitespace. |
217
|
| ')' is preceded with whitespace. |
217
|
| '?' should be on a new line. |
217
|
| Avoid inline conditionals. |
217
|
| '{' should be on the previous line. |
220
|
| '(' is followed by whitespace. |
221
|
| ')' is preceded with whitespace. |
221
|
| '}' should be on the same line. |
222
|
| '{' should be on the previous line. |
224
|
| '(' is followed by whitespace. |
225
|
| 'cast' is not followed by whitespace. |
225
|
| ')' is preceded with whitespace. |
225
|
| '(' is followed by whitespace. |
229
|
| ')' is preceded with whitespace. |
229
|
| '(' is followed by whitespace. |
230
|
| ')' is preceded with whitespace. |
230
|
| '(' is followed by whitespace. |
232
|
| ')' is preceded with whitespace. |
232
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
235
|
| '(' is followed by whitespace. |
250
|
| Parameter keyStream should be final. |
250
|
| Parameter passphrase should be final. |
251
|
| Parameter keystoreFormat should be final. |
252
|
| ')' is preceded with whitespace. |
252
|
| '{' should be on the previous line. |
254
|
| '(' is followed by whitespace. |
255
|
| ')' is preceded with whitespace. |
255
|
| 'if' is not followed by whitespace. |
257
|
| '(' is followed by whitespace. |
257
|
| ')' is preceded with whitespace. |
257
|
| '{' should be on the previous line. |
258
|
| '{' should be on the previous line. |
261
|
| '(' is followed by whitespace. |
262
|
| ')' is preceded with whitespace. |
262
|
| '}' should be on the same line. |
263
|
| '{' should be on the previous line. |
265
|
| '(' is followed by whitespace. |
266
|
| 'cast' is not followed by whitespace. |
266
|
| ')' is preceded with whitespace. |
266
|
| '}' should be on the same line. |
268
|
| '{' should be on the previous line. |
270
|
| '(' is followed by whitespace. |
271
|
| ')' is preceded with whitespace. |
271
|
org/apache/avalon/cornerstone/blocks/sockets/TLSServerSocketFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
40
|
| '{' should be on the previous line. |
59
|
| Missing a Javadoc comment. |
60
|
| Name 'm_factory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
60
|
| Missing a Javadoc comment. |
61
|
| Name 'm_keyStoreAuthenticateClients' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
61
|
| Variable 'm_keyStoreAuthenticateClients' must be private and have accessor methods. |
61
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
69
|
| '(' is followed by whitespace. |
69
|
| ')' is preceded with whitespace. |
69
|
| '{' should be on the previous line. |
71
|
| '(' is followed by whitespace. |
72
|
| ')' is preceded with whitespace. |
72
|
| Line is longer than 80 characters. |
74
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| Method 'visitBuilder' is not designed for extension - needs to be abstract, final or empty. |
77
|
| Missing a Javadoc comment. |
77
|
| '(' is followed by whitespace. |
77
|
| Parameter builder should be final. |
77
|
| ')' is preceded with whitespace. |
77
|
| '{' should be on the previous line. |
78
|
| Method 'createServerSocket' is not designed for extension - needs to be abstract, final or empty. |
89
|
| '(' is followed by whitespace. |
89
|
| ')' is preceded with whitespace. |
89
|
| '{' should be on the previous line. |
91
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
92
|
| '(' is followed by whitespace. |
93
|
| ')' is preceded with whitespace. |
93
|
| Method 'createServerSocket' is not designed for extension - needs to be abstract, final or empty. |
105
|
| '(' is followed by whitespace. |
105
|
| Parameter port should be final. |
105
|
| Parameter backLog should be final. |
105
|
| ')' is preceded with whitespace. |
105
|
| '{' should be on the previous line. |
107
|
| Line is longer than 80 characters. |
108
|
| '(' is followed by whitespace. |
108
|
| ')' is preceded with whitespace. |
108
|
| '(' is followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
109
|
| Line is longer than 80 characters. |
123
|
| Method 'createServerSocket' is not designed for extension - needs to be abstract, final or empty. |
123
|
| '(' is followed by whitespace. |
123
|
| Parameter port should be final. |
123
|
| Parameter backLog should be final. |
123
|
| Parameter bindAddress should be final. |
123
|
| ')' is preceded with whitespace. |
123
|
| '{' should be on the previous line. |
125
|
| '(' is followed by whitespace. |
127
|
| ')' is preceded with whitespace. |
127
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| Method 'initServerSocket' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Missing a Javadoc comment. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| '{' should be on the previous line. |
134
|
| 'cast' is not followed by whitespace. |
135
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| '(' is followed by whitespace. |
140
|
| ')' is preceded with whitespace. |
140
|
org/apache/avalon/cornerstone/blocks/sockets/TLSSocketFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
38
|
| '{' should be on the previous line. |
79
|
| Missing a Javadoc comment. |
80
|
| Name 'm_factory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
80
|
| Missing a Javadoc comment. |
81
|
| Name 'm_verifyServerIdentity' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
81
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
89
|
| '(' is followed by whitespace. |
89
|
| ')' is preceded with whitespace. |
89
|
| '{' should be on the previous line. |
91
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
92
|
| Line is longer than 80 characters. |
93
|
| '(' is followed by whitespace. |
93
|
| ')' is preceded with whitespace. |
93
|
| '(' is followed by whitespace. |
93
|
| ')' is preceded with whitespace. |
93
|
| Method 'visitBuilder' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Missing a Javadoc comment. |
96
|
| '(' is followed by whitespace. |
96
|
| Parameter builder should be final. |
96
|
| ')' is preceded with whitespace. |
96
|
| '{' should be on the previous line. |
97
|
| Expected an @return tag. |
105
|
| '(' is followed by whitespace. |
105
|
| Expected @param tag for 'socket'. |
105
|
| ')' is preceded with whitespace. |
105
|
| Expected @throws tag for 'IOException'. |
106
|
| '{' should be on the previous line. |
107
|
| '(' is followed by whitespace. |
108
|
| ')' is preceded with whitespace. |
108
|
| '(' is followed by whitespace. |
122
|
| Parameter bareSocket should be final. |
122
|
| Parameter address should be final. |
122
|
| Parameter port should be final. |
123
|
| ')' is preceded with whitespace. |
123
|
| Expected @throws tag for 'IOException'. |
124
|
| '{' should be on the previous line. |
125
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
131
|
| Name 'CN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
133
|
| '(' is followed by whitespace. |
133
|
| ')' is preceded with whitespace. |
133
|
| 'if' is not followed by whitespace. |
134
|
| '(' is followed by whitespace. |
134
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '{' should be on the previous line. |
135
|
| '+' should be on a new line. |
136
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| 'if' is not followed by whitespace. |
140
|
| '(' is followed by whitespace. |
140
|
| ')' is preceded with whitespace. |
140
|
| '{' should be on the previous line. |
141
|
| '(' is followed by whitespace. |
143
|
| ')' is preceded with whitespace. |
143
|
| '+' should be on a new line. |
144
|
| '(' is followed by whitespace. |
145
|
| ')' is preceded with whitespace. |
145
|
| '(' is followed by whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| Missing a Javadoc comment. |
151
|
| '(' is followed by whitespace. |
151
|
| Parameter data should be final. |
151
|
| ')' is preceded with whitespace. |
151
|
| '{' should be on the previous line. |
152
|
| '(' is followed by whitespace. |
153
|
| '3' is a magic number. |
153
|
| ')' is preceded with whitespace. |
153
|
| 'for' is not followed by whitespace. |
155
|
| '(' is followed by whitespace. |
155
|
| ')' is preceded with whitespace. |
155
|
| '{' should be on the previous line. |
156
|
| '(' is followed by whitespace. |
159
|
| ')' is preceded with whitespace. |
159
|
| Avoid inline conditionals. |
159
|
| '256' is a magic number. |
159
|
| '(' is followed by whitespace. |
160
|
| ')' is preceded with whitespace. |
160
|
| '(' is followed by whitespace. |
161
|
| '(' is followed by whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| '(' is followed by whitespace. |
175
|
| Parameter DN should be final. |
175
|
| Expected @param tag for 'DN'. |
175
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
175
|
| ')' is preceded with whitespace. |
175
|
| '{' should be on the previous line. |
176
|
| '(' is followed by whitespace. |
177
|
| ')' is preceded with whitespace. |
177
|
| 'if' is not followed by whitespace. |
178
|
| '(' is followed by whitespace. |
178
|
| ')' is preceded with whitespace. |
178
|
| '{' should be on the previous line. |
179
|
| '(' is followed by whitespace. |
183
|
| ')' is preceded with whitespace. |
183
|
| 'if' is not followed by whitespace. |
184
|
| '(' is followed by whitespace. |
184
|
| ')' is preceded with whitespace. |
184
|
| '{' should be on the previous line. |
185
|
| '(' is followed by whitespace. |
186
|
| ')' is preceded with whitespace. |
186
|
| '}' should be on the same line. |
187
|
| '{' should be on the previous line. |
189
|
| Line is longer than 80 characters. |
202
|
| Method 'createSocket' is not designed for extension - needs to be abstract, final or empty. |
202
|
| '(' is followed by whitespace. |
202
|
| Parameter address should be final. |
202
|
| Parameter port should be final. |
202
|
| ')' is preceded with whitespace. |
202
|
| 'if' is not followed by whitespace. |
207
|
| '(' is followed by whitespace. |
207
|
| ')' is preceded with whitespace. |
207
|
| '{' should be on the previous line. |
208
|
| '(' is followed by whitespace. |
209
|
| '(' is followed by whitespace. |
209
|
| '(' is followed by whitespace. |
209
|
| ')' is preceded with whitespace. |
209
|
| ')' is preceded with whitespace. |
209
|
| ')' is preceded with whitespace. |
210
|
| '}' should be on the same line. |
211
|
| '{' should be on the previous line. |
213
|
| '(' is followed by whitespace. |
214
|
| '(' is followed by whitespace. |
214
|
| ')' is preceded with whitespace. |
214
|
| ')' is preceded with whitespace. |
214
|
| Method 'createSocket' is not designed for extension - needs to be abstract, final or empty. |
229
|
| '(' is followed by whitespace. |
229
|
| ')' is preceded with whitespace. |
232
|
| '{' should be on the previous line. |
234
|
| 'if' is not followed by whitespace. |
238
|
| '(' is followed by whitespace. |
238
|
| ')' is preceded with whitespace. |
238
|
| '{' should be on the previous line. |
239
|
| '(' is followed by whitespace. |
240
|
| '(' is followed by whitespace. |
240
|
| '(' is followed by whitespace. |
240
|
| ')' is preceded with whitespace. |
242
|
| ')' is preceded with whitespace. |
242
|
| ')' is preceded with whitespace. |
243
|
| '}' should be on the same line. |
244
|
| '{' should be on the previous line. |
246
|
| '(' is followed by whitespace. |
247
|
| '(' is followed by whitespace. |
247
|
| ')' is preceded with whitespace. |
247
|
| ')' is preceded with whitespace. |
247
|