Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
24 | 0 | 0 | 635 |
Files
org/apache/avalon/cornerstone/blocks/connection/AbstractConnectionManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
22
|
| '{' should be on the previous line. |
33
|
| Missing a Javadoc comment. |
34
|
| Name 'm_connections' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
| Missing a Javadoc comment. |
35
|
| Name 'm_threadManager' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
35
|
| Variable 'm_threadManager' must be private and have accessor methods. |
35
|
| Missing a Javadoc comment. |
36
|
| Variable 'monitor' must be private and have accessor methods. |
36
|
| Method 'connect' is not designed for extension - needs to be abstract, final or empty. |
50
|
| '(' is followed by whitespace. |
50
|
| Parameter name should be final. |
50
|
| Parameter socket should be final. |
51
|
| Parameter handlerFactory should be final. |
52
|
| Parameter threadPool should be final. |
53
|
| ')' is preceded with whitespace. |
53
|
| '{' should be on the previous line. |
55
|
| 'if' is not followed by whitespace. |
56
|
| '(' is followed by whitespace. |
56
|
| '(' is followed by whitespace. |
56
|
| ')' is preceded with whitespace. |
56
|
| ')' is preceded with whitespace. |
56
|
| '{' should be on the previous line. |
57
|
| Line is longer than 80 characters. |
58
|
| '(' is followed by whitespace. |
59
|
| ')' is preceded with whitespace. |
59
|
| 'if' is not followed by whitespace. |
63
|
| '(' is followed by whitespace. |
63
|
| ')' is preceded with whitespace. |
63
|
| '{' should be on the previous line. |
64
|
| '(' is followed by whitespace. |
65
|
| '500' is a magic number. |
65
|
| ')' is preceded with whitespace. |
65
|
| '(' is followed by whitespace. |
69
|
| ')' is preceded with whitespace. |
69
|
| '(' is followed by whitespace. |
70
|
| ')' is preceded with whitespace. |
70
|
| '(' is followed by whitespace. |
71
|
| ')' is preceded with whitespace. |
71
|
| Line is longer than 80 characters. |
76
|
| Method 'connect' is not designed for extension - needs to be abstract, final or empty. |
83
|
| '(' is followed by whitespace. |
83
|
| Parameter name should be final. |
83
|
| Parameter socket should be final. |
84
|
| Parameter handlerFactory should be final. |
85
|
| ')' is preceded with whitespace. |
85
|
| '{' should be on the previous line. |
87
|
| Line is longer than 80 characters. |
88
|
| '(' is followed by whitespace. |
88
|
| ')' is preceded with whitespace. |
88
|
| Line is longer than 80 characters. |
92
|
| Method 'disconnect' is not designed for extension - needs to be abstract, final or empty. |
97
|
| '(' is followed by whitespace. |
97
|
| ')' is preceded with whitespace. |
97
|
| '{' should be on the previous line. |
99
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
100
|
| Line is longer than 80 characters. |
105
|
| Line is longer than 80 characters. |
113
|
| Method 'disconnect' is not designed for extension - needs to be abstract, final or empty. |
113
|
| '(' is followed by whitespace. |
113
|
| ')' is preceded with whitespace. |
113
|
| '{' should be on the previous line. |
115
|
| 'cast' is not followed by whitespace. |
116
|
| '(' is followed by whitespace. |
116
|
| ')' is preceded with whitespace. |
116
|
| 'if' is not followed by whitespace. |
118
|
| '(' is followed by whitespace. |
118
|
| ')' is preceded with whitespace. |
118
|
| '{' should be on the previous line. |
119
|
| Comment matches to-do format 'TODO:'. |
120
|
| '}' should be on the same line. |
122
|
| '{' should be on the previous line. |
124
|
| Line is longer than 80 characters. |
126
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Missing a Javadoc comment. |
131
|
| '{' should be on the previous line. |
132
|
| 'if' is not followed by whitespace. |
133
|
| '(' is followed by whitespace. |
133
|
| ')' is preceded with whitespace. |
133
|
| '{' should be on the previous line. |
134
|
| ')' is preceded with whitespace. |
135
|
| Line is longer than 80 characters. |
137
|
| 'cast' is not followed by whitespace. |
137
|
| '(' is followed by whitespace. |
137
|
| ')' is preceded with whitespace. |
137
|
| 'for' is not followed by whitespace. |
138
|
| '(' is followed by whitespace. |
138
|
| ')' is preceded with whitespace. |
138
|
| '{' should be on the previous line. |
139
|
| '{' should be on the previous line. |
141
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| '}' should be on the same line. |
143
|
| 'catch' is not followed by whitespace. |
144
|
| '(' is followed by whitespace. |
144
|
| ')' is preceded with whitespace. |
144
|
| '{' should be on the previous line. |
145
|
| ')' is preceded with whitespace. |
147
|
org/apache/avalon/cornerstone/blocks/connection/AvalonLoggerConnectionMonitor.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
11
|
| Line is longer than 80 characters. |
13
|
| Method 'acceptingConnectionException' is not designed for extension - needs to be abstract, final or empty. |
13
|
| Missing a Javadoc comment. |
13
|
| Parameter clazz should be final. |
13
|
| Parameter message should be final. |
13
|
| Parameter ioe should be final. |
13
|
| Method 'unexpectedException' is not designed for extension - needs to be abstract, final or empty. |
17
|
| Missing a Javadoc comment. |
17
|
| Parameter clazz should be final. |
17
|
| Parameter message should be final. |
17
|
| Parameter e should be final. |
17
|
| Line is longer than 80 characters. |
22
|
| Method 'shutdownSocketWarning' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Missing a Javadoc comment. |
22
|
| Parameter clazz should be final. |
22
|
| Parameter message should be final. |
22
|
| Parameter ioe should be final. |
22
|
| Method 'debugMessage' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter clazz should be final. |
26
|
| Parameter message should be final. |
26
|
| Method 'isDebugEnabled' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter clazz should be final. |
30
|
org/apache/avalon/cornerstone/blocks/connection/CDIConnectionManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter threadManager should be final. |
31
|
| Parameter monitor should be final. |
31
|
org/apache/avalon/cornerstone/blocks/connection/CommonsLoggingConnectionMonitor.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
25
|
| '{' should be on the previous line. |
31
|
| Line is longer than 80 characters. |
33
|
| Method 'acceptingConnectionException' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Missing a Javadoc comment. |
33
|
| Parameter clazz should be final. |
33
|
| Parameter message should be final. |
33
|
| Parameter ioe should be final. |
33
|
| Method 'unexpectedException' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter clazz should be final. |
38
|
| Parameter message should be final. |
38
|
| Parameter e should be final. |
38
|
| '{' should be on the previous line. |
39
|
| Line is longer than 80 characters. |
43
|
| Method 'shutdownSocketWarning' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Parameter clazz should be final. |
43
|
| Parameter message should be final. |
43
|
| Parameter ioe should be final. |
43
|
| Method 'debugMessage' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Missing a Javadoc comment. |
48
|
| Parameter clazz should be final. |
48
|
| Parameter message should be final. |
48
|
| '{' should be on the previous line. |
49
|
| Method 'isDebugEnabled' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Parameter clazz should be final. |
53
|
| '{' should be on the previous line. |
54
|
org/apache/avalon/cornerstone/blocks/connection/Connection.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
29
|
| '{' should be on the previous line. |
41
|
| Missing a Javadoc comment. |
42
|
| Name 'm_serverSocket' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| Missing a Javadoc comment. |
43
|
| Name 'm_handlerFactory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Missing a Javadoc comment. |
44
|
| Name 'm_threadPool' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'm_runners' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| Missing a Javadoc comment. |
48
|
| Name 'm_thread' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| Missing a Javadoc comment. |
49
|
| Variable 'monitor' must be private and have accessor methods. |
49
|
| Missing a Javadoc comment. |
51
|
| '(' is followed by whitespace. |
51
|
| 'monitor' hides a field. |
54
|
| '{' should be on the previous line. |
55
|
| Missing a Javadoc comment. |
63
|
| '{' should be on the previous line. |
65
|
| 'synchronized' is not followed by whitespace. |
66
|
| '(' is followed by whitespace. |
66
|
| ')' is preceded with whitespace. |
66
|
| '{' should be on the previous line. |
67
|
| 'if' is not followed by whitespace. |
68
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| '{' should be on the previous line. |
69
|
| '(' is followed by whitespace. |
78
|
| ')' is preceded with whitespace. |
78
|
| 'while' is not followed by whitespace. |
83
|
| '(' is followed by whitespace. |
83
|
| ')' is preceded with whitespace. |
83
|
| '{' should be on the previous line. |
84
|
| 'cast' is not followed by whitespace. |
85
|
| Missing a Javadoc comment. |
92
|
| '{' should be on the previous line. |
93
|
| 'while' is not followed by whitespace. |
96
|
| '(' is followed by whitespace. |
96
|
| ')' is preceded with whitespace. |
96
|
| '{' should be on the previous line. |
97
|
| '{' should be on the previous line. |
104
|
| Line is longer than 80 characters. |
107
|
| '(' is followed by whitespace. |
107
|
| ')' is preceded with whitespace. |
107
|
| '(' is followed by whitespace. |
108
|
| ')' is preceded with whitespace. |
108
|
| '}' should be on the same line. |
109
|
| 'catch' is not followed by whitespace. |
110
|
| '(' is followed by whitespace. |
110
|
| ')' is preceded with whitespace. |
110
|
| '{' should be on the previous line. |
111
|
| Must have at least one statement. |
111
|
| '}' should be on the same line. |
113
|
| 'catch' is not followed by whitespace. |
114
|
| '(' is followed by whitespace. |
114
|
| ')' is preceded with whitespace. |
114
|
| '{' should be on the previous line. |
115
|
| Line is longer than 80 characters. |
117
|
| ')' is preceded with whitespace. |
117
|
| '}' should be on the same line. |
118
|
| 'catch' is not followed by whitespace. |
119
|
| '(' is followed by whitespace. |
119
|
| ')' is preceded with whitespace. |
119
|
| '{' should be on the previous line. |
120
|
| ')' is preceded with whitespace. |
122
|
| 'synchronized' is not followed by whitespace. |
126
|
| '(' is followed by whitespace. |
126
|
| ')' is preceded with whitespace. |
126
|
| '{' should be on the previous line. |
127
|
| Missing a Javadoc comment. |
134
|
| '{' should be on the previous line. |
136
|
| Missing a Javadoc comment. |
137
|
| Name 'm_socket' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
137
|
| Missing a Javadoc comment. |
138
|
| Name 'm_thread' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
138
|
| Missing a Javadoc comment. |
139
|
| Name 'm_runners' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
139
|
| Missing a Javadoc comment. |
140
|
| Name 'm_handlerFactory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
140
|
| Missing a Javadoc comment. |
141
|
| Missing a Javadoc comment. |
142
|
| Name 'm_finished' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
142
|
| Missing a Javadoc comment. |
144
|
| '(' is followed by whitespace. |
144
|
| 'monitor' hides a field. |
147
|
| '{' should be on the previous line. |
148
|
| Missing a Javadoc comment. |
155
|
| '{' should be on the previous line. |
157
|
| 'synchronized' is not followed by whitespace. |
158
|
| '(' is followed by whitespace. |
158
|
| ')' is preceded with whitespace. |
158
|
| '{' should be on the previous line. |
159
|
| 'if' is not followed by whitespace. |
161
|
| '(' is followed by whitespace. |
161
|
| ')' is preceded with whitespace. |
161
|
| '{' should be on the previous line. |
162
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| Missing a Javadoc comment. |
174
|
| '{' should be on the previous line. |
175
|
| 'synchronized' is not followed by whitespace. |
179
|
| '(' is followed by whitespace. |
179
|
| ')' is preceded with whitespace. |
179
|
| '{' should be on the previous line. |
180
|
| 'if' is not followed by whitespace. |
181
|
| '(' is followed by whitespace. |
181
|
| ')' is preceded with whitespace. |
181
|
| '{' should be on the previous line. |
182
|
| '(' is followed by whitespace. |
187
|
| ')' is preceded with whitespace. |
187
|
| '{' should be on the previous line. |
192
|
| '(' is followed by whitespace. |
193
|
| ')' is preceded with whitespace. |
193
|
| '(' is followed by whitespace. |
196
|
| ')' is preceded with whitespace. |
196
|
| '(' is followed by whitespace. |
198
|
| ')' is preceded with whitespace. |
198
|
| '}' should be on the same line. |
199
|
| 'catch' is not followed by whitespace. |
200
|
| '(' is followed by whitespace. |
200
|
| ')' is preceded with whitespace. |
200
|
| '{' should be on the previous line. |
201
|
| ')' is preceded with whitespace. |
203
|
| 'if' is not followed by whitespace. |
206
|
| '(' is followed by whitespace. |
206
|
| ')' is preceded with whitespace. |
206
|
| '{' should be on the previous line. |
207
|
| '(' is followed by whitespace. |
208
|
| ')' is preceded with whitespace. |
208
|
| 'synchronized' is not followed by whitespace. |
215
|
| '(' is followed by whitespace. |
215
|
| ')' is preceded with whitespace. |
215
|
| '{' should be on the previous line. |
216
|
| '(' is followed by whitespace. |
218
|
| ')' is preceded with whitespace. |
218
|
| '(' is followed by whitespace. |
231
|
| ')' is preceded with whitespace. |
231
|
| '{' should be on the previous line. |
232
|
| 'if' is not followed by whitespace. |
233
|
| '(' is followed by whitespace. |
233
|
| ')' is preceded with whitespace. |
233
|
| '{' should be on the previous line. |
234
|
| '(' is followed by whitespace. |
235
|
| ')' is preceded with whitespace. |
235
|
| Avoid inline conditionals. |
235
|
| '+' should be on a new line. |
237
|
| ')' is preceded with whitespace. |
239
|
| '{' should be on the previous line. |
247
|
| '{' should be on the previous line. |
249
|
| '}' should be on the same line. |
251
|
| 'catch' is not followed by whitespace. |
252
|
| '(' is followed by whitespace. |
252
|
| ')' is preceded with whitespace. |
252
|
| '{' should be on the previous line. |
253
|
| ')' is preceded with whitespace. |
255
|
org/apache/avalon/cornerstone/blocks/connection/ConnectionMonitor.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
28
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
36
|
org/apache/avalon/cornerstone/blocks/connection/DefaultConnectionManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
34
|
| '{' should be on the previous line. |
39
|
| Method 'enableLogging' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter logger should be final. |
41
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
48
|
| Method 'service' is not designed for extension - needs to be abstract, final or empty. |
50
|
| '(' is followed by whitespace. |
50
|
| Expected @param tag for 'serviceManager'. |
50
|
| ')' is preceded with whitespace. |
50
|
| Expected @throws tag for 'ServiceException'. |
51
|
| '{' should be on the previous line. |
52
|
| Line is longer than 80 characters. |
53
|
| 'cast' is not followed by whitespace. |
53
|
| '(' is followed by whitespace. |
53
|
| ')' is preceded with whitespace. |
53
|
org/apache/avalon/cornerstone/blocks/connection/NullConnectionMonitor.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
23
|
| '{' should be on the previous line. |
28
|
| Line is longer than 80 characters. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter clazz should be final. |
30
|
| Parameter message should be final. |
30
|
| Parameter ioe should be final. |
30
|
| Missing a Javadoc comment. |
34
|
| Parameter clazz should be final. |
34
|
| Parameter message should be final. |
34
|
| Parameter e should be final. |
34
|
| '{' should be on the previous line. |
35
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter clazz should be final. |
38
|
| Parameter message should be final. |
38
|
| Parameter ioe should be final. |
38
|
| Missing a Javadoc comment. |
42
|
| Parameter clazz should be final. |
42
|
| Parameter message should be final. |
42
|
| '{' should be on the previous line. |
43
|
| Method 'isDebugEnabled' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter clazz should be final. |
46
|
| '{' should be on the previous line. |
47
|
org/apache/avalon/cornerstone/services/connection/AbstractHandlerFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
39
|
| Missing a Javadoc comment. |
41
|
| Name 'm_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
41
|
| Missing a Javadoc comment. |
42
|
| Name 'm_serviceManager' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| Missing a Javadoc comment. |
43
|
| Name 'm_configuration' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| '(' is followed by whitespace. |
45
|
| ')' is preceded with whitespace. |
45
|
| '{' should be on the previous line. |
46
|
| Method 'service' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| '(' is followed by whitespace. |
50
|
| ')' is preceded with whitespace. |
50
|
| '{' should be on the previous line. |
52
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Missing a Javadoc comment. |
56
|
| '(' is followed by whitespace. |
56
|
| ')' is preceded with whitespace. |
56
|
| '{' should be on the previous line. |
58
|
| Method 'createConnectionHandler' is not designed for extension - needs to be abstract, final or empty. |
68
|
| '{' should be on the previous line. |
70
|
| '(' is followed by whitespace. |
72
|
| ')' is preceded with whitespace. |
72
|
| '(' is followed by whitespace. |
73
|
| ')' is preceded with whitespace. |
73
|
| '(' is followed by whitespace. |
74
|
| ')' is preceded with whitespace. |
74
|
| Line is longer than 80 characters. |
75
|
| '(' is followed by whitespace. |
75
|
| '(' is followed by whitespace. |
75
|
| ')' is preceded with whitespace. |
75
|
| ')' is preceded with whitespace. |
75
|
| '(' is followed by whitespace. |
76
|
| ')' is preceded with whitespace. |
76
|
| '(' is followed by whitespace. |
77
|
| ')' is preceded with whitespace. |
77
|
| Method 'releaseConnectionHandler' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Missing a Javadoc comment. |
82
|
| '(' is followed by whitespace. |
82
|
| Parameter connectionHandler should be final. |
82
|
| ')' is preceded with whitespace. |
82
|
| '(' is followed by whitespace. |
84
|
| ')' is preceded with whitespace. |
84
|
org/apache/avalon/cornerstone/services/connection/AbstractService.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
54
|
| Missing a Javadoc comment. |
56
|
| Name 'm_connectionManager' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
56
|
| Variable 'm_connectionManager' must be private and have accessor methods. |
56
|
| Missing a Javadoc comment. |
57
|
| Name 'm_socketManager' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
57
|
| Variable 'm_socketManager' must be private and have accessor methods. |
57
|
| Missing a Javadoc comment. |
58
|
| Name 'm_factory' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
58
|
| Variable 'm_factory' must be private and have accessor methods. |
58
|
| Missing a Javadoc comment. |
59
|
| Name 'm_threadManager' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
59
|
| Variable 'm_threadManager' must be private and have accessor methods. |
59
|
| Missing a Javadoc comment. |
60
|
| Name 'm_threadPool' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
60
|
| Variable 'm_threadPool' must be private and have accessor methods. |
60
|
| Missing a Javadoc comment. |
61
|
| Name 'm_serverSocketType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
61
|
| Variable 'm_serverSocketType' must be private and have accessor methods. |
61
|
| Missing a Javadoc comment. |
62
|
| Name 'm_port' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
62
|
| Variable 'm_port' must be private and have accessor methods. |
62
|
| Missing a Javadoc comment. |
63
|
| Name 'm_bindTo' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
63
|
| Variable 'm_bindTo' must be private and have accessor methods. |
63
|
| Missing a Javadoc comment. |
64
|
| Name 'm_serverSocket' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
64
|
| Variable 'm_serverSocket' must be private and have accessor methods. |
64
|
| Missing a Javadoc comment. |
65
|
| Name 'm_connectionName' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
65
|
| Variable 'm_connectionName' must be private and have accessor methods. |
65
|
| Missing a Javadoc comment. |
67
|
| '{' should be on the previous line. |
68
|
| Method 'getThreadPoolName' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| '{' should be on the previous line. |
74
|
| Missing a Javadoc comment. |
78
|
| Method 'enableLogging' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| '(' is followed by whitespace. |
80
|
| ')' is preceded with whitespace. |
80
|
| '{' should be on the previous line. |
81
|
| '(' is followed by whitespace. |
82
|
| ')' is preceded with whitespace. |
82
|
| '(' is followed by whitespace. |
83
|
| ')' is preceded with whitespace. |
83
|
| Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Missing a Javadoc comment. |
86
|
| '(' is followed by whitespace. |
86
|
| ')' is preceded with whitespace. |
86
|
| '{' should be on the previous line. |
88
|
| '(' is followed by whitespace. |
89
|
| ')' is preceded with whitespace. |
89
|
| Method 'service' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Missing a Javadoc comment. |
92
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
92
|
| '{' should be on the previous line. |
94
|
| Line is longer than 80 characters. |
95
|
| 'cast' is not followed by whitespace. |
95
|
| '(' is followed by whitespace. |
95
|
| ')' is preceded with whitespace. |
95
|
| Line is longer than 80 characters. |
96
|
| 'cast' is not followed by whitespace. |
96
|
| '(' is followed by whitespace. |
96
|
| ')' is preceded with whitespace. |
96
|
| 'if' is not followed by whitespace. |
97
|
| '(' is followed by whitespace. |
97
|
| ')' is preceded with whitespace. |
97
|
| '{' should be on the previous line. |
98
|
| 'cast' is not followed by whitespace. |
100
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
100
|
| '(' is followed by whitespace. |
101
|
| ')' is preceded with whitespace. |
101
|
| '(' is followed by whitespace. |
103
|
| ')' is preceded with whitespace. |
103
|
| '{' should be on the previous line. |
105
|
| Line is longer than 80 characters. |
106
|
| '(' is followed by whitespace. |
106
|
| '(' is followed by whitespace. |
106
|
| ')' is preceded with whitespace. |
106
|
| ')' is preceded with whitespace. |
106
|
| '}' should be on the same line. |
107
|
| 'catch' is not followed by whitespace. |
108
|
| '(' is followed by whitespace. |
108
|
| ')' is preceded with whitespace. |
108
|
| '{' should be on the previous line. |
109
|
| Line is longer than 80 characters. |
110
|
| '(' is followed by whitespace. |
110
|
| ')' is preceded with whitespace. |
110
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Missing a Javadoc comment. |
114
|
| '(' is followed by whitespace. |
114
|
| ')' is preceded with whitespace. |
114
|
| '{' should be on the previous line. |
116
|
| '(' is followed by whitespace. |
117
|
| ')' is preceded with whitespace. |
117
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Missing a Javadoc comment. |
120
|
| '{' should be on the previous line. |
122
|
| '(' is followed by whitespace. |
123
|
| ')' is preceded with whitespace. |
123
|
| 'if' is not followed by whitespace. |
125
|
| '(' is followed by whitespace. |
125
|
| ')' is preceded with whitespace. |
125
|
| '{' should be on the previous line. |
126
|
| '(' is followed by whitespace. |
128
|
| ')' is preceded with whitespace. |
128
|
| '(' is followed by whitespace. |
129
|
| ')' is preceded with whitespace. |
129
|
| '(' is followed by whitespace. |
130
|
| ')' is preceded with whitespace. |
130
|
| 'if' is not followed by whitespace. |
132
|
| '(' is followed by whitespace. |
132
|
| ')' is preceded with whitespace. |
132
|
| '{' should be on the previous line. |
133
|
| '(' is followed by whitespace. |
134
|
| ')' is preceded with whitespace. |
134
|
| '(' is followed by whitespace. |
135
|
| ')' is preceded with whitespace. |
135
|
| '(' is followed by whitespace. |
142
|
| ')' is preceded with whitespace. |
142
|
| 'if' is not followed by whitespace. |
144
|
| '(' is followed by whitespace. |
144
|
| ')' is preceded with whitespace. |
144
|
| '{' should be on the previous line. |
145
|
| '(' is followed by whitespace. |
146
|
| ')' is preceded with whitespace. |
146
|
| '}' should be on the same line. |
147
|
| '{' should be on the previous line. |
149
|
| '(' is followed by whitespace. |
150
|
| '5' is a magic number. |
150
|
| ')' is preceded with whitespace. |
150
|
| 'if' is not followed by whitespace. |
153
|
| '(' is followed by whitespace. |
153
|
| ')' is preceded with whitespace. |
153
|
| '{' should be on the previous line. |
154
|
| '(' is followed by whitespace. |
155
|
| ')' is preceded with whitespace. |
156
|
| '}' should be on the same line. |
157
|
| '{' should be on the previous line. |
159
|
| '(' is followed by whitespace. |
160
|
| ')' is preceded with whitespace. |
161
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Missing a Javadoc comment. |
165
|
| '{' should be on the previous line. |
166
|
| '{' should be on the previous line. |
168
|
| '(' is followed by whitespace. |
169
|
| ')' is preceded with whitespace. |
169
|
| '}' should be on the same line. |
170
|
| 'catch' is not followed by whitespace. |
171
|
| '(' is followed by whitespace. |
171
|
| ')' is preceded with whitespace. |
171
|
| '{' should be on the previous line. |
172
|
| '(' is followed by whitespace. |
174
|
| ')' is preceded with whitespace. |
174
|
| '{' should be on the previous line. |
178
|
| '}' should be on the same line. |
180
|
| 'catch' is not followed by whitespace. |
181
|
| '(' is followed by whitespace. |
181
|
| ')' is preceded with whitespace. |
181
|
| '{' should be on the previous line. |
182
|
| '(' is followed by whitespace. |
184
|
| ')' is preceded with whitespace. |
184
|
org/apache/avalon/cornerstone/services/connection/DefaultHandlerFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
1
|
| Line has trailing spaces. |
5
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
13
|
| '{' should be on the previous line. |
27
|
| Missing a Javadoc comment. |
28
|
| Name 'm_handlerClass' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
28
|
| Variable 'm_handlerClass' must be private and have accessor methods. |
28
|
| Missing a Javadoc comment. |
30
|
| '(' is followed by whitespace. |
30
|
| ')' is preceded with whitespace. |
30
|
| '{' should be on the previous line. |
31
|
| Method 'newHandler' is not designed for extension - needs to be abstract, final or empty. |
41
|
| '{' should be on the previous line. |
43
|
| 'cast' is not followed by whitespace. |
44
|
| '(' is followed by whitespace. |
51
|
| Parameter connectionHandler should be final. |
51
|
| Expected @param tag for 'connectionHandler'. |
51
|
| ')' is preceded with whitespace. |
51
|
org/apache/avalon/cornerstone/services/connection/package.html
Error | Line |
| Missing package documentation file. | 0 |