Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Infos Warnings Errors
149 0 0 432

Files

Files I W E
org/apache/torque/Torque.java 0 0 1
org/apache/torque/TorqueInstance.java 0 0 26
org/apache/torque/TorqueRuntimeException.java 0 0 2
org/apache/torque/adapter/DB.java 0 0 4
org/apache/torque/adapter/DBCloudscape.java 0 0 2
org/apache/torque/adapter/DBFactory.java 0 0 2
org/apache/torque/adapter/DBPostgres.java 0 0 1
org/apache/torque/avalon/Torque.java 0 0 1
org/apache/torque/avalon/TorqueComponent.java 0 0 5
org/apache/torque/dsfactory/AbstractDataSourceFactory.java 0 0 1
org/apache/torque/dsfactory/DataSourceFactory.java 0 0 2
org/apache/torque/dsfactory/JndiDataSourceFactory.java 0 0 9
org/apache/torque/dsfactory/PerUserPoolDataSourceFactory.java 0 0 2
org/apache/torque/dsfactory/SharedPoolDataSourceFactory.java 0 0 3
org/apache/torque/manager/AbstractBaseManager.java 0 0 9
org/apache/torque/manager/MethodCacheKey.java 0 0 50
org/apache/torque/manager/MethodResultCache.java 0 0 4
org/apache/torque/map/ColumnMap.java 0 0 14
org/apache/torque/map/DatabaseMap.java 0 0 9
org/apache/torque/map/TableMap.java 0 0 14
org/apache/torque/oid/AutoIncrementIdGenerator.java 0 0 2
org/apache/torque/oid/IDBroker.java 0 0 9
org/apache/torque/oid/IDGeneratorFactory.java 0 0 1
org/apache/torque/oid/SequenceIdGenerator.java 0 0 2
org/apache/torque/om/BaseObject.java 0 0 3
org/apache/torque/om/DateKey.java 0 0 2
org/apache/torque/om/NumberKey.java 0 0 1
org/apache/torque/om/StringKey.java 0 0 1
org/apache/torque/package.html 0 0 1
org/apache/torque/util/BasePeer.java 0 0 4
org/apache/torque/util/CountHelper.java 0 0 46
org/apache/torque/util/Criteria.java 0 0 57
org/apache/torque/util/JoinBuilder.java 0 0 2
org/apache/torque/util/LargeSelect.java 0 0 38
org/apache/torque/util/LimitHelper.java 0 0 5
org/apache/torque/util/Query.java 0 0 34
org/apache/torque/util/SQLBuilder.java 0 0 16
org/apache/torque/util/SqlEnum.java 0 0 32
org/apache/torque/util/SqlExpression.java 0 0 7
org/apache/torque/util/Transaction.java 0 0 3
org/apache/torque/util/VillageUtils.java 0 0 5

org/apache/torque/Torque.java

Error Line
Error Utility classes should not have a public or default constructor. 41

org/apache/torque/TorqueInstance.java

Error Line
Error Unused import - org.apache.torque.dsfactory.AbstractDataSourceFactory. 36
Error Line has trailing spaces. 89
Error Line has trailing spaces. 90
Error Line has trailing spaces. 93
Error Line has trailing spaces. 94
Error Line has trailing spaces. 95
Error Redundant 'final' modifier. 183
Error 'conf' hides a field. 183
Error Redundant 'final' modifier. 213
Error 'conf' hides a field. 213
Error ';' is followed by whitespace. 234
Error 'conf' hides a field. 278
Error Line has trailing spaces. 337
Error 'conf' hides a field. 376
Error 'conf' hides a field. 394
Error 'conf' hides a field. 425
Error 'conf' hides a field. 511
Error Line contains a tab character. 630
Error Redundant 'final' modifier. 709
Error Redundant 'final' modifier. 783
Error 'catch' is not followed by whitespace. 823
Error Line contains a tab character. 838
Error Line contains a tab character. 839
Error Line contains a tab character. 841
Error Line contains a tab character. 843
Error 'catch' is not followed by whitespace. 884

org/apache/torque/TorqueRuntimeException.java

Error Line
Error 'nested' hides a field. 78
Error 'nested' hides a field. 92

org/apache/torque/adapter/DB.java

Error Line
Error Line contains a tab character. 76
Error Line contains a tab character. 77
Error Line contains a tab character. 78
Error Line contains a tab character. 79

org/apache/torque/adapter/DBCloudscape.java

Error Line
Error '132' is a magic number. 75
Error '3' is a magic number. 102

org/apache/torque/adapter/DBFactory.java

Error Line
Error Utility classes should not have a public or default constructor. 34
Error '40' is a magic number. 39

org/apache/torque/adapter/DBPostgres.java

Error Line
Error Missing a Javadoc comment. 39

org/apache/torque/avalon/Torque.java

Error Line
Error Missing a Javadoc comment. 30

org/apache/torque/avalon/TorqueComponent.java

Error Line
Error 'torqueInstance' hides a field. 84
Error Line is longer than 132 characters. 106
Error 'configFile' hides a field. 113
Error 'context' hides a field. 156
Error Line contains a tab character. 188

org/apache/torque/dsfactory/AbstractDataSourceFactory.java

Error Line
Error 'schema' hides a field. 250

org/apache/torque/dsfactory/DataSourceFactory.java

Error Line
Error Redundant 'public' modifier. 35
Error Redundant 'public' modifier. 41

org/apache/torque/dsfactory/JndiDataSourceFactory.java

Error Line
Error ';' is followed by whitespace. 126
Error 'ds' hides a field. 179
Error ';' is followed by whitespace. 184
Error 'ctx' hides a field. 242
Error 'ctx' hides a field. 263
Error 'path' hides a field. 263
Error 'ds' hides a field. 263
Error Must have at least one statement. 286
Error Must have at least one statement. 290

org/apache/torque/dsfactory/PerUserPoolDataSourceFactory.java

Error Line
Error 'ds' hides a field. 67
Error 'ds' hides a field. 83

org/apache/torque/dsfactory/SharedPoolDataSourceFactory.java

Error Line
Error 'ds' hides a field. 67
Error 'ds' hides a field. 83
Error Line contains a tab character. 111

org/apache/torque/manager/AbstractBaseManager.java

Error Line
Error Missing a Javadoc comment. 65
Error Missing a Javadoc comment. 67
Error Missing a Javadoc comment. 69
Error Missing a Javadoc comment. 71
Error Missing a Javadoc comment. 72
Error 'omClass' hides a field. 89
Error The double-checked locking idiom is broken and should be avoided. 461
Error 'isNew' hides a field. 499
Error Must have at least one statement. 506

org/apache/torque/manager/MethodCacheKey.java

Error Line
Error Missing a Javadoc comment. 32
Error Variable 'n' must be private and have accessor methods. 32
Error Missing a Javadoc comment. 33
Error Missing a Javadoc comment. 34
Error Missing a Javadoc comment. 35
Error Missing a Javadoc comment. 36
Error Missing a Javadoc comment. 37
Error Missing a Javadoc comment. 38
Error Missing a Javadoc comment. 39
Error 'instanceOrClass' hides a field. 45
Error 'method' hides a field. 45
Error 'instanceOrClass' hides a field. 50
Error 'method' hides a field. 50
Error 'arg1' hides a field. 51
Error 'instanceOrClass' hides a field. 56
Error 'method' hides a field. 56
Error 'arg1' hides a field. 57
Error 'arg2' hides a field. 57
Error 'instanceOrClass' hides a field. 62
Error 'method' hides a field. 62
Error 'arg1' hides a field. 63
Error 'arg2' hides a field. 63
Error 'arg3' hides a field. 64
Error 'moreThanThree' hides a field. 69
Error 'instanceOrClass' hides a field. 81
Error 'method' hides a field. 81
Error 'instanceOrClass' hides a field. 97
Error 'method' hides a field. 97
Error 'arg1' hides a field. 98
Error 'instanceOrClass' hides a field. 114
Error 'method' hides a field. 114
Error 'arg1' hides a field. 115
Error 'arg2' hides a field. 115
Error 'instanceOrClass' hides a field. 133
Error 'method' hides a field. 133
Error 'arg1' hides a field. 134
Error 'arg2' hides a field. 134
Error 'arg3' hides a field. 135
Error '3' is a magic number. 138
Error '3' is a magic number. 162
Error '4' is a magic number. 165
Error '3' is a magic number. 166
Error '3' is a magic number. 198
Error '5' is a magic number. 200
Error '3' is a magic number. 227
Error '5' is a magic number. 229
Error '50' is a magic number. 243
Error '3' is a magic number. 256
Error '5' is a magic number. 258
Error Missing a Javadoc comment. 272

org/apache/torque/manager/MethodResultCache.java

Error Line
Error Missing a Javadoc comment. 43
Error Missing a Javadoc comment. 44
Error Missing a Javadoc comment. 45
Error '10000' is a magic number. 55

org/apache/torque/map/ColumnMap.java

Error Line
Error Line has trailing spaces. 32
Error 'type' hides a field. 102
Error 'size' hides a field. 112
Error 'pk' hides a field. 122
Error 'columnName' hides a field. 165
Error Line has trailing spaces. 191
Error Line has trailing spaces. 193
Error Line has trailing spaces. 194
Error Line has trailing spaces. 196
Error Line has trailing spaces. 197
Error Line has trailing spaces. 270
Error Line has trailing spaces. 275
Error Line has trailing spaces. 283
Error 'scale' hides a field. 283

org/apache/torque/map/DatabaseMap.java

Error Line
Error 'name' hides a field. 66
Error '1.25' is a magic number. 69
Error '6' is a magic number. 70
Error 'name' hides a field. 78
Error '6' is a magic number. 82
Error 'name' hides a field. 102
Error 'name' hides a field. 147
Error ';' is preceded with whitespace. 164
Error 'idTable' hides a field. 209

org/apache/torque/map/TableMap.java

Error Line
Error 'tableName' hides a field. 78
Error '1.25' is a magic number. 84
Error 'tableName' hides a field. 93
Error '20' is a magic number. 97
Error 'tableName' hides a field. 108
Error 'prefix' hides a field. 109
Error '20' is a magic number. 115
Error 'prefix' hides a field. 202
Error Line has trailing spaces. 305
Error ',' is not followed by whitespace. 426
Error ')' is preceded with whitespace. 426
Error 'pkInfo' hides a field. 499
Error Redundant 'final' modifier. 512
Error Redundant 'final' modifier. 523

org/apache/torque/oid/AutoIncrementIdGenerator.java

Error Line
Error 'dbAdapter' hides a field. 49
Error 'name' hides a field. 49

org/apache/torque/oid/IDBroker.java

Error Line
Error '60000' is a magic number. 144
Error Must have at least one statement. 229
Error 'configuration' hides a field. 249
Error Redundant throws: 'TorqueException' is subclass of 'Exception'. 453
Error '100' is a magic number. 455
Error Must have at least one statement. 506
Error '10' is a magic number. 741
Error '50' is a magic number. 832
Error '50' is a magic number. 879

org/apache/torque/oid/IDGeneratorFactory.java

Error Line
Error Utility classes should not have a public or default constructor. 29

org/apache/torque/oid/SequenceIdGenerator.java

Error Line
Error 'dbAdapter' hides a field. 56
Error 'name' hides a field. 56

org/apache/torque/om/BaseObject.java

Error Line
Error 'primaryKey' hides a field. 115
Error 'primaryKey' hides a field. 127
Error 'primaryKey' hides a field. 139

org/apache/torque/om/DateKey.java

Error Line
Error Redundant throws: 'NumberFormatException' is unchecked exception. 46
Error Definition of 'equals()' without corresponding definition of 'hashCode()'. 123

org/apache/torque/om/NumberKey.java

Error Line
Error Redundant throws: 'NumberFormatException' is unchecked exception. 134

org/apache/torque/om/StringKey.java

Error Line
Error Definition of 'equals()' without corresponding definition of 'hashCode()'. 109

org/apache/torque/package.html

Error Line
Error Missing package documentation file. 0

org/apache/torque/util/BasePeer.java

Error Line
Error Utility classes should not have a public or default constructor. 73
Error '5' is a magic number. 89
Error Must have at least one statement. 263
Error ';' is followed by whitespace. 1545

org/apache/torque/util/CountHelper.java

Error Line
Error Missing a Javadoc comment. 36
Error '(' is followed by whitespace. 50
Error ')' is preceded with whitespace. 50
Error '(' is followed by whitespace. 52
Error ')' is preceded with whitespace. 52
Error '(' is followed by whitespace. 67
Error ')' is preceded with whitespace. 67
Error '(' is followed by whitespace. 69
Error ')' is preceded with whitespace. 69
Error '(' is followed by whitespace. 81
Error ')' is preceded with whitespace. 81
Error '(' is followed by whitespace. 84
Error ')' is preceded with whitespace. 84
Error '(' is followed by whitespace. 97
Error ')' is preceded with whitespace. 97
Error 'if' is not followed by whitespace. 109
Error '(' is followed by whitespace. 109
Error '&&' should be on a new line. 109
Error '&&' should be on a new line. 110
Error '(' is followed by whitespace. 111
Error ')' is preceded with whitespace. 111
Error ')' is preceded with whitespace. 111
Error Line contains a tab character. 112
Error '(' is followed by whitespace. 113
Error ')' is preceded with whitespace. 113
Error '(' is followed by whitespace. 117
Error ')' is preceded with whitespace. 117
Error '(' is followed by whitespace. 118
Error Expression can be simplified. 118
Error ')' is preceded with whitespace. 118
Error '(' is followed by whitespace. 119
Error ')' is preceded with whitespace. 119
Error '(' is followed by whitespace. 120
Error ')' is preceded with whitespace. 120
Error '(' is followed by whitespace. 122
Error ')' is preceded with whitespace. 122
Error 'if' is not followed by whitespace. 125
Error '(' is followed by whitespace. 125
Error ')' is preceded with whitespace. 125
Error '(' is followed by whitespace. 127
Error ')' is preceded with whitespace. 127
Error Line contains a tab character. 130
Error '(' is followed by whitespace. 131
Error ')' is preceded with whitespace. 131
Error '{' should be on a new line. 134
Error '{' should be on a new line. 137

org/apache/torque/util/Criteria.java

Error Line
Error File length is 3,840 lines (max allowed is 2,000). 1
Error Missing a Javadoc comment. 147
Error Missing a Javadoc comment. 149
Error Missing a Javadoc comment. 150
Error Missing a Javadoc comment. 151
Error Missing a Javadoc comment. 152
Error Missing a Javadoc comment. 153
Error Missing a Javadoc comment. 154
Error Missing a Javadoc comment. 155
Error Missing a Javadoc comment. 156
Error Missing a Javadoc comment. 157
Error Missing a Javadoc comment. 158
Error Missing a Javadoc comment. 175
Error Missing a Javadoc comment. 177
Error 'dbName' hides a field. 206
Error 'dbName' hides a field. 218
Error '8' is a magic number. 305
Error 'dbName' hides a field. 548
Error '3' is a magic number. 1353
Error ',' is not followed by whitespace. 1355
Error 'limit' hides a field. 1630
Error 'offset' hides a field. 1652
Error Must have at least one statement. 1805
Error '16' is a magic number. 1875
Error '37' is a magic number. 1876
Error '37' is a magic number. 1877
Error '37' is a magic number. 1878
Error '37' is a magic number. 1879
Error '37' is a magic number. 1880
Error '37' is a magic number. 1881
Error '37' is a magic number. 1882
Error '37' is a magic number. 1883
Error '37' is a magic number. 1884
Error '37' is a magic number. 1885
Error '37' is a magic number. 1886
Error '37' is a magic number. 1887
Error '37' is a magic number. 1888
Error 'having' hides a field. 1916
Error '3' is a magic number. 3066
Error 'joins' hides a field. 3103
Error Missing a Javadoc comment. 3131
Error Missing a Javadoc comment. 3132
Error Missing a Javadoc comment. 3159
Error 'table' hides a field. 3178
Error 'column' hides a field. 3178
Error 'table' hides a field. 3216
Error 'column' hides a field. 3216
Error 'db' hides a field. 3291
Error 'db' hides a field. 3458
Error '25' is a magic number. 3569
Error 'leftColumn' hides a field. 3747
Error 'rightColumn' hides a field. 3748
Error 'joinType' hides a field. 3749
Error '13' is a magic number. 3832
Error '37' is a magic number. 3833
Error '37' is a magic number. 3834
Error '37' is a magic number. 3835

org/apache/torque/util/JoinBuilder.java

Error Line
Error Utility classes should not have a public or default constructor. 35
Error Redundant 'final' modifier. 209

org/apache/torque/util/LargeSelect.java

Error Line
Error 'criteria' hides a field. 246
Error 'pageSize' hides a field. 246
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 247
Error 'criteria' hides a field. 269
Error 'pageSize' hides a field. 269
Error 'memoryPageLimit' hides a field. 269
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 270
Error 'criteria' hides a field. 300
Error 'pageSize' hides a field. 301
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 303
Error 'criteria' hides a field. 340
Error 'pageSize' hides a field. 341
Error 'memoryPageLimit' hides a field. 342
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 344
Error '{' is followed by whitespace. 353
Error '{' is followed by whitespace. 356
Error Redundant throws: 'SecurityException' is unchecked exception. 375
Error '{' is followed by whitespace. 379
Error 'criteria' hides a field. 400
Error 'pageSize' hides a field. 400
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 401
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 539
Error '500' is a magic number. 569
Error '{' is followed by whitespace. 650
Error Method length is 198 lines (max allowed is 150). 669
Error Line has trailing spaces. 674
Error Line has trailing spaces. 685
Error Line has trailing spaces. 692
Error Line has trailing spaces. 695
Error Line has trailing spaces. 714
Error 'if' construct must use '{}'s. 764
Error Line has trailing spaces. 778
Error Line has trailing spaces. 783
Error Line has trailing spaces. 785
Error Line has trailing spaces. 802
Error '100' is a magic number. 902
Error 'moreIndicator' hides a field. 1011
Error 'memoryPageLimit' hides a field. 1032

org/apache/torque/util/LimitHelper.java

Error Line
Error Utility classes should not have a public or default constructor. 33
Error Redundant 'final' modifier. 91
Error Redundant 'final' modifier. 124
Error Redundant 'final' modifier. 165
Error Redundant 'final' modifier. 215

org/apache/torque/util/Query.java

Error Line
Error Missing a Javadoc comment. 38
Error Missing a Javadoc comment. 39
Error Missing a Javadoc comment. 40
Error Missing a Javadoc comment. 41
Error Missing a Javadoc comment. 42
Error Missing a Javadoc comment. 43
Error Missing a Javadoc comment. 44
Error Missing a Javadoc comment. 45
Error Missing a Javadoc comment. 46
Error Missing a Javadoc comment. 48
Error Missing a Javadoc comment. 49
Error Missing a Javadoc comment. 50
Error Missing a Javadoc comment. 51
Error Missing a Javadoc comment. 52
Error Missing a Javadoc comment. 53
Error Missing a Javadoc comment. 54
Error Missing a Javadoc comment. 55
Error Missing a Javadoc comment. 56
Error Missing a Javadoc comment. 57
Error Missing a Javadoc comment. 58
Error 'having' hides a field. 174
Error 'limit' hides a field. 185
Error 'preLimit' hides a field. 196
Error 'postLimit' hides a field. 207
Error 'rowcount' hides a field. 218
Error ';' is followed by whitespace. 319
Error Variable 'tableName' must be private and have accessor methods. 381
Error Variable 'joinType' must be private and have accessor methods. 384
Error Variable 'joinCondition' must be private and have accessor methods. 387
Error 'tableName' hides a field. 403
Error 'joinType' hides a field. 404
Error 'joinCondition' hides a field. 405
Error '{' should be on a new line. 450
Error '{' should be on a new line. 454

org/apache/torque/util/SQLBuilder.java

Error Line
Error Utility classes should not have a public or default constructor. 45
Error ';' is followed by whitespace. 252
Error ';' is followed by whitespace. 259
Error '4' is a magic number. 268
Error Redundant 'final' modifier. 331
Error Redundant 'final' modifier. 353
Error ';' is followed by whitespace. 360
Error Redundant 'final' modifier. 377
Error Redundant 'final' modifier. 397
Error ';' is followed by whitespace. 410
Error Redundant 'final' modifier. 454
Error Redundant 'final' modifier. 544
Error Redundant 'final' modifier. 584
Error Line contains a tab character. 656
Error '(' is followed by whitespace. 695
Error Redundant 'final' modifier. 718

org/apache/torque/util/SqlEnum.java

Error Line
Error Class SqlEnum should be declared as final. 29
Error Missing a Javadoc comment. 31
Error 's' hides a field. 33
Error Missing a Javadoc comment. 43
Error Missing a Javadoc comment. 45
Error Missing a Javadoc comment. 47
Error Missing a Javadoc comment. 49
Error Missing a Javadoc comment. 51
Error Missing a Javadoc comment. 53
Error Missing a Javadoc comment. 55
Error Missing a Javadoc comment. 57
Error Missing a Javadoc comment. 59
Error Missing a Javadoc comment. 61
Error Missing a Javadoc comment. 63
Error Missing a Javadoc comment. 65
Error Missing a Javadoc comment. 67
Error Missing a Javadoc comment. 69
Error Missing a Javadoc comment. 71
Error Missing a Javadoc comment. 73
Error Missing a Javadoc comment. 75
Error Missing a Javadoc comment. 77
Error Missing a Javadoc comment. 79
Error Missing a Javadoc comment. 81
Error Missing a Javadoc comment. 83
Error Missing a Javadoc comment. 85
Error Missing a Javadoc comment. 87
Error Missing a Javadoc comment. 89
Error Missing a Javadoc comment. 91
Error Missing a Javadoc comment. 93
Error Missing a Javadoc comment. 95
Error Missing a Javadoc comment. 97
Error '!' is followed by whitespace. 112

org/apache/torque/util/SqlExpression.java

Error Line
Error Utility classes should not have a public or default constructor. 50
Error '25' is a magic number. 88
Error '40' is a magic number. 172
Error '20' is a magic number. 172
Error switch without "default" clause. 395
Error switch without "default" clause. 399
Error '1.1' is a magic number. 570

org/apache/torque/util/Transaction.java

Error Line
Error Utility classes should not have a public or default constructor. 44
Error Expression can be simplified. 117
Error Expression can be simplified. 157

org/apache/torque/util/VillageUtils.java

Error Line
Error Unused import - org.apache.torque.TorqueException. 28
Error Utility classes should not have a public or default constructor. 41
Error Must have at least one statement. 59
Error Must have at least one statement. 79
Error Must have at least one statement. 100